From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A757C459D7; Fri, 20 Sep 2024 12:57:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E93D4341A; Fri, 20 Sep 2024 12:57:18 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by mails.dpdk.org (Postfix) with ESMTP id B82F643417 for ; Fri, 20 Sep 2024 12:57:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kyyRKmXsa9DvxC64OBudI7SrfW3JCUPHzEJQspCsVeeWvd+rvVywt2BCm3n6JLtTKyKvUDEBIaLczyIKMtwB1t/BhcJoM6fDz/DVrep+rx0fNmhX5tg7y3VquPsyjRz1fGGVGMXPmPE/w4gXF6h6P6BwlbH3PBFPcQOuhiADGBzXwb1BMnpJ3ulumZG/ALRUL9XY44dzXUg6girrYhksgzxT5PEUdudeSD3Of7x5XoTlIpdlM2LwbEkgIRlEcmtUo1JyXMwGthei45ROPzrpTb4UdsOjFhgat/WLYtew1lZdljJ4QE2EMSlTEm09mL4vQ/EvSJgSMvezNB94aWCfTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ox5DAUIzIMp1ZHFcJyHYfgv7l7s4y7XbHmTsB9JWIHw=; b=Z+ujWZaZaP1T3tna4MNsUvC7EiFaa5sTnE31m8gbCR9Lydx/ZsjSamVsmBmGaGOfLSC7KIC6+c3lFGRpyBSda0TyhBb1Jn01ujkWehprRCibQdxDZLEs/fY1OJaYNoYxHy3pbPZdjSaRuK/YwJIu67l5RLYaPmXjagcSFGwD00oBNH/jnbJkRKAwmfAv1kLJBgW4Ty6i/VOTzzGdG4oN1rIDQ/BbpFJ/BoEZMppxqvfJKv4PeA6jfMlCQF2dy+6jP1uNO/tnR5XIORFMtWboJtAfO97SWw3dI26svAvYZtdypnPpoC36f0enWKRhMgWSdQoAUiObCkPeFgzPBE2UGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ox5DAUIzIMp1ZHFcJyHYfgv7l7s4y7XbHmTsB9JWIHw=; b=mCIBKBzjVIAePmkXqKYnF5Z6sxCOvVa715lN+wDp4+cf9XYEPuBODj7EE/Rm4nsCpNh2jvXJ4oSmFHVgVaOGeD52kA2v5s1OB1wEwSwL+yGBnbg1+0/5Fm+jZmtmU7UgFqT9Mm+h/mnUl5wpWzbpQfbhoHVGE2G1qDeMPVO3a5F6Xw44nLMucSuihlvV5Atoa+dwBX3IDgP34X+PtDAHFNA2v0kSOyCqbfmZbIjUzttFiAX5JOaPIpp5XlqdmhXQaH7gNRGvPXiZhCu2ngKT1GUYIaB8ciyCmZlxYGp1bXeBGFQqCyJn07zyctB4t5fvVXH8e63gRJiM4JZ1C1X/Xg== Received: from DUZPR01CA0212.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::18) by PR3PR07MB8212.eurprd07.prod.outlook.com (2603:10a6:102:177::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.21; Fri, 20 Sep 2024 10:57:12 +0000 Received: from DU2PEPF00028CFD.eurprd03.prod.outlook.com (2603:10a6:10:4b4:cafe::ac) by DUZPR01CA0212.outlook.office365.com (2603:10a6:10:4b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.29 via Frontend Transport; Fri, 20 Sep 2024 10:57:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU2PEPF00028CFD.mail.protection.outlook.com (10.167.242.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Fri, 20 Sep 2024 10:57:11 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.63) with Microsoft SMTP Server id 15.2.1544.11; Fri, 20 Sep 2024 12:57:11 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 42D19380070; Fri, 20 Sep 2024 12:57:11 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Jack Bond-Preston , David Marchand , Chengwen Feng , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions Date: Fri, 20 Sep 2024 12:47:53 +0200 Message-ID: <20240920104754.739033-7-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240920104754.739033-1-mattias.ronnblom@ericsson.com> References: <20240920062437.738706-2-mattias.ronnblom@ericsson.com> <20240920104754.739033-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028CFD:EE_|PR3PR07MB8212:EE_ X-MS-Office365-Filtering-Correlation-Id: b259ad66-4ffa-4a7f-71e6-08dcd962fad7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OXkvU0dPVDl2SVBHRFJYNlV6WThFdzhGTnl6Z2NuL21xK1FCQWpOekFoV0FB?= =?utf-8?B?b2JGZ0l5RkJUcHdGZmRybjAvU2lzUFkrWmZsSFhudDM5dDlkaGZtTHZ2Ujcr?= =?utf-8?B?MW5TY041bmVZR1FaOWZTZDlTOWQxMjBWYnplb1BSellWdklOZnlqYzMwbXV3?= =?utf-8?B?NGxEYlN3MkhSVDY0NWt2anQyVVVWc1cwY3JHUWNJMWNHRXlPUlYrblZQcXY1?= =?utf-8?B?TlY2YUp5TmdJSXUrM1NKWlA3ZkdXYjR3OTg2Y0VScC9vYUpyR2pSeXVCemgr?= =?utf-8?B?SzdQeDJLc2h0MlErMmF6enRVNzNqZTNaaC85Q21nQVh2eSs0TGdKQjFOYTRl?= =?utf-8?B?b00rMVB0TTNKbk9UVnhwTnFDaHlMQ0h5K1IxM21IdkFRQlQyemZaNDdqSW5s?= =?utf-8?B?N0o3N0c4U2JsR2Y4YjErUzZnbXUzUk9PQVJGTEpSRXNzK2tMc0FxUW51QTg2?= =?utf-8?B?cXJ6WWRVWDMwcENMdjJNQ3ZhRXlKOE0wQlNKYWg2cGtSRnpDaXRnL0Ztb3Z1?= =?utf-8?B?QWtrVTBSSklyYmFXRGZDa0R3b1B2Y2dCYmVZcDAveDM1UjhmajA4UG1aTUpV?= =?utf-8?B?c1BVZ0ZsUGF3WFkxejBiNjVRK2tKbElTK0tkOFpHM3FsOG9YZkwvdjR0bER3?= =?utf-8?B?M09iUWRsanM4ZVV1T0MzQU1DNjRDRCtoeWdGRUZwYmtBVnVhYUF6NVFjc2ND?= =?utf-8?B?ditqUmduQ3RHQUd6REl6T2xlekJ5ZHNhTzIwTGRQY1h4UTh3MndXVDQ2aDJH?= =?utf-8?B?M0lzZnNGRG5Cdzg4OUZ0SmNjcCthd1FhNVV2NjRYSkh6VjR6czV5L3dCaVVI?= =?utf-8?B?U3lLQUhSS0R5MHM0N1J3YVFkVGkrMHo2aG1zQ0VseFJMMUVxSk1NRHBHRnJa?= =?utf-8?B?OC9NMTIwUU5DN1poL3JieVJlVnZ5Vkx2OCtJV01SNkl1SVhTZ1Y5anhFK0FC?= =?utf-8?B?NVpCRmJ4Zy8rUXBtZFVEa29NN2JQOHpsSEJyZ0JiZGpkRUs2ZjhhZWZ2d0NG?= =?utf-8?B?Q3pxYmlJUHdVa1B3aWVpZHJMdkIyU2lyb1JseUVpWVJaeW16c2RyYjZKK3lU?= =?utf-8?B?VGdFUGxFa25TU3NmUk9UWjhWOXQwMlNrVnR3OVd6OC8xLzE3RDdCSGxWRVRO?= =?utf-8?B?TXdMNFd3RjFrSm1xblZ1RUJOSUdWVnJYeDNzeXo1WkFhTkxMZU85LzNCdDdx?= =?utf-8?B?S0VqZVNaVlhPV3VQcHBlUTI5dXBnUDZCdnBmazVBbWZ1NUc2R0pUeUltNTJw?= =?utf-8?B?T2tiOHpKSlRmME1xSFAraFMxeEFYWWNTRjNYMU8zZGx4cUs5RVAwc0QrSUxH?= =?utf-8?B?a2t2ZTNzS09HOHBYTS9UcnoyZGc5Z3lib1p4QlRLWWNTYTgxQ2lIQzBYSmlO?= =?utf-8?B?a3ZSemdsNVdSaTl4ZjNKVEV1Qm5sWkRFK1VzZjkrMlNmM0psSGRBVmZTSzZ3?= =?utf-8?B?YW9uZWRPdms0K3M0UWlFek1FZndabU9hVUFKZzdHclVPUmpyVFlvdllvbUd5?= =?utf-8?B?WEd3VEY2eitEZE43eUpHQzlCV2ozejdRSmtBZDU4a1ZlRXVxbElWM3Rma3VY?= =?utf-8?B?WUc1L05VMkE2YUJwaFlqcVBnVk9pTmdIRjVaS1RHdmVHTURxUDhybHJOT1dt?= =?utf-8?B?cURiVUl2WFI3dmJGc0cza3hWUG1QOWdPYnNmbFBCemxUdFhkWTdBM3Joa1hq?= =?utf-8?B?VXdqck9zUWFWOThIeGFZdGlvRWI1aUw1eEZXYVdRN2c5TFZObjFYSmJWeFJs?= =?utf-8?B?cWM0TFBNMWJuT0dTbVRpUmVxZ0FUYzhMdFhTV1p1TVZISGRwZlFyQlkrWmlh?= =?utf-8?B?RUNpTHN5WXRzVHFuT1lsd2dVOUVCM3l6TzlPWldiVDlBRFhScXo0bWwwQkk2?= =?utf-8?Q?ZHF+ReTbQ8tjG?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2024 10:57:11.7432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b259ad66-4ffa-4a7f-71e6-08dcd962fad7 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028CFD.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR07MB8212 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.43.0