From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0216459D7; Fri, 20 Sep 2024 13:11:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72E6B433C6; Fri, 20 Sep 2024 13:11:30 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 8A5B3427C9; Fri, 20 Sep 2024 13:11:29 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20543fdb7acso16477025ad.1; Fri, 20 Sep 2024 04:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726830688; x=1727435488; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pSjjWAm0Xm2VGIlxMBV9CQNKtILBQi0seglqE+xP0Ng=; b=Swt5Ul1/1oWTXYs6XRXZAnHvlb/11m6slJ73Fow044zVsmKVaY9HWuQ4rgQIAqae12 YaYGL8gtcNNU4ijMkdslrOiXc/TUDXbRSdUxpA+07xv9fOqKBnjhMbGaZ/spjE9wVw+Q ZmAM6LWPRdLBVVlGMeAasqMHB4osdPTot6YwsYNjEqOpAsTtFFhv71wV4iClM+TYhbkw btawTknz7x3u21lLHspBFj50itM/XtPhnL331bARl16z5ksWkXIQoe6MvYxiRqC7NX/J /0GfGMMZQveg2cwet/9jG1uqk0oZxlle7oxZj20xoEEi9RL8WckZrbUnfF72LixNMM3A ciww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726830688; x=1727435488; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pSjjWAm0Xm2VGIlxMBV9CQNKtILBQi0seglqE+xP0Ng=; b=I5nNq7OQWmmB5zf962NZ4iOcQ4pIWD/wgEDaBVtbnm4zcnrQpdKlOA/IQQFLdFz65D nRVCZsnUqDCmYquIFAvnupITZaqgr1cGfkI8NNoR+VVsWAZV8GLIltDciEIOb+IJRJDO J2THgIABUMfUj7gadTpdrmykuB5/1tfmiSET1gzCOjBOlfVkXeUoVn44yTrCsD678NpM nBMN0hX6/KiVsMSryjnWT8pKZ0n/axyI74yZvZqnpD3U/1UJwAxZs+KKCwcBfzF8k0CH XrtkKAEbSyBBijxLc/YV0RXp20SqICS9M1BREwAXwU/zAaw0/0NdRHtgiGKoJlhz7CQY qTpQ== X-Forwarded-Encrypted: i=1; AJvYcCUDa/WLZHIB4D9OkQWnO+dY4hmZmcNoMK+BuvRLGa3ntS+zMKJV+ZzxVFDv8uJqaccS7Opuuq8=@dpdk.org X-Gm-Message-State: AOJu0YwbjOPHG2NSb/GTPXGd1zr/yg3Ju0w+T7czN8u/Z0AUc0b9eEYA tGNtIOgp5b0v370FsR3RJYKU2/Tbp3EOFQ1HPTQKEtx8xJZwrdd0 X-Google-Smtp-Source: AGHT+IHycdYjKIvLgEzf0dEGAh0nEU8m5Pud39+uRHpkb/75XydgSRC6mmf/SxM6ZodiDuwIBHJCuw== X-Received: by 2002:a17:903:41cc:b0:206:64b4:3088 with SMTP id d9443c01a7336-208d83cda24mr36121825ad.29.1726830688443; Fri, 20 Sep 2024 04:11:28 -0700 (PDT) Received: from localhost.localdomain ([106.51.30.253]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-207945da9absm92793125ad.51.2024.09.20.04.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 04:11:27 -0700 (PDT) From: Shreesh Adiga <16567adigashreesh@gmail.com> To: Long Li , Wei Hu Cc: dev@dpdk.org, stable@dpdk.org, thomas@monjalon.net Subject: [PATCH] net/mana: support rdma-core via pkg-config in meson Date: Fri, 20 Sep 2024 16:41:16 +0530 Message-ID: <20240920111116.1486095-1-16567adigashreesh@gmail.com> X-Mailer: git-send-email 2.44.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently building with custom rdma-core installed in /opt/rdma-core after setting PKG_CONFIG_PATH=/opt/rdma-core/lib64/pkgconfig/ results in the below meson logs: Run-time dependency libmana found: YES 1.0.54.0 Header "infiniband/manadv.h" has symbol "manadv_set_context_attr" : NO Thus to fix this, the libs is updated in meson.build and is passed to the cc.has_header_symbol call using dependencies. After this change, the libmana header files are getting included and net/mana is successfully enabled. Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") Cc: longli@microsoft.com Cc: stable@dpdk.org Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com> --- drivers/net/mana/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build index 2d72eca5a8..3ddc230ab4 100644 --- a/drivers/net/mana/meson.build +++ b/drivers/net/mana/meson.build @@ -19,12 +19,14 @@ sources += files( ) libnames = ['ibverbs', 'mana'] +libs = [] foreach libname:libnames lib = dependency('lib' + libname, required:false) if not lib.found() lib = cc.find_library(libname, required:false) endif if lib.found() + libs += lib ext_deps += lib else build = false @@ -43,7 +45,7 @@ required_symbols = [ ] foreach arg:required_symbols - if not cc.has_header_symbol(arg[0], arg[1]) + if not cc.has_header_symbol(arg[0], arg[1], dependencies: libs, args: cflags) build = false reason = 'missing symbol "' + arg[1] + '" in "' + arg[0] + '"' subdir_done() -- 2.44.2