From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDF3045A03; Tue, 24 Sep 2024 17:30:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88D8C4028E; Tue, 24 Sep 2024 17:30:27 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id 98C6740274 for ; Tue, 24 Sep 2024 17:30:26 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7a9af813f6cso540218085a.3 for ; Tue, 24 Sep 2024 08:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727191826; x=1727796626; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T/JEJculhE49SLrkWd2iUIS8L5wWe7uotKRTVZvQe18=; b=oYNgVjmhqR3nZR3yCFmjOuhiRqE0U+eQch0koj0ux5stuKaT2LYZbl9M9qU7cb48NM F40lCSPqxTbtddvxojL+nEtE6m0Tk8WcsCr5Z8hix7nZp5/6erdxH8INdJRYNwZNSz9Q GNYK07U6jOMTm1HVHwono3l3tWMR6UGCTrKIDKaeDbrYD4k7G/s/8jSokIT4wG4MZ7LM aQJnMI3km0Ka9eAY+TGx21PAWyxXbz/FYXTC1eHhQ3rtu0iCiw0Yw9k/MvrM1slWo5fu Z0gFq3Gabh2OwD+L+7H1wCdh9iRZ277K9hGk3PK3tC+6scY6BWebYvfZUJWDAGg3tN5e eayg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727191826; x=1727796626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T/JEJculhE49SLrkWd2iUIS8L5wWe7uotKRTVZvQe18=; b=ZaB20xDzvvfA1hsyUBM9mOYtvxOhIztUDq0HYlp4mMzEEpyeYAeeLA9jYhYIIjTnZl 97UN7c57fBR+4XwLNyFAou/jfK1Vk/wRELmEGEciarByPMMIMTJfs8b+QO8oWaeZXQXd sCAhheAisu8PsUPjHo4r/p74RBJX+IIjpLJoMIrUzhmp+qD7QMw0v2m1f9NGFa5DKxJW uK1718Se4pWG0wDgF9GGVq9G0dASEuciE2hs4jiW8X1vWxMfBTUnRSGe6VoEWPI5PfU5 oBYNSmf+AJENtLd3DSjvqyMM6vtXoJcq9H+2pxi47KK1tc2SXa1toyg0F1iHnJKYtOyC cQVg== X-Forwarded-Encrypted: i=1; AJvYcCWgX3frcSGmtLs9IGLp/y3WNxUBa7ywnfexHGZ5JGSzbcu7EAmZjumZuBkfkd04I2yKBt8=@dpdk.org X-Gm-Message-State: AOJu0YwZfn/IejtXAK3eIzXyMqn4+B8FHO+uhwllY78SEau0Zx/ycC2N cv869giU4fMPfqKou542wX7otIEj3R/qm4MqDmFlBssOCkYKmpqxXOKrpyh9Lq0= X-Google-Smtp-Source: AGHT+IGGU6xNyeqApC27T6ucxmMA8nsTyG3WlSchAmhRi5h21ANNbbi7rgJpMO3SsQT1pK/aCUO3yg== X-Received: by 2002:a05:620a:f03:b0:7a9:c3da:a806 with SMTP id af79cd13be357-7acb8e1e7eemr2304111485a.54.1727191825786; Tue, 24 Sep 2024 08:30:25 -0700 (PDT) Received: from fedora ([173.242.185.50]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7acde531853sm78635685a.9.2024.09.24.08.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 08:30:25 -0700 (PDT) Date: Tue, 24 Sep 2024 08:30:23 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: Jerin Jacob , Sunil Kumar Kori , dev@dpdk.org Subject: Re: [PATCH v4] eal: add build-time option to omit trace Message-ID: <20240924083023.28bf896a@fedora> In-Reply-To: <20240924133957.1505113-1-mb@smartsharesystems.com> References: <20240918085551.231015-1-mb@smartsharesystems.com> <20240924133957.1505113-1-mb@smartsharesystems.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 24 Sep 2024 13:39:57 +0000 Morten Br=C3=B8rup wrote: > Some applications want to omit the trace feature. > Either to reduce the memory footprint, to reduce the exposed attack > surface, or for other reasons. >=20 > This patch adds an option in rte_config.h to include or omit trace in the > build. Trace is included by default. >=20 > Omitting trace works by omitting all trace points. > For API and ABI compatibility, the trace feature itself remains. >=20 > Signed-off-by: Morten Br=C3=B8rup This is good compact solution. In future, it would be nice if DPDK could use static keys to isolate rarely used features. But static keys require runtime modification of instructions. https://docs.kernel.org/6.7/staging/static-keys.html Acked-by: Stephen Hemminger