From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1860845AA4; Fri, 4 Oct 2024 00:44:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02BDF40273; Fri, 4 Oct 2024 00:44:36 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 1A3F54021F for ; Fri, 4 Oct 2024 00:44:35 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-20bc506347dso12964885ad.0 for ; Thu, 03 Oct 2024 15:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727995474; x=1728600274; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jOXD4eR5ddHosB4Wvqf9z2LnE2bAmjCJYhMuR2mR8ew=; b=XvScP+Gh9V+/HdO3e7sBn2yuuhBQFULuL0PJ7KsXxywVN4BNdC18qxyfhAdxBBZPBc pDisHDJOBUG1ujybntB1tYI53IrvxJg0lYifo9F8umG92DzfCMHI7PrVVVBgYYQuNm+P u72v/NUY9FeaEMU95zR+as5fsLqgry2sD6R2yWtk/y8hjFy0DVq49S02HFC10s+C7DJc O3Z2GDltRt4G2gZGrad+z4EyHia69lXkEJtCX4pgJ4qUEnz5qyjlfl6Hdsei4QF/xx9i 3olelR63ZEHXAj6uM5mDGbfrxgKBkiSxuDPWAXUmgTBzRnYSwVkh/BLCP8K94XtKKqnn bN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727995474; x=1728600274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jOXD4eR5ddHosB4Wvqf9z2LnE2bAmjCJYhMuR2mR8ew=; b=tda+HsFyhj0YTAzDBW52pvu5MxsTUL9fv7CnRtApMuAyC12Q1luZ7URlHQEq0WrrAY TSVOLsnLnwiWB57wdgXQmnYqWC1cJvZYkYpw+0q8dtMizkntAQ28NAV/GUojDT1ljFET 47ySoUmTiG/yKOQWOlJpC4rAFOkvuKy6+A0hFw6D/K/I1Em0nbLe6887SvFuT59g/i7L 5r7S7ySlLEp8GffG41Uv8V4lU2KKILTBp2zjt+EvwNLXh4ecIRUk35Mk58560tu0K++G CD9lT4wRnt8AarR1ah5n8fZTMBWmyjYQM+Axe13uDJss+CWHbHicESdVcrt13lBe9nN8 vT5g== X-Forwarded-Encrypted: i=1; AJvYcCVwQBnE61TlG1c6oEXpJDddXnjy8ljIhMbVjBxePrWslfmgKXUdmPP5S196uh749aK85dc=@dpdk.org X-Gm-Message-State: AOJu0YycQ4qh2ZeoUYqkDU9npYV9EDK9YEbUNrrYHwn036Z087hyM5BL JRlWBZlzRPkipE/g0IFMSwQdmO7lzqXjhuAS8GwsYa1pxlt0HJPKi5kxJKbd8Ls= X-Google-Smtp-Source: AGHT+IEn8/gh1X8GC0WjgSbEZLbSlKITOyfjXYXFO8uWu0ljDQFtjswSoX3H7eH1yYyAN5vsewZnaA== X-Received: by 2002:a17:903:244b:b0:20b:b455:eb77 with SMTP id d9443c01a7336-20bff175458mr10098065ad.48.1727995474100; Thu, 03 Oct 2024 15:44:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20beeca2fa7sm13772195ad.100.2024.10.03.15.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 15:44:33 -0700 (PDT) Date: Thu, 3 Oct 2024 15:44:31 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Tyler Retzlaff , dev@dpdk.org, Dmitry Kozlyuk Subject: Re: [PATCH v5 2/2] eal: initialize shared plugins on Windows Message-ID: <20241003154431.69f13d7e@hermes.local> In-Reply-To: <3248363.l52yBJDM9G@thomas> References: <1701976851-17275-1-git-send-email-roretzla@linux.microsoft.com> <9541360.2WqB4rESCP@thomas> <20240529175639.GA22530@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <3248363.l52yBJDM9G@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 30 May 2024 10:02:46 +0200 Thomas Monjalon wrote: > > are you asking for the unix and windows implementations to be moved out > > to eal/{windows,unix} respectively rather than the current conditional > > compiled in eal/common? > > Yes I feel it would be better. > Please tell me if I missed something. > > > > Also, the CI is failing with this patchset. > > > > > > > i'll take a look when i get a chance, you can leave it unmerged for now. Marking it as changes requested. Would be good to split as requested.