From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A838D45AA4; Fri, 4 Oct 2024 01:24:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EA244066E; Fri, 4 Oct 2024 01:24:41 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 15B9940674 for ; Fri, 4 Oct 2024 01:24:40 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7179069d029so1229344b3a.2 for ; Thu, 03 Oct 2024 16:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727997879; x=1728602679; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Lxs7iCA7aZtdFW4Cx1A7cByOS8zonF9D0Vt0nloINgk=; b=QtyjaRbI/e9xazbB9Bk1CH14TOQDjunqJ4OB7LLviczl/RO3BapX5Bbf3LExFddRey Q+73qbCkeG5B49OGvFJ0iIAx52JTpCSgZYjoskp075U94dJa8hrXcvx8KtejahcP6oBv 4jR14QpHHbga7iS0XUruWmOogDuRCijl1RiVzgeD+3WT2/97DNX6ZdphQg/UYkkAqY3X fmvFvYAu8FT56ea41aaQ35FaaMihXrrBhC4b5jPyGgUvI0ZR1t8dzPwgS3DFiWou9wCL IsIU+oS41EJbmciFa62TO2lSNyhXpp1bbB3sbL/ALbHi5Ef/ysv3kCQb/Fm32LUzngJH 3C8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727997879; x=1728602679; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lxs7iCA7aZtdFW4Cx1A7cByOS8zonF9D0Vt0nloINgk=; b=gq9yQ0pKoJMbU4MYHVNRyrmESEu9DsZryeEbIoVBEojCLwj+JYL423vUWeLlyQ3X2H HZWKd72er29SEXUxwwD30hooer8NC+icyFxZ7wMUn+p+hZgVeCDMCa3UA2GwYGTkyUHv ZddTgNGRypvd2pXnRXViAfFN37A6ujSPaSnNXyGz5f1/+j4jX6gZp4VyxHyjRPrq4up2 6flmTPxJDReF5KhtlciwvchftyoY3oL+wnhG6lMMWxKRDka4w81BSnapeJJjHreiVI/X TVL+mG25dDibROwL7MkonN14HwDMdYQ3O0xDNcBfeH78Krx3h188Pzhm/Av+IuEBlHes zClw== X-Gm-Message-State: AOJu0YwCEhNV8JeMtqrxtiuI62IQVSGCGu0nh9UwiAqbaGoqt4vedJ3k DqdJff22FzklvLPSxJD3nxeMDgeJ4tx6lt6iohXqr2pF82yijRNhF+iV+a8r5JU= X-Google-Smtp-Source: AGHT+IEe05klo+CcgCh0W/DW1B/5FrBgqf3BaCuUgkh4K7g+U/U+YHVMtzt2A3YCv/+nu8w3vGMu4Q== X-Received: by 2002:a05:6a21:a24c:b0:1d3:1765:c09c with SMTP id adf61e73a8af0-1d6dfa486e7mr1290079637.29.1727997879303; Thu, 03 Oct 2024 16:24:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9dcb5cdc1sm1099317a12.86.2024.10.03.16.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 16:24:39 -0700 (PDT) Date: Thu, 3 Oct 2024 16:20:18 -0700 From: Stephen Hemminger To: Robin Jarry Cc: dev@dpdk.org, Wisam Jaddo , Cristian Dumitrescu , Konstantin Ananyev , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Ajit Khaparde , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Potnuri Bharat Teja , Hemant Agrawal , Sachin Saxena , Ziyang Xuan , Xiaoyun Wang , Jie Hai , Yisen Zhuang , Jingjing Wu , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Chaoyong He , Devendra Singh Rawat , Alok Prasad , Andrew Rybchenko , Jiawen Wu , Jian Wang , Radu Nicolau , Akhil Goyal , Thomas Monjalon , Ferruh Yigit , Nithin Dabilpuram , Pavan Nikhilesh Subject: Re: [PATCH dpdk v2 04/16] net: use ipv6 structure for header addresses Message-ID: <20241003162018.7647ef9d@hermes.local> In-Reply-To: <20241001081728.301272-5-rjarry@redhat.com> References: <20240821162516.610624-17-rjarry@redhat.com> <20241001081728.301272-1-rjarry@redhat.com> <20241001081728.301272-5-rjarry@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 1 Oct 2024 10:17:16 +0200 Robin Jarry wrote: > diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c > index 2cd34abc1a65..76a409a56452 100644 > --- a/app/test/packet_burst_generator.c > +++ b/app/test/packet_burst_generator.c > @@ -149,8 +149,8 @@ initialize_ipv6_header(struct rte_ipv6_hdr *ip_hdr, uint8_t *src_addr, > ip_hdr->proto = IPPROTO_UDP; > ip_hdr->hop_limits = IP_DEFTTL; > > - rte_memcpy(ip_hdr->src_addr, src_addr, sizeof(ip_hdr->src_addr)); > - rte_memcpy(ip_hdr->dst_addr, dst_addr, sizeof(ip_hdr->dst_addr)); > + rte_memcpy(&ip_hdr->src_addr, src_addr, sizeof(ip_hdr->src_addr)); > + rte_memcpy(&ip_hdr->dst_addr, dst_addr, sizeof(ip_hdr->dst_addr)); please replace with structure assignment if possible.