From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5842345AA4; Fri, 4 Oct 2024 01:24:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 201F64065A; Fri, 4 Oct 2024 01:24:38 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 13CBE40647 for ; Fri, 4 Oct 2024 01:24:37 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7db1f0e1641so480850a12.1 for ; Thu, 03 Oct 2024 16:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727997876; x=1728602676; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TYZZ0fRlCQLgdjJBYtidaRny2Zpb9LpT8jdpZvY0Yq8=; b=JOatWVzjyvmH/vD2SQV4nZ+TruuQtlUQlfFExkKi29RLlB7rWeN+fPFQYDsWSZ/oob uzL6++1jcpSnOqKqnUwpbrOMByuVb9DjBZ1NglUAKvo8WZ/bAkkmclyL3UGSIZSk4B3/ XF7XqMateU2/tY84WhlGE4O51QPdmNFx3xFYdCfoth5v1WxAiy1fw7vAE2HkALvJ4jCa ausfi3GuOlew6hp61eZcX4CcmAV5rvhFz6EhHTJaFQEtLfkKw54Cp8KAFzg+IyeLg3gi KlPPmzNYdbKyfZ37YPLTIhga3W3F0eijFhcBHfN381DMcdoo57JNVHyuv21S4RQa24n9 Kqrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727997876; x=1728602676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TYZZ0fRlCQLgdjJBYtidaRny2Zpb9LpT8jdpZvY0Yq8=; b=wml4gyk5QiP9zGB7Zzq5oSnHxKU0wjRYfF4Eso4orE+BXxVcfRJgl2mcRcJuFiXsjy L40+fy9VGQzZZQDvXY7OqurxC2J4CqVeSSJpzAIHZVgluugG0o1cO8Rm14aAbtf18DIE u0izfh62NcEE1a+Rq/41EicUVAou1J8dbLqhkkQMbP5fg8KEgozigFys5R1F/HypyHZQ /KkH+tAPOHRDaPG6w7EJj9VlKJg2Kd3/IOgB2ZugCAijHoN9zzWfqdIMkqGjA1k/IifS dxhiKPIFlq+7WWuEV7BTDO95Mucz9li77ZB6NuYPC6EuRpA48WRJVeiWPjJJYRHPojkE CzUg== X-Gm-Message-State: AOJu0YyHbGESKazH2zS3i79oCRzLG9Qf0HhEuuIw2gjRU4s8w9ko5Gba kML3RlWJJYBjPCtwjAGJLfP/5YP9RqQDwY34YZ0GcRVr7q/mSL/oDH4D11jz35o= X-Google-Smtp-Source: AGHT+IF8bQb6na/YBZMcZmnL/Q4pBrdFILAklPZxGewsVCRADi6BxbegVb63aPn+EAXkoCK+zagvlA== X-Received: by 2002:a05:6a20:6f07:b0:1d5:119b:3ab with SMTP id adf61e73a8af0-1d6dfa38f1bmr1407775637.11.1727997876114; Thu, 03 Oct 2024 16:24:36 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9dcb5cdc1sm1099317a12.86.2024.10.03.16.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 16:24:35 -0700 (PDT) Date: Thu, 3 Oct 2024 16:21:22 -0700 From: Stephen Hemminger To: Robin Jarry Cc: dev@dpdk.org, Vladimir Medvedkin , Cristian Dumitrescu , Bruce Richardson , Konstantin Ananyev , Wathsala Vithanage , Radu Nicolau , Akhil Goyal , Nithin Dabilpuram , Pavan Nikhilesh Subject: Re: [PATCH dpdk v2 05/16] fib6,rib6,lpm6: use ipv6 addr struct Message-ID: <20241003162122.6a2ccf65@hermes.local> In-Reply-To: <20241001081728.301272-6-rjarry@redhat.com> References: <20240821162516.610624-17-rjarry@redhat.com> <20241001081728.301272-1-rjarry@redhat.com> <20241001081728.301272-6-rjarry@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 1 Oct 2024 10:17:17 +0200 Robin Jarry wrote: > Replace ad-hoc uint8_t[16] array types in the API of rte_fib6, rte_rib6 > and rte_lpm6. Update all code accordingly. > > Unfortunately, these three libraries are strongly intertwined, it is not > possible to split this change in separate commits. > > Signed-off-by: Robin Jarry > --- > > Notes: > v2: updated changelog for 24.11 > > app/test-fib/main.c | 51 +- > app/test-pipeline/pipeline_lpm_ipv6.c | 10 +- > app/test/test_fib6.c | 52 +- > app/test/test_fib6_perf.c | 8 +- > app/test/test_lpm6.c | 523 +++--- > app/test/test_lpm6_data.h | 2025 ++++++++++++------------ > app/test/test_lpm6_perf.c | 10 +- > app/test/test_rib6.c | 65 +- > app/test/test_table_combined.c | 2 +- > app/test/test_table_tables.c | 8 +- > doc/guides/rel_notes/deprecation.rst | 20 - > doc/guides/rel_notes/release_24_11.rst | 2 + > examples/ip_fragmentation/main.c | 24 +- > examples/ip_pipeline/thread.c | 2 +- > examples/ip_reassembly/main.c | 24 +- > examples/ipsec-secgw/ipsec_lpm_neon.h | 7 +- > examples/ipsec-secgw/ipsec_worker.c | 6 +- > examples/ipsec-secgw/ipsec_worker.h | 4 +- > examples/ipsec-secgw/rt.c | 22 +- > examples/l3fwd/l3fwd_fib.c | 39 +- > examples/l3fwd/l3fwd_lpm.c | 8 +- > examples/l3fwd/l3fwd_route.h | 7 +- > examples/l3fwd/lpm_route_parse.c | 6 +- > lib/fib/meson.build | 4 +- > lib/fib/rte_fib6.c | 13 +- > lib/fib/rte_fib6.h | 11 +- > lib/fib/trie.c | 99 +- > lib/fib/trie.h | 16 +- > lib/fib/trie_avx512.c | 38 +- > lib/fib/trie_avx512.h | 10 +- > lib/lpm/meson.build | 1 + > lib/lpm/rte_lpm6.c | 106 +- > lib/lpm/rte_lpm6.h | 14 +- > lib/node/ip6_lookup.c | 16 +- > lib/rib/meson.build | 2 +- > lib/rib/rte_rib6.c | 74 +- > lib/rib/rte_rib6.h | 13 +- > lib/table/rte_table_lpm_ipv6.c | 12 +- > lib/table/rte_table_lpm_ipv6.h | 4 +- > 39 files changed, 1683 insertions(+), 1675 deletions(-) > > diff --git a/app/test-fib/main.c b/app/test-fib/main.c > index c49bfe8bcec3..a43a0ae4df5d 100644 > --- a/app/test-fib/main.c > +++ b/app/test-fib/main.c > @@ -123,7 +123,7 @@ struct rt_rule_4 { > }; > > struct rt_rule_6 { > - uint8_t addr[16]; > + struct rte_ipv6_addr addr; > uint8_t depth; > uint64_t nh; > }; > @@ -306,15 +306,15 @@ shuffle_rt_6(struct rt_rule_6 *rt, int n) > > for (i = 0; i < n; i++) { > j = rte_rand() % n; > - memcpy(tmp.addr, rt[i].addr, 16); > + memcpy(&tmp.addr, &rt[i].addr, 16); Yet more places where memcpy should be replaced by assignment.