Re: [PATCH v3 19/26] app/dumpcap: use separate Rx and Tx queue limits

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 14 Aug 2024 11:49:25 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> Update app to use the new defines RTE_MAX_ETHPORT_TX_QUEUES and
> RTE_MAX_ETHPORT_RX_QUEUES rather than the old define
> RTE_MAX_QUEUES_PER_PORT.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
>  app/dumpcap/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index 6feb8f5672..fbaaa4fe3f 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -95,7 +95,7 @@ struct interface {
>  	struct rte_bpf_prm *bpf_prm;
>  	char name[RTE_ETH_NAME_MAX_LEN];
>  
> -	struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
> +	struct rte_rxtx_callback *rx_cb[RTE_MAX_ETHPORT_RX_QUEUES];
>  	const char *ifname;
>  	const char *ifdescr;
>  };

Looking closer, this field is defined and never used, it can go.

That structure is used to gather the command line arguments
before applying them.