From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91D7C45AA4; Fri, 4 Oct 2024 01:38:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1498340664; Fri, 4 Oct 2024 01:38:08 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 659834066C for ; Fri, 4 Oct 2024 01:38:06 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-207115e3056so13988325ad.2 for ; Thu, 03 Oct 2024 16:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727998685; x=1728603485; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yMcTFmR5HLbN5uFmfEcr5fOIMe0DzZrs8bFzNxsHFbA=; b=jF6tYZmjXw7Wsh5JfgJbBT0KvqdTT6F3aeMHkyjcmWyHR8W21VUsCerHXCtZ3Gto+I PRxYLgdDMEpnwAspezbFFNWU1hfUaWtfnJmvQpqsP7rO0AU7NIvWCFwLMi8A+c1u5S9R 1YG57VAxRvPw6KDc/RDXV7eCSVIXaJw0zJfpQ0G8cf0LyrHf2/biCkb5kJ4I//s8q5Th 1y9ng5K99qxhyYn9tjKz6ct6idT71ULNOQ67Cy5yMs64yYz23m4a0EbaIFV2zrnDq7Hd iaTDZRzXi4VsQjs0qyvPfFYSO0S5VqaBL+TfJ+LkwIdp4MIntc43JxFdzX2s2ldG9Yb9 gVBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727998685; x=1728603485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yMcTFmR5HLbN5uFmfEcr5fOIMe0DzZrs8bFzNxsHFbA=; b=hpym/bUONeSPedozwHvOuRRwO7YeZA7YLjTGQQibGfFbGSyjpVSbWi5GdzYA1w3N3r vl1OWz4gC0gXe7XyV2Dq0kbhlcfH6AjWtFmLVHlKlQxY8ldv90Ov+PSyacW9J5XS8EVG w9haY7jKgiaRRbjb1TbvbgpeFpyQ9X2DV4Pxe6ZA2b0P8+46C/39cw+fnRIc5FjBZx8Q QV5A9YBT+lEikvF8LwuqM2+lcKA/iQ0m5PAIyjxCfUNTH1VCC8HxiB4v+1yJXi7DfYqe UwLP6pZlnDGq+I+vR3s3Xb1qOd0tZ7yMKAs8q0k9NGTFENQGNLr1kBaZy69Xj7xUeUmR 3EBA== X-Gm-Message-State: AOJu0YwWEyohX6FB7Sq5jr2nrf3NXOR5qCkn73cqc2arMc5B3a9JMslD iC7T12ivbBxylWbIPIzu5ufQhRiF/x1AyRtbwzo1y6RWLWtI7OwtYZ9cy0FYTds= X-Google-Smtp-Source: AGHT+IE+GzEB5OEHpYgCyzNdv06jGAeDRATX2dvvxUly4wyZV7WD4A3O8kw/WjAsIdcrec8KVUbIOA== X-Received: by 2002:a17:903:1c2:b0:20b:51c2:d789 with SMTP id d9443c01a7336-20bfdfef83emr12499185ad.16.1727998685518; Thu, 03 Oct 2024 16:38:05 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20beef93c2csm13910345ad.138.2024.10.03.16.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 16:38:05 -0700 (PDT) Date: Thu, 3 Oct 2024 16:38:03 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@amd.com, thomas@monjalon.net, mb@smartsharesystems.com Subject: Re: [PATCH v3 19/26] app/dumpcap: use separate Rx and Tx queue limits Message-ID: <20241003163803.1a8b5801@hermes.local> In-Reply-To: <20240814104933.14062-20-bruce.richardson@intel.com> References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240814104933.14062-1-bruce.richardson@intel.com> <20240814104933.14062-20-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 14 Aug 2024 11:49:25 +0100 Bruce Richardson wrote: > Update app to use the new defines RTE_MAX_ETHPORT_TX_QUEUES and > RTE_MAX_ETHPORT_RX_QUEUES rather than the old define > RTE_MAX_QUEUES_PER_PORT. >=20 > Signed-off-by: Bruce Richardson > Acked-by: Morten Br=C3=B8rup > --- > app/dumpcap/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c > index 6feb8f5672..fbaaa4fe3f 100644 > --- a/app/dumpcap/main.c > +++ b/app/dumpcap/main.c > @@ -95,7 +95,7 @@ struct interface { > struct rte_bpf_prm *bpf_prm; > char name[RTE_ETH_NAME_MAX_LEN]; > =20 > - struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT]; > + struct rte_rxtx_callback *rx_cb[RTE_MAX_ETHPORT_RX_QUEUES]; > const char *ifname; > const char *ifdescr; > }; Looking closer, this field is defined and never used, it can go. That structure is used to gather the command line arguments before applying them.