From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D6FD45AA7; Fri, 4 Oct 2024 04:38:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F27E4402DD; Fri, 4 Oct 2024 04:38:57 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 8F179402C9 for ; Fri, 4 Oct 2024 04:38:56 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2e078d28fe9so1211884a91.2 for ; Thu, 03 Oct 2024 19:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728009536; x=1728614336; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CNZ2BEpFox/nm8+o2BsvG7TjoBv6rhkoJpz8lFy+fzU=; b=n6dhtSa7EFTP6NWgVsL3kZ6J4xKkDa12hZqvcnbgGmYyYUWSsmPK6P3lCu3uPggUGE A1asZaKmvmcM3Oiuof8j9kxMOQHm2uhlusp9D6Qjm03cms5hRvici39lj3qe6TUYUifq I1dThLGlz8BH5i0vm/JPCWvPTzOiFFYuVHk36Pp/TJX+M1+fozzx68PadQ8/xbvqkwQJ inuTucAoHVSgnP0qebF+pcwYrQnsHFs6QeY/7UM4kB+UvM0/pmqmB9k34vwZQWDRmsx+ WkEPRhWtyvrs6M+TD+Sp9GhGCx1O4RIwkQqSKzhmrV/xTnPBuV5AeAHze/mzbAkDy2/1 iy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728009536; x=1728614336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CNZ2BEpFox/nm8+o2BsvG7TjoBv6rhkoJpz8lFy+fzU=; b=PM89aQARlJkdqDybsxRvZZKOv/azmnoXCNNFofkU0zzQtQ871ptUPgrN+AFxQU2Uic U0pDDl6Nz4yb2tPFg0/41YGjf5nXTeYSOhSjEV8tUv5iA6wVDI0XKEg0EtvBQHHFFsoe wI7bjOLCAtIvWFgmk9TO8UpNi2/NJB+c2UKDU9Zsl3j67b5QFoDx11wd1GiACAgHfzUu MWLt7uZvcnRcMSdCxaByZzldeMExEglnhzfh9s4t4UJ+LZ1FXIf5piTzilE7ULVVoaTe Wq9h8E3fHzx45TTz9bcqDR3cIKF/cod/8z9t8mLDK+8ZLSf/Ox/ShNA8AALMSj/wWQY8 WPCg== X-Forwarded-Encrypted: i=1; AJvYcCVWB6XMzOW9+Oq4b7AAui3QSLZuPwRQbjcImuukzedG1QLFNLrk4CVEluAiRMu8r7HZ2Qg=@dpdk.org X-Gm-Message-State: AOJu0Yw0ZdiEzwYo8NcZK9HN0e67LRF74AB79v5KDAPlx8lYDfVfrDo5 R8IVgUt6uBDpBHOKp35pFMDOzLVu6ulZx8JwgzO2GrnY/H8wQQJKJAF7eZHc1+w= X-Google-Smtp-Source: AGHT+IH7BjXsSr4Ov0qgMuA2HdJhlWBz9VeQ02QAj4atM5of7rioXJfDfKYPXwk3AmnVZWHCLpuJIQ== X-Received: by 2002:a17:90a:de92:b0:2d3:d728:6ebb with SMTP id 98e67ed59e1d1-2e1e620eb4amr1605506a91.5.1728009535639; Thu, 03 Oct 2024 19:38:55 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e85e2d83sm296500a91.33.2024.10.03.19.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 19:38:55 -0700 (PDT) Date: Thu, 3 Oct 2024 19:38:53 -0700 From: Stephen Hemminger To: Conor Walsh Cc: ciara.power@intel.com, thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org, bruce.richardson@intel.com Subject: Re: [PATCH v2 2/2] usertools/telemetry: add new telemetry client Message-ID: <20241003193853.19863f3e@hermes.local> In-Reply-To: <20220831115250.362189-2-conor.walsh@intel.com> References: <20220824081539.12379-1-conor.walsh@intel.com> <20220831115250.362189-1-conor.walsh@intel.com> <20220831115250.362189-2-conor.walsh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 31 Aug 2022 12:52:50 +0100 Conor Walsh wrote: > A lot of DPDK apps do not provide feedback to their users while > running, but many interesting metrics are available through the > app's telemetry socket. Currently, the main way to view these > metrics is to query them using the dpdk-telemetry.py script. > This is useful to check a few values or to check a value once. > However, it is difficult to observe key values over time and it > can be difficult to correctly parse JSON in one=E2=80=99s head! >=20 > It is proposed to add a new Python tool to usertools that will > provide our users with a real-time, easy and visually appealing > way to view statistics without leaving their terminals. > The tool can provide various key statistics about any DPDK app > in real-time. Various real-time graphs are available (using plotext), > which makes visualizing the metrics easier. >=20 > The tool runs completely in terminal and is responsive to any > terminal size down to 80 characters. > The TUI is provided using the rich Python module. >=20 > The tool is already being used by some of Intel=E2=80=99s DPDK developers > internally and we feel that it could be useful for the wider > DPDK community. >=20 > A talk about this new tool will be presented at DPDK userspace. >=20 > Screenshot: https://cwalsh.tech/dpdk/tui3.png >=20 > Signed-off-by: Conor Walsh This looks cool and works for me. Guess no one uses telemetry much otherwise should have gotten accepted. There are some python style things could be cleaned up: $ flake8 --max-line-length=3D100 ./usertools/dpdk-telemetry-tui.py=20 ./usertools/dpdk-telemetry-tui.py:347:5: E125 continuation line with same i= ndent as next logical line ./usertools/dpdk-telemetry-tui.py:397:41: E203 whitespace before ':' ./usertools/dpdk-telemetry-tui.py:398:40: E203 whitespace before ':' ./usertools/dpdk-telemetry-tui.py:399:49: E203 whitespace before ':' ./usertools/dpdk-telemetry-tui.py:399:82: E203 whitespace before ':' ./usertools/dpdk-telemetry-tui.py:539:45: E203 whitespace before ':' ./usertools/dpdk-telemetry-tui.py:540:43: E203 whitespace before ':' ./usertools/dpdk-telemetry-tui.py:580:5: E125 continuation line with same i= ndent as next logical line ./usertools/dpdk-telemetry-tui.py:637:5: E303 too many blank lines (2) Acked-by: Stephen Hemminger