From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 00/10] require checking ethdev get return value
Date: Fri, 4 Oct 2024 09:21:47 -0700 [thread overview]
Message-ID: <20241004162418.52940-1-stephen@networkplumber.org> (raw)
Several places flagged by Coverity and Codeql are from code that
calls rte_eth_dev_info_get() but does not check the return value.
If rte_eth_dev_info_get() returns an error, the device info is garbage.
This patch series uses the function attribute to force code
to check the result or there will be a compiler warning.
The series is ordered to fix the current warnings first
before enabling it.
Stephen Hemminger (10):
app/test: remove redundant call
net/memif: check return value from rte_eth_dev_info_get
graph: check return value from rte_eth_dev_info_get
examples/ethtool: handle devices without registers
examples/l3fwd: check return value from ethdev info
examples/ntb: always check return value
examples/pipeline: check return value of ethdev functions
examples/qos_sched: check return value from rte_eth_link_get
ethdev: check return value from rte_eth_dev_info_get
ethdev: require checking results of info_get functions
app/graph/ethdev.c | 20 ++++++++++++----
app/test/test_link_bonding_rssconf.c | 1 -
drivers/net/memif/rte_eth_memif.c | 12 ++++++++--
examples/ethtool/lib/rte_ethtool.c | 6 ++---
examples/l3fwd-graph/main.c | 12 ++++++++--
examples/l3fwd/l3fwd_fib.c | 16 +++++++++----
examples/l3fwd/l3fwd_lpm.c | 14 ++++++++----
examples/ntb/ntb_fwd.c | 5 +++-
examples/pipeline/cli.c | 7 +++---
examples/qos_sched/init.c | 13 +++++++++--
lib/ethdev/rte_class_eth.c | 4 +++-
lib/ethdev/rte_ethdev.h | 34 +++++++++++++++++-----------
12 files changed, 103 insertions(+), 41 deletions(-)
--
2.45.2
next reply other threads:[~2024-10-04 16:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 16:21 Stephen Hemminger [this message]
2024-10-04 16:21 ` [PATCH 01/10] app/test: remove redundant call Stephen Hemminger
2024-10-04 16:21 ` [PATCH 02/10] net/memif: check return value from rte_eth_dev_info_get Stephen Hemminger
2024-10-08 3:47 ` Ferruh Yigit
2024-10-04 16:21 ` [PATCH 03/10] graph: " Stephen Hemminger
2024-10-04 16:21 ` [PATCH 04/10] examples/ethtool: handle devices without registers Stephen Hemminger
2024-10-04 16:21 ` [PATCH 05/10] examples/l3fwd: check return value from ethdev info Stephen Hemminger
2024-10-04 16:21 ` [PATCH 06/10] examples/ntb: always check return value Stephen Hemminger
2024-10-04 16:21 ` [PATCH 07/10] examples/pipeline: check return value of ethdev functions Stephen Hemminger
2024-10-04 16:21 ` [PATCH 08/10] examples/qos_sched: check return value from rte_eth_link_get Stephen Hemminger
2024-10-04 16:21 ` [PATCH 09/10] ethdev: check return value from rte_eth_dev_info_get Stephen Hemminger
2024-10-08 3:47 ` Ferruh Yigit
2024-10-04 16:21 ` [PATCH 10/10] ethdev: require checking results of info_get functions Stephen Hemminger
2024-10-08 3:47 ` Ferruh Yigit
2024-10-08 9:33 ` [PATCH 00/10] require checking ethdev get return value Morten Brørup
2024-11-11 15:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004162418.52940-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).