From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E2AF45AB2; Sat, 5 Oct 2024 03:10:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFDD4402E6; Sat, 5 Oct 2024 03:10:34 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id C3172400EF for ; Sat, 5 Oct 2024 03:10:32 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7db90a28cf6so2551641a12.0 for ; Fri, 04 Oct 2024 18:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728090631; x=1728695431; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FIirdxXXSlz8grHdVkmVPKIStsQk5OTZK07wplDmCA0=; b=xU4ljr//X12s2AIqJYaFHbDqd44r21gMuSLKm4W3HgOWOxBiqhysS9gcmGkMSU3vaT evGsUVXDFKkAv20SwC0q50i5blrd5ibpLWgPRQ7JGyX8ebAKnp2QwHFrsTx7mDnhVjhA 3fUrmS5HNsX4lyBGhF5sawofBzQck6QevYNfLThEaZZiV50si0lEOOh46Vmesqb/4zkT J/gHj/HlsGqXS0vYYSxfhFx5+37ki8NexUtzg/QelMfePSF8fqULCiNhOl0yinb5t1uw to6Iqwg7f2QMzcr98nGNJ9xkQ3IuFdcYVDfJQqDt/0tSbpzs3uxa4rX4IC7caV6vWqBM dh+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728090631; x=1728695431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FIirdxXXSlz8grHdVkmVPKIStsQk5OTZK07wplDmCA0=; b=QluIbR+I3kC7TRP7b3sop6bXNvBodexVGGrNb5n55iv+auemoamVxfUTaYG3XFMC9R x8tq8gd0dYIsMDs9irxCxKHQ8Ax3KYVr8NftNXODAJvgkNWZQKsKxURR6CjdifcT6ffI rKZgUcyXgpFtbfwcL863xGwaQEveSpQRNVXRr8x1nl2FVHJ04Qgph3zBbe9zqFf4fTaV pkyz5D4uXl4t8oFk5wlrCTo4qJqs5t5iSMfZhV0wu1rp/nX2dBjfM+j2+DOtrRiZnRlr 01ykgx25NGT0yRfLOFSt9Cp7jtT1evVdRZJNjL0g9ezLpWrLvMm5oMJxQZjaPGz86GbA yPcg== X-Forwarded-Encrypted: i=1; AJvYcCW5ClmARn9StbvoPNT0i8x4muDE3Ie6G7XQR+K+aAATvqH6uV7hij1ilTnjf3sT0RfaKY0=@dpdk.org X-Gm-Message-State: AOJu0YzvPoq19gASOios4n0hn1byOY4MxdjuuWTBGqBRS9h3OCr8iUi5 8GrJSVaVyqBmYUWI2UDdAIKWkLx3T70oCghNerSTijCcDa1E7k0896ZojHWlWak= X-Google-Smtp-Source: AGHT+IGCLrP1bEda5NAMsnyOJM0+TCn5buOTXffBoiODx15E8IfHIWECgU9IJwM8jRjRl7AuwYLkqA== X-Received: by 2002:a05:6a20:748f:b0:1c6:b0cc:c44b with SMTP id adf61e73a8af0-1d6d3adae7emr12847424637.19.1728090631586; Fri, 04 Oct 2024 18:10:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f681f0cfsm637735a12.27.2024.10.04.18.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 18:10:31 -0700 (PDT) Date: Fri, 4 Oct 2024 18:10:29 -0700 From: Stephen Hemminger To: Oleksandr Nahnybida Cc: reshma.pattan@intel.com, dev@dpdk.org Subject: Re: [PATCH 1/2] pcapng: fix handling of chained mbufs Message-ID: <20241004181029.6de8f06d@hermes.local> In-Reply-To: <7yrjcy7sk4nexcqynikybhjvpxlhhmlwvubngwqvib5o752sys@644loude6vbd> References: <7yrjcy7sk4nexcqynikybhjvpxlhhmlwvubngwqvib5o752sys@644loude6vbd> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 13 Sep 2024 15:19:18 +0300 Oleksandr Nahnybida wrote: > The pcapng generates corrupted files when dealing with chained mbufs. > This issue arises because in rte_pcapng_copy the length of the EPB block > is incorrectly calculated using the data_len of the first mbuf instead > of the pkt_len, despite that rte_pcapng_write_packets correctly writing > the mbuf chain to disk. > > This fix ensures that the block length is calculated based on the pkt_len, > aligning it with the actual data written to disk. > > Signed-off-by: Oleksandr Nahnybida Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files") Reviewed-by: Stephen Hemminger