From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBA6945AB2; Sat, 5 Oct 2024 03:32:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 923E7402E6; Sat, 5 Oct 2024 03:32:02 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 1141D400EF for ; Sat, 5 Oct 2024 03:32:01 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71b0d9535c0so1966516b3a.2 for ; Fri, 04 Oct 2024 18:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728091920; x=1728696720; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=60PrmqLCjt7LoD2ao56Al7nzt/nlo8kMo+EJrzLQ8DE=; b=PFSQt+SD9UiMMKMR4FfHZIEcCunXeuurt4l9Rh0DLaWWeGS8HMkTxiKIeBk0oYhAK6 G4/WNHcDa4rmcgMI1RHPGIEPBpPmegqB9Ea+JC1WSSNrBVJGAWpYFQRSMVJ/s/YZB65x FJ1hoiKm8h7ZUIruaeuBLURCrC3bI6K+rHU8nwSKYJuu0stPM7yx/xOFP8vE/I59i+vV s0z/RvX4f7WKHYY2bxNQIseLbgLCRqWoCWUPScMsH7PFHqH/EBPbSNLQH5+BEQOUDhKJ 6ZmFK2ZU+48S9riD5a89SDn5Lh0fMHr3r1C+22PJ8LbeBqXvMV5C2WBv1FXKPc3EAGBC lNFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728091920; x=1728696720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=60PrmqLCjt7LoD2ao56Al7nzt/nlo8kMo+EJrzLQ8DE=; b=IBMOldZle93yu4m7JZeVWea4v2H6clHpwGZ3xp1zqAJlRRuaDuvfhjcCZkAZm+h0cw rCrYIYmKE6HL6awA5QMZtkGW4Wt9mivi8vftwr5YiP2D9PD9+ajRX4Z9RNBgr0F3hcu0 ctrsqT7KcWoi+fSm4IO+1EiGqO4GSc0BjBj7b0aAgBEVZ9XDF0rirf37Xk09+4r19TnN kmf7hEzL892mDLeg4tGELuZ/HuF44UoDEhyPNAmdbf94JsUgtXKwO64eEXgxj19Kevrp PglyOI7glk3MEWL+tarhkFsFtkh7wzyZOizw1dZuYI/8eeKb86AGU8K75VB7mDIc66wd 2+8g== X-Forwarded-Encrypted: i=1; AJvYcCXr44oeZPvqeKxUyRnKMBVGuJYNYQ3XulPOWPkNroY1FI0gP4P764HGVEUtTcpfSukdKvQ=@dpdk.org X-Gm-Message-State: AOJu0YwAdmZBLZP7COeFAOd4A2xuk2tMC/R5Ho92ZBPAIrhnoCXbeYqq LBLr66xIyPV3BVxILckuFw8mTH0Fol4aSbJGC6UcfKLxwt7G1fZ+rYGzxTicAOM= X-Google-Smtp-Source: AGHT+IGbkLYkrj3OImmSN7LR6YjKHaNj88aTTgl/6SxJphI9+6t9CnJXXMvpSID0LZZqUIXi5d6rbA== X-Received: by 2002:a05:6a20:d521:b0:1d2:e8f6:fd4 with SMTP id adf61e73a8af0-1d6dfa476b7mr6631907637.27.1728091920209; Fri, 04 Oct 2024 18:32:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0ccd225sm521751b3a.52.2024.10.04.18.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 18:32:00 -0700 (PDT) Date: Fri, 4 Oct 2024 18:31:58 -0700 From: Stephen Hemminger To: Daniel Gregory Cc: Stanislaw Kardach , Bruce Richardson , Tyler Retzlaff , dev@dpdk.org, Liang Ma , Punit Agrawal Subject: Re: [PATCH 2/2] eal/riscv: add support for zicbop extension Message-ID: <20241004183158.577db34c@hermes.local> In-Reply-To: <20240530171948.19763-3-daniel.gregory@bytedance.com> References: <20240530171948.19763-1-daniel.gregory@bytedance.com> <20240530171948.19763-3-daniel.gregory@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 30 May 2024 18:19:48 +0100 Daniel Gregory wrote: > This new functionality is controlled by a Meson flag that is disabled by > default. Whilst it's a hint, like rte_pause(), and so has no effect if > the target doesn't support the extension, it requires the address > prefetched to be loaded into a0, which may be costly. Please just use #ifdef's against compiler version string like other code does. Introducing a meson flag means user has to do something. Better to have "it works right the first time".