From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DBA845ABD; Sat, 5 Oct 2024 17:49:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63D5E402DF; Sat, 5 Oct 2024 17:49:42 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id B0101402C8 for ; Sat, 5 Oct 2024 17:49:40 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e07d91f78aso2325177a91.1 for ; Sat, 05 Oct 2024 08:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728143380; x=1728748180; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4ZG9BsRsXA5DirHPJUzj7UFcIffHHcQ6AA6z1E5ABJc=; b=wJqU8qDt/tuobj79Un8jlleFH1By2GZhrH9J0MleAMGfz3l83m1jwLpJJIUWqvUvYs TKtwqCckaQhQF/kP7e/IYnuDECMA3dhtpjziiUbj1u7gfhCshiuQLUhKywN5ICqRAlYQ W+SWGAZSvOwGzgfo+avcJ6vVx5Yo+y79nuB3t7fH3DLGjmZ0GJyY1iR37aTwM3yXJkKZ MpCvTAlaYbfG3IDKKPrWKanuWGcmC6RNtAcfiXPkf+pEeG+hKw0cWhrM605birC5WEky juzLQo9f5MyJR7rPSn7QiNMMFbDFqRA018jbOJ0CzJJroat08JlHPC0tKpDjaqN8yaIS v0+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728143380; x=1728748180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ZG9BsRsXA5DirHPJUzj7UFcIffHHcQ6AA6z1E5ABJc=; b=IAKx+7167NbuYSOab/wlagENlMJbSnUa2KHgKnuBmIyVSyc2sheXDRurtsp7kiGy4e LcKqYClVg7f+zkC6BcuTap1wUVCaWxCso6Hn4bQ9DV+kR/vDJzFsfgMi4/0Q0w41zxnk 5D7HMz1vBByLHNVaGVerdUF3JX6vqVNhPkew7SvC61H/8M+pMEGGHx8GDU7f7s1BIbYV ovzn3veiWqLcnvdfQBZw/YGIM+bDWfZfvrK1MvOmkRJJMriYuQAVj2RSmp50G1luuJ0K xF6NbFlAxTXN/8LJZLIzmXVXzNbQoifab/r4X4flmCxL/xpsseyKE5HkWoAkHfaColoX wWBA== X-Forwarded-Encrypted: i=1; AJvYcCV473fbJazykdQ8TybGMxM8+6jjY5vwrDbwF8tQOLRBqSUrbbcys96yadkfXciPTY3Z72c=@dpdk.org X-Gm-Message-State: AOJu0YwhQCd04I/+oHRFNzXGF+Fs8EKA8xgZpb0OYW4ZbuF1ZQiVWE3z dqAMZJsO+Sy0UdSa1YrPiESdT4N2fwAnO9lmSRNTbeRwif/9uA9TZuKjxNUqAFY= X-Google-Smtp-Source: AGHT+IGYSK+kqPVhYPlJcDYQ26XacHTy/Eg9CmTcaT/CX7e1oyrUtgqMkUFPG358OcejYvbKuJK69Q== X-Received: by 2002:a17:90b:224e:b0:2e0:8719:5f00 with SMTP id 98e67ed59e1d1-2e1e62a93f6mr7377371a91.22.1728143379783; Sat, 05 Oct 2024 08:49:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e85c8fd1sm3729083a91.18.2024.10.05.08.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2024 08:49:39 -0700 (PDT) Date: Sat, 5 Oct 2024 08:49:36 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , Subject: Re: [PATCH 0/7] refactor kvargs test Message-ID: <20241005084936.4ead7420@hermes.local> In-Reply-To: <20231103095325.47843-1-fengchengwen@huawei.com> References: <20231103095325.47843-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 3 Nov 2023 09:53:18 +0000 Chengwen Feng wrote: > When developing patchset [1], I found the kvargs test is hard to > understand when tried to add some testcase. > > So refactor kvargs by: > 1. introduce UT suite framework. > 2. extract big test_valid_kvargs() to five part. > > And add myself for voluntary maintenance of the kvargs library. > > Note: to ensure patch independenct, new API which in patchset [1] > are not included in this patchset. > > [1] https://patchwork.dpdk.org/project/dpdk/cover/20231103073811.13196-1-fengchengwen@huawei.com/ > > Chengwen Feng (7): > app/test: introduce UT suite framework for kvargs > app/test: extract basic token count testcase for kvargs > app/test: extract without keys testcase for kvargs > app/test: extract with keys testcase for kvargs > app/test: extract parse list value testcase for kvargs > app/test: extract parse empty elements testcase for kvargs > maintainers: update for kvargs library > > MAINTAINERS | 1 + > app/test/test_kvargs.c | 256 ++++++++++++++++++++--------------------- > 2 files changed, 128 insertions(+), 129 deletions(-) > Looks good and still applies clean Series-Acked-by: Stephen Hemminger