From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C91845ACF; Mon, 7 Oct 2024 03:14:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C69AD40A67; Mon, 7 Oct 2024 03:14:45 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id C4ACB40684 for ; Mon, 7 Oct 2024 03:14:44 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-71e05198d1dso149751b3a.1 for ; Sun, 06 Oct 2024 18:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728263684; x=1728868484; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+3OmxlNAvaGtLhMkjV8Zd7ymRKNNfm0oEG5yBFC8b2Q=; b=z2PF9DfZ/mo9UJrpJ2Pe16kZwvNkfOawFcK1mkYbkmNtcukyM5HOzy5xe8d47/4vn4 C19S86B3n7/y1itJ4AUyHK9y9+K59Z07LLF/daM4RJk6qUlji3GJlzTGugb6Oa/WvzSa lSCi+qyzkmMVHssNT3PI4OeJAwr57UA1aFecyFnchXCD7n3gUqqjIThxMGRjIRQRutFt gkGZMnL5yEHeOutEXUgETLkfXUKID02JKJJaDTv6Yn+YZLcYlHYkJlJEmoMuAeBk7J2X D6iUikFbg35tRyDMxyHDl8e9Z/+yE+l7j4/PeiWmedFZHecWv2VoBnLHZs8SS0yelavp x2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728263684; x=1728868484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+3OmxlNAvaGtLhMkjV8Zd7ymRKNNfm0oEG5yBFC8b2Q=; b=Mf1xXgBuB9FBE7TbAOIPaVaEZ62cu/jbuS7NsXYAU5hnnRKNA67RcYOG4jfWH1vU5M ZRPDYn6WYRzzMQDRgZOhaVXv0rdBMj2mODBZDL7eqCbhMLLhBbDR2ko9ahAdVTV2RqGA RiBMM+quui8xAQnEpiIb+kmDwOzu9tbqGJbn4cdGlXly1S5/gYD9/p/7rdVUDtLn6D7p 1ZJ+ZJ2L7e2I9XgbxlMABw+osHSa2asNZp3ty9KhW/mT/FVCurpKCpDWmKu7yq7EUpLy ro/Em/AAmh87XGhxsGz6Ix1AZKar5NBNuwjWfU7gbRhgX/K95F8eT0FcjPLkvRP3YRah YXWQ== X-Gm-Message-State: AOJu0Yw1MFo8EIj/zDb5SB2AUvXIkC55F8rpjn58xggB33WTnnKibr0b jpK4ADJqOk3g2UGC5iOqkX4r6UjUpRo7QjrHOj0dvcAGpUgPGwuhuzpD4OR8rmk= X-Google-Smtp-Source: AGHT+IFYFyO01CJ3+AU8BEmG3XuzimuABpArkwhf8BIRKVnqS/M2nVsIUcQ2UMbzFmZivjBpO1MDog== X-Received: by 2002:a05:6a20:d521:b0:1d2:e94d:6e6d with SMTP id adf61e73a8af0-1d6dfae3103mr16222533637.45.1728263683823; Sun, 06 Oct 2024 18:14:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0cbc495sm3321173b3a.24.2024.10.06.18.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 18:14:43 -0700 (PDT) Date: Sun, 6 Oct 2024 18:14:41 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Akhil Goyal , Aman Singh , Anatoly Burakov , Bruce Richardson , Byron Marohn , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Jerin Jacob , Jingjing Wu , Kirill Rybalchenko , Konstantin Ananyev , Matan Azrad , Ori Kam , Radu Nicolau , Ruifeng Wang , Sameh Gobriel , Sivaprasad Tummala , Suanming Mou , Sunil Kumar Kori , Vamsi Attunuru , Viacheslav Ovsiienko , Vladimir Medvedkin , Yipeng Wang , Yuying Zhang Subject: Re: [PATCH 03/15] net: pack structures when building with MSVC Message-ID: <20241006181441.6850299a@hermes.local> In-Reply-To: <1710968771-16435-4-git-send-email-roretzla@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1710968771-16435-4-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 20 Mar 2024 14:05:59 -0700 Tyler Retzlaff wrote: > Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing > when building with MSVC. > > Signed-off-by: Tyler Retzlaff > --- > lib/net/rte_arp.h | 2 ++ > lib/net/rte_dtls.h | 1 + > lib/net/rte_esp.h | 2 ++ > lib/net/rte_ether.h | 1 + > lib/net/rte_geneve.h | 1 + > lib/net/rte_gre.h | 4 ++++ > lib/net/rte_gtp.h | 5 +++++ > lib/net/rte_ib.h | 1 + > lib/net/rte_icmp.h | 3 +++ > lib/net/rte_ip.h | 4 ++++ > lib/net/rte_l2tpv2.h | 4 ++++ > lib/net/rte_macsec.h | 2 ++ > lib/net/rte_mpls.h | 1 + > lib/net/rte_pdcp_hdr.h | 4 ++++ > lib/net/rte_ppp.h | 1 + > lib/net/rte_sctp.h | 1 + > lib/net/rte_tcp.h | 1 + > lib/net/rte_tls.h | 1 + > lib/net/rte_udp.h | 1 + > lib/net/rte_vxlan.h | 2 ++ This no longer applies, need to rebase this series. Address the comments from Bruce in previous patch as well.