From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A47745ACC; Sun, 6 Oct 2024 22:37:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5500E4066C; Sun, 6 Oct 2024 22:37:42 +0200 (CEST) Received: from egress-ip11b.ess.de.barracuda.com (egress-ip11b.ess.de.barracuda.com [18.185.115.215]) by mails.dpdk.org (Postfix) with ESMTP id EC4B240654 for ; Sun, 6 Oct 2024 22:37:38 +0200 (CEST) Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03lp2112.outbound.protection.outlook.com [104.47.30.112]) by mx-outbound22-159.eu-central-1b.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 06 Oct 2024 20:37:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gAuPKlkx84BQJRr3EgspFGhV0gVMm1wom08SKxfVmb55M78TI1Cmhlyw42mbVIu2Vs7oTqIzlR4iJvk1v4en+Qo3uQzngeNtUPY9FiP+BaMMOj7FOY0MXrzFk7ZxEezwLrqFkn68dDb7BcjtpPqIw1KseAlYGtkGkmMt0KY/NzUdi/mXx/dRS9sy/YQNdVLSFOScJtXKFCP9b+FpNZey2rAtRux8k3cvZfoq6UuhdVrNSVkE7c7C9aayHpkyAJGrzictPxxjt7vTG7+iG2kfzJc0FpGn1w1SZLoVRpQUD5EkYgKz2KGZkZ2NTJplNXCK37VfIP8W8FNnwYhWaFg9LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=76Z5PdSX5ahAcGWPUhzBAP2hMQNbeRKcAltgsSf2l7w=; b=N/wBY5w2haveWaNOom11zqBj1+moNAcPgTSFWFknOrTnh/EesWs6LA5NBYUerDsABF1FMQab3PwaFxJaTJSHMyGx6BvTURBOtOnGYfzRGuBqbDks0N558asja/AV/742uvtxlhXgKYYdZEHDd0oo9rVIxBumWLfYni1m0rxPZWdUxX5zqIGGBxWH0ymKUNoKXebfKyYNKv2GD42XOkErfVFiyAHfnhEBmcDhIXEj0oBdaiG3cyjFpaEM+vlghsm2bAuURFSI93UPj1HrD0Ew1xTTyr+k06344eqeuSfnuj5JQ/nS8qE/+hnttjMqJoI9QjP9ekASSxZ8GDqyGkQGYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76Z5PdSX5ahAcGWPUhzBAP2hMQNbeRKcAltgsSf2l7w=; b=DY0g/ymxDZ7BENlw22RGlSc0zMxNtYh0VfyLjnZF7kVw/pVoOD8XnPi0AsDhWVpQBVq7xgmodHRrASXp9x6XHS/V4JAIAq5E5XqLUIpO77inB5kXunSmhZCDwRB3aiLAJnCNiiFOvCij5sK1sMg2TSb8TlrShk3B5bLBT637YOA= Received: from AM6PR04CA0012.eurprd04.prod.outlook.com (2603:10a6:20b:92::25) by AM7P190MB0790.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:113::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Sun, 6 Oct 2024 20:37:35 +0000 Received: from AMS0EPF00000190.eurprd05.prod.outlook.com (2603:10a6:20b:92:cafe::ce) by AM6PR04CA0012.outlook.office365.com (2603:10a6:20b:92::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.20 via Frontend Transport; Sun, 6 Oct 2024 20:37:35 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by AMS0EPF00000190.mail.protection.outlook.com (10.167.16.213) with Microsoft SMTP Server id 15.20.7918.13 via Frontend Transport; Sun, 6 Oct 2024 20:37:35 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, Oleksandr Kolomeiets Subject: [PATCH v1 04/50] net/ntnic: remove extra calling of the API for release port Date: Sun, 6 Oct 2024 22:36:31 +0200 Message-ID: <20241006203728.330792-5-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20241006203728.330792-1-sil-plv@napatech.com> References: <20241006203728.330792-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF00000190:EE_|AM7P190MB0790:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 25404057-da56-47d6-de88-08dce646b5d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yNbDMukcuyljmxZSbUv1BNsrDXusGys/apnPUEAFUMJoFzq6jS0K0DuoMg8q?= =?us-ascii?Q?sB4aZj4XOsRtb3LqQ4QGDf1ZFxHLz8eVNlqYKnDbBl8JjZUL8bzCEVKMAwNE?= =?us-ascii?Q?Enpf4FIGvh7OcFBxZsFTJTcyLOuB8hX3EgJPuZv6hgvu1hlifuY37W5gu9IH?= =?us-ascii?Q?4x9fmVhi9CuAB2uIPmDdj8q59YMnSmNAkTV7cZudcYa9Y5n6ekAYqIJJ7Ep4?= =?us-ascii?Q?V4xEcKSPXQJTVbZTlSSjg5sNjsZCU4hdkR5dqnJBmkYD0IRCigRg6+YLV06x?= =?us-ascii?Q?CAyaNcK79nmFeOzX7oxxQc7eUBxrdSOWEWB60LqbyJEcjSpLpq6OAY2vYHgg?= =?us-ascii?Q?6eleibsdlXo4Tw0cmoXM7+jsEnO8lzzB5yD6rE7cBGVi/4Xd3YPSer/mda6V?= =?us-ascii?Q?7Lz5WChIaIO0A6X3xqGl8LuxDXjE1et54TNQYds5+nFHXE+Cxa++tAZrl+bK?= =?us-ascii?Q?y1f8HSWZZ5wByxANQZPIOg5QVO27xRozS7ro4H4sOSJvYwrJpBdZbzDrwVPN?= =?us-ascii?Q?E3ViL7jtE7Vugd3cXveh5HhFWcCiCvaGE+JhgCzfB6qHeHRhZ9NfoQO+GMRL?= =?us-ascii?Q?KLPEG28h0Qwctt3fwYrK1v9/wbVrIllrMbUnV0u9UguwnhkdzzrjIn+GdPyr?= =?us-ascii?Q?JFOunTKztokk3zARAMNzJn9Yx9fFVjVJsTJK+IE1ostnx1QNUSb2XwEd45WA?= =?us-ascii?Q?k72u1PB9srZyj37Av+2HcpSGVe07iSVdDSXoq5aX+l+0xYtPiyqzje7IE7Xl?= =?us-ascii?Q?JsYM39HBozWSuwn39ue8mVQfQiOzu1IuIbGLdO53flinPHD5Mruj2Zh/hb/3?= =?us-ascii?Q?dA6JzEjANQYFxCTgg9nlir608KP019K6QUtR/6Xpiywn9hDRAQpg6pPSrK8D?= =?us-ascii?Q?CerMygF8MrAeQ4AozttsEsZ2LPvJFvi0XFUxusdKQIB6pta+vIkE4ClJ/I6U?= =?us-ascii?Q?821vI3fzW9SJqiHXgna21pb7vEVGoDtO5tXeecrlxE476SrLRqiiuYSvTGVF?= =?us-ascii?Q?ZiLfFqAi/Cuyhiqdj39OvKu4lsPyDylx/tXcwYkWsMkWl22LpCsrqSfNpXJY?= =?us-ascii?Q?eXngATaWzRyUCVnAjcUY8m4d7i1GoODWb76FOxErj8NIN41PnVy5GXpbRbQ1?= =?us-ascii?Q?3N0c/QmvoGqJDluhy8cSiSR9t05ps4lD4v6UL6NKDTwT9/luIXS1CerzEffs?= =?us-ascii?Q?JFUyS6yuDJwdEPBC2u/j5FU4+/x7CTW2TY+g99WQ6EMH6Ey1xWl+NQBeyrO4?= =?us-ascii?Q?ZbV5oOi2iVgpkdD/syeOPfK9uwKUR+HWVxqivOeO/vmhFCxUtjRhR3TXdEjB?= =?us-ascii?Q?l7oqJg8O/PYFSKU2B+ZQm87ESsBmAlz7JcrPk70Exm3ciwmyel8wxYOn0HUk?= =?us-ascii?Q?KZDCV8A=3D?= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1Se8+bxMgG3lgjAmna+oTnuZuZsH6k+bWNT4JTAxC5ML7/GFuD2nopcJH2NbkHGsapAcfd5KQN7cRb7OaBj7+s9t0w5COrdSrGt9kaQNxBOQdlXlfxKbAOvEMJPZ81GyDJW1Ljr40DOOSyXfzqT8IkVqjHz8fUTLAaxO67Uw4ujG2I2I+pU10Ejgy+xwh+PGX8OwLYmaCNYF+1HqV4e7Ee9E9NYkYjejEREN24qDykEM8brXZt+c9s6S+HQRQiIiih/mAXtzwOLf4qyYOE3rYqimCmkz/5qg8PCNPOKlyrWhVFOAEdSqd6gNixtpsZa74INyndzuwz3OwxQ9DwYnPQzNynxQyp9o2cNZV4lczrSa6NDuw1NBIJUe+T5dF+GplNFFngrmcA9lRPSJ7/8lIwsDkHjuYoR1NdHhREW3A4xu3ThiNSDad2kCRCvmV8PNmwy4WhF4RYOCWqQDjCBNpgoMTohdqK7By6y8PEj2MO9I6CDRuGxu9gscYKbChl0bqNbDKnlJqDzaHbVCJMyi0rFgd/TsYz1QsijWmw6DtLWXIoTFljyu4HSYOaSQWdyMAowxQr2+6bT942o5T2c4uixJEfv40BnwSbFsBHzS5uohWxpYJVsdTW6hb1WpXFRpRapaoeDeYoL7pcl/lidE+g== X-OriginatorOrg: napatech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2024 20:37:35.0462 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25404057-da56-47d6-de88-08dce646b5d4 X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000190.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7P190MB0790 X-BESS-ID: 1728247056-305791-12646-147788-2 X-BESS-VER: 2019.1_20240924.1654 X-BESS-Apparent-Source-IP: 104.47.30.112 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVhaWJkBGBlAs1TzV0MLUONE8xc Qy2SzVMDk1zSTVwMjAwtTcxMLMMFWpNhYAwxXAvUAAAAA= X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.259547 [from cloudscan18-201.eu-central-1b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-prone. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/ntnic_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c index f351469d0a..52ca8f2844 100644 --- a/drivers/net/ntnic/ntnic_ethdev.c +++ b/drivers/net/ntnic/ntnic_ethdev.c @@ -383,7 +383,6 @@ eth_dev_close(struct rte_eth_dev *eth_dev) internals->p_drv = NULL; - rte_eth_dev_release_port(eth_dev); if (p_drv) { /* decrease initialized ethernet devices */ p_drv->n_eth_dev_init_count--; -- 2.45.0