From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH 3/3] ethdev: import and export data variables for MSVC
Date: Mon, 7 Oct 2024 10:05:40 -0700 [thread overview]
Message-ID: <20241007100540.3b9495ce@hermes.local> (raw)
In-Reply-To: <1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com>
On Tue, 12 Mar 2024 00:51:48 -0700
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> diff --git a/lib/ethdev/rte_ethdev_export.h b/lib/ethdev/rte_ethdev_export.h
> new file mode 100644
> index 0000000..7887bee
> --- /dev/null
> +++ b/lib/ethdev/rte_ethdev_export.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2024 Microsoft Corporation
> + */
> +
> +#ifndef _RTE_ETHDEV_EXPORT_H_
> +#define _RTE_ETHDEV_EXPORT_H_
> +
> +/**
> + * @file
> + *
> + * Import / Export macros for ethdev data variables.
> + */
> +
> +#include <rte_common.h>
> +
> +#ifndef __rte_ethdev_export
> +#define __rte_ethdev_export __rte_declare_import
> +#else
> +#undef __rte_ethdev_export
> +#define __rte_ethdev_export __rte_declare_export
> +#endif
> +
> +#endif
Why not put this in rte_ethdev_core.h rather than a new file??
Patch needs to be resubmitted anyway because it fails github build
from missing C++ guards.
prev parent reply other threads:[~2024-10-07 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 7:51 [PATCH 0/3] RFC fix import/export MSVC data variables Tyler Retzlaff
2024-03-12 7:51 ` [PATCH 1/3] buildtools: ignore exports for MSVC Tyler Retzlaff
2024-03-12 7:51 ` [PATCH 2/3] eal: import and export data variables " Tyler Retzlaff
2024-03-12 7:51 ` [PATCH 3/3] ethdev: " Tyler Retzlaff
2024-10-07 17:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007100540.3b9495ce@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).