From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5408545AD8; Mon, 7 Oct 2024 19:05:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ED5A4026C; Mon, 7 Oct 2024 19:05:45 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 8B1C64003C for ; Mon, 7 Oct 2024 19:05:43 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71e10ae746aso28339b3a.2 for ; Mon, 07 Oct 2024 10:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728320743; x=1728925543; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MKj7d2JjsbPKF1geJTPe0de5DH9igGAjgAvwiyMj5gs=; b=Caf4V0wvnwAZLxk1NXD2YxtWPj+m45cdvpXjBwkHtovctvGGnE+jOAB3zJ23toVPTW KQA5Q3cRzH+6NuXq3eeaUAhhvSJqiK6KYBoijE060NP2tDhKYC4FfoiH1gI01uOMU0ty rSfIpRLD7EHg5lSp5SBTAILuFy+CWRhlBBOYEViC2UEj4anGI7mn9LulwrYshHBvXckY OUiSCSxMamC5Vme3vMdHrHOD5CmHktOOZQmpSbodevi8z7kROeogDTwV3an7UwIvwZiv JNNKh6ad/rPVwv/tKmpZEex6Lb02U2xrFtsFvFIPbW8NZoi93ZGuWYXHZE5qsVUUmWLo Hp2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728320743; x=1728925543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MKj7d2JjsbPKF1geJTPe0de5DH9igGAjgAvwiyMj5gs=; b=f1O4zxfx/Xlqu2snfUhpLGQiSmZ9Blk6LdDMk6+ErYw85prNJyrdCWMFqWr966lZLZ YsS1v9uJnDmaEQVFc7Ly9wJRlFJ+mzD8JasRIIGTObgttuX7r3vBCg+VGod/sL9OKOM/ 4jY8haGp1bis6eEDh6rIzqmjANNc7+ztNk4ij9CWyHSDhm/bgUdw0QGzYNkd6hpmUnXN tmQlPIJDqEsQe2QK7kSORBXQXTVU39EJ1YE2hL9ZRu+WwE4+b9lFaZk3/rYo7dyWqCvu 1cqPQdKPuXe97p6I39U1sJus8gFyhuzW5Y0K2UJjI8jyuKfWoY708ITMOmFx12ywyYYy NHsQ== X-Gm-Message-State: AOJu0YzURT+RxwhV8ig4eZNSe1x2IvOW7d59phgX8Hcj5sb2iyf6QDd6 xdawjrW6lcxCy+5NNKGFkLIgYht5EN3DpyYiIxW2kL8Cgql4XD2GH01OfaSso2I= X-Google-Smtp-Source: AGHT+IH8SyugQp1kzvoc1CoiZTsfrODoi5Rd8SyFQUWTZCNqzrmHzmqxe8OPdFhf7dgJ2L6xuYI0zg== X-Received: by 2002:a05:6a20:d491:b0:1cf:9a86:6cb7 with SMTP id adf61e73a8af0-1d6dfa40eaamr18627004637.20.1728320742753; Mon, 07 Oct 2024 10:05:42 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71dfd0724c9sm3085148b3a.0.2024.10.07.10.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 10:05:42 -0700 (PDT) Date: Mon, 7 Oct 2024 10:05:40 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Dmitry Kozlyuk , Thomas Monjalon , Bruce Richardson , David Marchand Subject: Re: [PATCH 3/3] ethdev: import and export data variables for MSVC Message-ID: <20241007100540.3b9495ce@hermes.local> In-Reply-To: <1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com> References: <1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com> <1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 12 Mar 2024 00:51:48 -0700 Tyler Retzlaff wrote: > diff --git a/lib/ethdev/rte_ethdev_export.h b/lib/ethdev/rte_ethdev_export.h > new file mode 100644 > index 0000000..7887bee > --- /dev/null > +++ b/lib/ethdev/rte_ethdev_export.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2024 Microsoft Corporation > + */ > + > +#ifndef _RTE_ETHDEV_EXPORT_H_ > +#define _RTE_ETHDEV_EXPORT_H_ > + > +/** > + * @file > + * > + * Import / Export macros for ethdev data variables. > + */ > + > +#include > + > +#ifndef __rte_ethdev_export > +#define __rte_ethdev_export __rte_declare_import > +#else > +#undef __rte_ethdev_export > +#define __rte_ethdev_export __rte_declare_export > +#endif > + > +#endif Why not put this in rte_ethdev_core.h rather than a new file?? Patch needs to be resubmitted anyway because it fails github build from missing C++ guards.