From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EB4745AD8; Mon, 7 Oct 2024 19:15:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64ABD42D7D; Mon, 7 Oct 2024 19:15:51 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 849F44026C for ; Mon, 7 Oct 2024 19:15:50 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-71df67c6881so1867318b3a.3 for ; Mon, 07 Oct 2024 10:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728321349; x=1728926149; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3Oh3p9HjiBeJpuqAgQQLirlUIq38nMxtInjIkBl7yR4=; b=B+GKytxDbV96mZMY7PfPtI9U0BZvilGIDVyjr2r42k1R1WzaCLySqfDs1wjWsZ08p7 I6NW1rrJM7ACn9BzQKNCXYgM6NH//a1Dr4oXaJcjXu8m8qTAaZb2DfebgeDP1xfDPILX uexpALaRSxVE79LX6oZhuQgZmI+cmee3d+trZeTu9NEFQYEaoljkuVE04gAKKTkGIWLq kswPurwyW0DANdLqK4YoB5hbPXDuRhN0qUAExZLg1+cvqAP7jL8yeYbb3DXVONZsJn+E OrJC6gz69qlg3P8WSh9+C6TeWp4W8mh4AnkS5M8cJZbzik1MkBOlviySkGDE9u/N49aW anrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728321349; x=1728926149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Oh3p9HjiBeJpuqAgQQLirlUIq38nMxtInjIkBl7yR4=; b=p/Si+bEpSeGyvLH0iWPKojZCEZZCcqkT+Wld7bLkU34cxrPnUNfYTadP9TJEhfal6j v58m9ODasAfH/PeeHfEmJsfroBc/xmzKs3c8NhqRy4aeC29Z3v2y3kEd/ZCq9vrKmfVd r86NyhJyP7+osWEOBV4XSAh0e3NhncNCigtrk7OGpm1AD38LYijolD2o3TVbo9JufGWI 26Z2ORullsey99XSNgbkgRDjMnImS9VhHpWmeAKrbS/QZEP6yDH2U2J1AIQCmkGEPFl4 yO2kOF8XqIPGg5uF+uj993UVRm9Zpc1oOoe2632Yq7UG6igSCDJxR1q43eETFWJqODeJ firA== X-Gm-Message-State: AOJu0YzuIw98mC6mvZKNGxkbLlfY/3TynFqWBM2qnkgzzVHh6Z/1bshq QjZo6GJEYLR3hvEENiK0HkcQ/RTYipYi7U8hFDRzGqIWeHFWBt/WbuTowgSFqEQ= X-Google-Smtp-Source: AGHT+IFacN79u6UPEIFmJC5BiIlqzQdXLO1xoyXSIIFA0SGJexDJq1G83hE8leB5ySnKiUhld1/JOQ== X-Received: by 2002:a05:6a20:3558:b0:1d3:45c1:ad1a with SMTP id adf61e73a8af0-1d6dfab6debmr15348349637.39.1728321349344; Mon, 07 Oct 2024 10:15:49 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f681f1e8sm4480047a12.28.2024.10.07.10.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 10:15:49 -0700 (PDT) Date: Mon, 7 Oct 2024 10:15:46 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= , Akhil Goyal , Aman Singh , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Dariusz Sosnowski , Dmitry Kozlyuk , Fan Zhang , Ferruh Yigit , Harry van Haaren , Honnappa Nagarahalli , Jiayu Hu , Jingjing Wu , Kevin Laatz , Konstantin Ananyev , Matan Azrad , Ori Kam , Pallavi Kadam , Reshma Pattan , Sameh Gobriel , Suanming Mou , Thomas Monjalon , Viacheslav Ovsiienko , Vladimir Medvedkin , Volodymyr Fialko , Yipeng Wang , Yuying Zhang Subject: Re: [PATCH 00/16] remove use of VLAs for Windows built code Message-ID: <20241007101546.2a19311b@hermes.local> In-Reply-To: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 17 Apr 2024 16:41:43 -0700 Tyler Retzlaff wrote: > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the details for incorporation > into the series. > > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. > > Tyler Retzlaff (16): > eal: include header required for alloca > hash: remove use of VLAs for Windows built code > ethdev: remove use of VLAs for Windows built code > gro: remove use of VLAs for Windows built code > latencystats: remove use of VLAs for Windows built code > lpm: remove use of VLAs for Windows built code > rcu: remove use of VLAs for Windows built code > app/testpmd: remove use of VLAs for Windows built code > test: remove use of VLAs for Windows built code > common/idpf: remove use of VLAs for Windows built code > net/i40e: remove use of VLAs for Windows built code > net/ice: remove use of VLAs for Windows built code > net/ixgbe: remove use of VLAs for Windows built code > common/mlx5: remove use of VLAs for Windows built code > net/mlx5: remove use of VLAs for Windows built code > build: enable vla warnings on Windows built code > > app/test-pmd/cmdline.c | 2 +- > app/test-pmd/cmdline_flow.c | 9 +++-- > app/test-pmd/config.c | 16 +++++---- > app/test-pmd/shared_rxq_fwd.c | 2 +- > app/test/test.c | 2 +- > app/test/test_cmdline_string.c | 2 +- > app/test/test_cryptodev.c | 32 +++++++++--------- > app/test/test_cryptodev_blockcipher.c | 4 +-- > app/test/test_cryptodev_crosscheck.c | 2 +- > app/test/test_dmadev.c | 9 +++-- > app/test/test_hash.c | 8 ++--- > app/test/test_mempool.c | 25 +++++++------- > app/test/test_reassembly_perf.c | 4 +-- > app/test/test_reorder.c | 48 +++++++++++++++------------ > app/test/test_service_cores.c | 9 +++-- > app/test/test_thash.c | 7 ++-- > config/meson.build | 4 +++ > drivers/common/idpf/idpf_common_rxtx.c | 2 +- > drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 ++-- > drivers/common/mlx5/mlx5_common.h | 4 +-- > drivers/common/mlx5/mlx5_devx_cmds.c | 7 ++-- > drivers/net/i40e/i40e_testpmd.c | 5 ++- > drivers/net/ice/ice_rxtx.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +-- > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +- > drivers/net/mlx5/mlx5.c | 5 ++- > drivers/net/mlx5/mlx5_flow.c | 6 ++-- > lib/eal/linux/include/rte_os.h | 1 + > lib/eal/windows/include/rte_os.h | 1 + > lib/ethdev/rte_ethdev.c | 9 ++--- > lib/gro/rte_gro.c | 4 +-- > lib/hash/rte_cuckoo_hash.c | 4 +-- > lib/hash/rte_thash.c | 2 +- > lib/latencystats/rte_latencystats.c | 2 +- > lib/lpm/rte_lpm.h | 2 +- > lib/rcu/rte_rcu_qsbr.c | 6 ++-- > 36 files changed, 137 insertions(+), 123 deletions(-) Looks good: Series-Acked-by: Stephen Hemminger Series needs to be rebased to current master, some parts have changed.