From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 97B2445AD8;
	Mon,  7 Oct 2024 19:24:16 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2074842D7D;
	Mon,  7 Oct 2024 19:24:16 +0200 (CEST)
Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com
 [209.85.214.169])
 by mails.dpdk.org (Postfix) with ESMTP id 214204026C
 for <dev@dpdk.org>; Mon,  7 Oct 2024 19:24:14 +0200 (CEST)
Received: by mail-pl1-f169.google.com with SMTP id
 d9443c01a7336-20b9b35c7c3so49128965ad.3
 for <dev@dpdk.org>; Mon, 07 Oct 2024 10:24:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728321853;
 x=1728926653; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=1G/fpHZnTl2xbjGuab/ULmLurP4cRe1nsLq8P8VqQg4=;
 b=Gwns3TqCbBNZrhT5htgkWEBVVXvv25jp2/TS1FgsndJvutr0DpA3xL4agUAAyr1y9r
 1gPpZRfTZq3NqIAEiwocKQdR3lsiwjp21q51SzEGiRQwr5Jejv5ZmgrIuVsjUSXmnnZO
 S57h8izVc3aLtMpDya5IxohppT0uOauMdlsNSlanZ7Bfek33gO3rBx4KOUKXBbb4HKKc
 UwdYIZ/jp4Dyx3/Psafir53eHKYHCxJOiedi+6kIt/rCmO/I9iGl2ek4tQ3Lwdk+lHic
 tkpK+5/FkigEyRVIMwTi4TPLzhsaLPa5G/+HL+OjfmphWPTVZG8WLvZGxpU/hASdHr7R
 qjNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1728321853; x=1728926653;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=1G/fpHZnTl2xbjGuab/ULmLurP4cRe1nsLq8P8VqQg4=;
 b=mVExcFjCDs8AE8NeDK1ieo0P3RfWrxYlmjVnAPWER+JUKmUzC2/IOzgggUbkpT7JoC
 d1dhicz9JAIfFekGwe3PxR2OmTcgaN7hAwguJsKWSqHKdT/QgEv9LlpwTLtG2KfdPQNY
 0nuTSMqJa04iYYPOyzQi4/xaJ0EDEkz4lg2QjXNWMev1qWoY21C1AAHT5ZX+nOsz1I/i
 +9X8qq9WtQfqNO8KJ0bZRvXNkLugCKKIA0KsipYuhC9zaw7Yx4hICnZx73q+BwMVUg3j
 lEDH3U0vhz7934+PWlK/T/rtioMcXJtwQbz+jmwL2uauK8r78PT+wHoSiob5koABh/5k
 Hc8w==
X-Gm-Message-State: AOJu0Ywc2qcIqTL0soMe1Ox79eP8AxZ9699dTZKG8bvibVz3HDhJnjNt
 aKvr69+SMFSfauMG/mXuea5MuW4842rFtKrzJ+yHTDbe8OnxdOojLnI7/Paz44k=
X-Google-Smtp-Source: AGHT+IF5VFMxpusHRnWVkWsofxxAV6+eXu9BY5ktOSNORAauNP4gTGFmdaf90CuYH8sZB09DmseK+Q==
X-Received: by 2002:a17:902:dac7:b0:20b:a89a:1d3a with SMTP id
 d9443c01a7336-20bfe028a06mr188856525ad.28.1728321853285; 
 Mon, 07 Oct 2024 10:24:13 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-20c139391dasm41909045ad.124.2024.10.07.10.24.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 07 Oct 2024 10:24:13 -0700 (PDT)
Date: Mon, 7 Oct 2024 10:24:10 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Abdullah =?UTF-8?B?w5ZtZXIgWWFtYcOn?= <aomeryamac@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v5] devtools: add .clang-format file
Message-ID: <20241007102410.6c68f2c6@hermes.local>
In-Reply-To: <20240516082051.1255621-1-aomeryamac@gmail.com>
References: <CA+sj1i9wmFtzR+xQ_Z5g0cpOT1WA7jckwRQJexSuDVh2P3VqYQ@mail.gmail.com>
 <20240516082051.1255621-1-aomeryamac@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 16 May 2024 08:20:51 +0000
Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com> wrote:

> clang-format is a tool to format C/C++/Objective-C code. It can be used
> to reformat code to match a given coding style, or to ensure that code
> adheres to a specific coding style. It helps to maintain a consistent
> coding style across the DPDK codebase.
>=20
> .clang-format file overrides the default style options provided by
> clang-format and large set of IDEs and text editors support it.
>=20
> Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com>
> ---
>  .clang-format | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 149 insertions(+)
>  create mode 100644 .clang-format
>=20
> diff --git a/.clang-format b/.clang-format
> new file mode 100644
> index 0000000000..5f86e1be79
> --- /dev/null
> +++ b/.clang-format
> @@ -0,0 +1,149 @@
> +---
> +BasedOnStyle: LLVM

Looks good but any new file in DPDK needs a SPDX license header.

Not sure why, but it seems to be indenting somethings to much.
Example:

Before clang-format:
static struct rte_vdev_driver pmd_pcap_drv =3D {
	.probe =3D pmd_pcap_probe,
	.remove =3D pmd_pcap_remove,
};

After clang-format:
static struct rte_vdev_driver pmd_pcap_drv =3D {
		.probe =3D pmd_pcap_probe,
		.remove =3D pmd_pcap_remove,
};