From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A119A45AD8; Mon, 7 Oct 2024 19:49:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D5B4026C; Mon, 7 Oct 2024 19:49:23 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id C514B4021E for ; Mon, 7 Oct 2024 19:49:21 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20ba9f3824fso35003385ad.0 for ; Mon, 07 Oct 2024 10:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728323361; x=1728928161; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+94mD+m5BUQnl01PhjpqDwaMZYH8LqXy6LUVgVTlIVk=; b=zhbgzZKKGRm7AYXcUgKlNIjSL0O5aO03GN01KvhPCcaeVf17J6Ks2cL/fxjEC0tXKp MQRCElzEXJBvFSrVXQCfolgcPCjDbnV0eHlRzAfI7VFaAJuw4wIt5gc6CO5FQmItcPed fzfU9UM4jJxDFYuqItmZ1IZXfR+02i28755DdO8ep90O81S96Ota4RRd2YWVuofR1WCh 7J2NrTl/CRFjRZSL7vRXkYjxJc36JnpefIE75YI3EcNLSKcIKSljZIiuUjaJuugwYmmo MHN8ZvV1y8NMRqfDrhC2xMQ04VlmTOfvqZOm5tgx+dmPcRx7kstjwqEz9qcLXFavnkJJ +5qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728323361; x=1728928161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+94mD+m5BUQnl01PhjpqDwaMZYH8LqXy6LUVgVTlIVk=; b=OcDNWd1gmDTUopWMk+DtsMAfuPxwpj4q7gkoGSomcEXz5j4IphU/j7Iz47pzHRaaMV vfXWM64GcNgVfhipaj+2uyQ7fENqChUfRh+BiqcBzHjdlIi0wPubJsU3e47lyxDQC7w8 uzAzx6ImZNc0by9JfkXjQ1kJJVtpyuZJ1a9IbLynP9ZeAN4rNtH7mRNOP6k2m9/XI8DX ryj0iqtoK34Df+qJcJaIpfl2+g63Eyt7LxmpUwirVzwTa2bb/CuwJO+MqhmYuGfzSlxh dmLLkF0Z5U41CIlXra61l1Vgd2g7o6IFqdMFmCbDp2/mePdcb4yc1INPho63eTCN+oTh 9rhw== X-Gm-Message-State: AOJu0YyoNKX93EoFyFUkcm0UlhVuSG3YSZ8oZColAjz2/000sAsadnBS JEbK5F1fX8ZClEBxnix4XqjKzZhe6IzPlbRFgzO9MOjTYpd5XxqPx8Gww2od8qQ= X-Google-Smtp-Source: AGHT+IHxLb0LoYMGADXII27Y11qrH0DaqgBKWE3/MZLhN+y8ibqZpCZmitpPFAefi5UTBZstXcenvw== X-Received: by 2002:a17:903:32d2:b0:206:a79c:ba37 with SMTP id d9443c01a7336-20bfdfb05e7mr142524705ad.19.1728323360937; Mon, 07 Oct 2024 10:49:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c13969bf0sm42197485ad.238.2024.10.07.10.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 10:49:20 -0700 (PDT) Date: Mon, 7 Oct 2024 10:49:18 -0700 From: Stephen Hemminger To: Konrad Sztyber Cc: , Chenbo Xia , Nipun Gupta , Peng Zhang , Long Wu , Zerun Fu , Chaoyong He Subject: Re: [PATCH] bus/pci: don't open uio device in secondary process Message-ID: <20241007104918.463c9adf@hermes.local> In-Reply-To: <20240828104002.226704-1-konrad.sztyber@intel.com> References: <20240828104002.226704-1-konrad.sztyber@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 28 Aug 2024 12:40:02 +0200 Konrad Sztyber wrote: > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the device file is now opened only in the primary > process. The commit that introduced this regression, 847d78fb95 > ("bus/pci: fix FD in secondary process"), only mentioned enabling access > to config space from secondary process, which still works, as it doesn't > rely on the device file. > > Fixes: 847d78fb95 ("bus/pci: fix FD in secondary process") > > Signed-off-by: Konrad Sztyber Wouldn't this break use of interrupts in the secondary process? The patch does need the minor fix of the comment style. So resubmit