From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7314945AD8; Mon, 7 Oct 2024 20:01:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 096AA4026C; Mon, 7 Oct 2024 20:01:43 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 543864021E for ; Mon, 7 Oct 2024 20:01:42 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-71def715ebdso1996832b3a.2 for ; Mon, 07 Oct 2024 11:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728324101; x=1728928901; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2P4OnZlDg7lS08SPZkxo3KLnjw1YjHGh7Z8W1HJ898I=; b=N8VuEgSI67GV0vrJLZmiPefMP/zVFx1sV4xdUYqNlnNz/0wqaD9aOiYjd4Un9RrnuU NURWFruEcrbWeL+XS08XEbAAjz6kRq3LtgSdLkgQpSflAjlxeiunN569LW1aZI05ddPL OUqb5xwUZInsa1HtlNiCtLIv8Ww1BgjSf52OodPfLBrT4ZNb1DRgWCnMkZDC19AScpp9 8ReVK5a30rPRlXhZm1guBl5sBFlDwUeyJFUBaVXQkLMmIaL9olOMnlYJ2GUFbX+kKyXV cjxbBtCtZXUae/6jZbpIh6ziZ7Dkag9MfJ5ZYVRwQlZ0ZrN0nqXxmcxvItX2ET8yzBQ7 rIvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728324101; x=1728928901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2P4OnZlDg7lS08SPZkxo3KLnjw1YjHGh7Z8W1HJ898I=; b=bUDlp35l1BjJUHwPK4FNP4oQe1zOjbMtrlnIqQS/ohLZc6FguNPWFm8fKNKI8yxNaC jFgHiVi5x89+F2qqoMEqXWmRxmiAp/TiuoJBjuEBq9Gyeh7/UqXAHHeJ5LlKsLoaaD9g qOxHnltZog+ui98HjYktIbhgVb2zb8c/ovnksDAqhSA4y9z3z6S7tiQTxoCNgryPOVyq /gtf6oyIt8hPbK9qa5XTgcZoJi9lI7KBGWAqsgvRhZ7Ogu5e4696Z9jKkCMHuhEhldzL bBsGxjTGFn3SpCEVM8ad/1pjvh8jZhZKesxEnQ5WCrLiNdYLnaFhkwi5bUkTHisRLbPs R4Gg== X-Forwarded-Encrypted: i=1; AJvYcCVvp65A02UAaOVIG2+n7gwAqzk32SY8IkEgc0Ts2K3v3kDEwpk5v0o47xlf/P5+YdohSKg=@dpdk.org X-Gm-Message-State: AOJu0Yx4V0lTHg6dxDN74SWrrr2mCytLvallNCrCmPSHAFLd81wgv4kb bg1j4MZFXigW+/y7768JuX9u/ovzZXdmxPxci+Ldf6UJkle9CZ9Hq1Zsi7232kw= X-Google-Smtp-Source: AGHT+IHK0zH6ViNTTKEU9W8MSO6RM94VIZutRKc3ti8/g4ZPut2Qh3BMEyHYXbft0uzRATaNLd7gzg== X-Received: by 2002:a05:6a00:9284:b0:71e:659:f2e7 with SMTP id d2e1a72fcca58-71e0659f589mr4941736b3a.8.1728324101426; Mon, 07 Oct 2024 11:01:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0d452b7sm4699419b3a.108.2024.10.07.11.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 11:01:41 -0700 (PDT) Date: Mon, 7 Oct 2024 11:01:38 -0700 From: Stephen Hemminger To: Sivaprasad Tummala Cc: , , , , , , , , Subject: Re: [PATCH v2 0/4] power: refactor power management library Message-ID: <20241007110138.3dd88283@hermes.local> In-Reply-To: <20240826130650.320130-1-sivaprasad.tummala@amd.com> References: <20240720165030.246294-1-sivaprasad.tummala@amd.com> <20240826130650.320130-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 26 Aug 2024 13:06:45 +0000 Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers/power/uncore/*'. > > This refactor significantly improves code organization, enhances > clarity, and boosts maintainability. It lays the foundation for more > focused development on individual drivers and facilitates seamless integration > of future enhancements, particularly the AMD uncore driver. > > Furthermore, this effort aims to streamline code maintenance by > consolidating common functions for cpufreq and cppc across various > core drivers, thus reducing code duplication. > > Sivaprasad Tummala (4): > power: refactor core power management library > power: refactor uncore power management library > test/power: removed function pointer validations > power/amd_uncore: uncore power management support for AMD EPYC > processors Build fails and lots of comments. Please redo.