From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B52A645AD9; Mon, 7 Oct 2024 22:20:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0929C40647; Mon, 7 Oct 2024 22:20:49 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 3397340285 for ; Mon, 7 Oct 2024 22:20:47 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-6bce380eb96so2977973a12.0 for ; Mon, 07 Oct 2024 13:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728332446; x=1728937246; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4DEJT/Mq5DHElhA/1MWomJHP7FDg8jNjRW13369Mv0M=; b=nKxuG/ojVVfVZhiJ79Ojd4uR9VVTtXEw8gXHzUgmMJpdbCK1vYPRdJSBaSr5EYEzFz OMdEJxy+taaDg1zatKI4XmKhi0b+mHqikMCZn/IjC6Uf+I15aprAH0IP7CZceBSixlji uu8QA6q5OjaQ8bY+OUm94csNCVtevV4YzS8KRHOVzaKET5ojGS7VgMugmiDPzzK8BPD+ V4uy1h0gsMyfR/rK4Ffh4+ZWLxJpFxZ+d6J057oTV9/C1WlCF+AZC95MLdshYIVFE6g7 AkxpXSYExKP1aCcPkocqkmGJZg0BglvjHHU+eNBv7B1tYF9LsjEkgo9L13n/0EgJH/qq ifMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728332446; x=1728937246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4DEJT/Mq5DHElhA/1MWomJHP7FDg8jNjRW13369Mv0M=; b=n1jpAYIt1Z2W2y7FONjwls8lNw28ylPFnc4ZImKfUsvyCVdNLhIbCG3qqak8a2aaPD mRECuzfCfnffy3yqxqfYd1e3Ps4cGn8+FPVfxt9sNF/zEjVb3681MurYET4cS8FhtrK3 egfcMiHv4pl4DsY2SqrfTGnJfb3uUG0SzgwUht0n/ckOnE/2jyx9KI3fi8L8HkczKXPO PMYjtNPYkxmwE8NmmRJlZX1ybpo4JUTprNkf3tIDjwkckKIgndHvM6kt1GSVGsG1Wj7k yARBJQWWeMU2458H/XkBtB2GPxkMahON9TGTAfY6UQF7zzUNCXX8OIQKr4x7TBnmPMEF QCwA== X-Forwarded-Encrypted: i=1; AJvYcCWzmvQVx3dUx7mnnyhq+1HFu3oIXRgUqi3aH77pwXfeNtV9VK/sL4dcxHRU8YQJhWA8sVE=@dpdk.org X-Gm-Message-State: AOJu0YxszzudQQ6RY1zOzmU8fl0aFBf7GYnVvAoMoUsYYCrY2B2Sr20t MD884wyD4x4mQZXVE9Z6tyTmIcu8d1R56SNP2Npj2IgI8jA0Wl4JsBHyOvcsbz0= X-Google-Smtp-Source: AGHT+IEUeZcu5FzIT4bqP6iu2rOi6yJ8W7+sJko441pvYeRYBTG7FbtQetv78yk06Pn4D/aDWw2HsA== X-Received: by 2002:a17:90a:ce8a:b0:2e0:adbd:dafb with SMTP id 98e67ed59e1d1-2e1e621e9acmr14643828a91.11.1728332446426; Mon, 07 Oct 2024 13:20:46 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e20b12e245sm5863729a91.52.2024.10.07.13.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 13:20:46 -0700 (PDT) Date: Mon, 7 Oct 2024 13:20:43 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: Ashish Sadanandan , dev@dpdk.org, Thomas Monjalon , nelio.laranjeiro@6wind.com, stable@dpdk.org Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h Message-ID: <20241007132043.66372dbd@hermes.local> In-Reply-To: <20240402161923.GA19422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> <20240318024415.555614-1-ashish.sadanandan@gmail.com> <20240402161923.GA19422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Apr 2024 09:19:23 -0700 Tyler Retzlaff wrote: > On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined references to these functions. > > > > Also updated the coding style contribution guideline with a new > > "Language Linkage" section stating `extern "C"` block should be added to > > public headers. > > > > Fixes: 86c743cf9140 ("eal: define generic vector types") > > Cc: nelio.laranjeiro@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ashish Sadanandan > > --- > Acked-by: Tyler Retzlaff > Acked-by: Stephen Hemminger