From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 971A845AD9; Mon, 7 Oct 2024 22:32:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65A0C40285; Mon, 7 Oct 2024 22:32:41 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 1C6A34026C for ; Mon, 7 Oct 2024 22:32:40 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-20ba9f3824fso36343965ad.0 for ; Mon, 07 Oct 2024 13:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728333159; x=1728937959; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7anGmnHKbW8mHCjoWsg1gEidnTjygnKnbQ58sHGHRnk=; b=WGWpnOhvGzYlWKkmxVBEkgSjAVSJMj6/2clLSXtgktMZCkDELCkF8jboym0gQN6avN Cjw4PY7J15We58oFPe63xGZ6LWl5qJyGL7UF9TV/67IE91Y1mWeKCs8QhngqMjTJ+DJd hBo717huH4pq0lsXvzXNT3LYuECikltvTTuqGhzAc+KnMmA75jpjB4aJwBCiwWzKGsqk WtHyArRgNmnpaNFlKTDdbyhHnklh8g0+nsSvvv3BcGyx1SjCATrLMTY0LIl19dB0xhvD KxacBm2pMoCSBeag+DgGAdDvmrzcvvM3t/opqyuZc0qH0xOTFZDP1Dqn81PB+T90dG2Z MCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728333159; x=1728937959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7anGmnHKbW8mHCjoWsg1gEidnTjygnKnbQ58sHGHRnk=; b=GS05PEPUivlVzU53NIaUnmJa5e03tRXR9n8tWN1en81usQPZ9i5OYUkNbb4eJGOom9 fn2OrSmGqxGO+0GdD6C7oLQ2AGCnBSgfClZV89uwDT15IwbCkJnp+3S6tBOITIsNP+lL dXFdMFnEq11bsrSShp/hyZudQ6bUWJeIlbn53ZxX9URoEnh/qjwtvK30abmTzIE7bVFz 9seyif8We+L4BvmMgHq4IhYK2OKLVJQ2/KGdr48FLHsWht+Q4Srmm53ESvx+NlsI26kb cvPLa8JLOHp5JukbQSGH46P+KG6s6xzdpDRCll5EXN7vhfJEHFhb7O/z8T4HgjZioAA4 WWEA== X-Forwarded-Encrypted: i=1; AJvYcCV+fi3J/vGgENn03SlDoMhVhKRvYydD+2Jdb31WmQbnmNfW5ig+ylhsiMCm7VO6QbAl6uk=@dpdk.org X-Gm-Message-State: AOJu0YwoPc8qM4yM+6PpNg+mJTeOqgl5E3qUTzJ050GfETUitndWjA6c X+tQsibAuHjANY8YRmKkFaNZ6Ha5oCUHKLXfeNJrGNabgG9F1gWYrvSpb3bwURw= X-Google-Smtp-Source: AGHT+IHGCYYfd279ldaj3VGMej/jpiFJVqOe+Izj75CnXrKv2CG7U2YmQcGInVLiT0yi72rq1T8KAg== X-Received: by 2002:a17:902:db02:b0:206:d8c2:4a94 with SMTP id d9443c01a7336-20bfdfeeccbmr194450745ad.25.1728333159319; Mon, 07 Oct 2024 13:32:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c13939e08sm43560015ad.146.2024.10.07.13.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 13:32:39 -0700 (PDT) Date: Mon, 7 Oct 2024 13:32:37 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , Subject: Re: [PATCH v4 0/6] refine argparse library Message-ID: <20241007133237.292a6424@hermes.local> In-Reply-To: <20240318111838.16991-1-fengchengwen@huawei.com> References: <20240220131502.47510-1-fengchengwen@huawei.com> <20240318111838.16991-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 18 Mar 2024 11:18:32 +0000 Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argparse: fix argument flags operate as uint32 type > test/argparse: refine testcases > argparse: fix doc don't display two hyphens > > --- > v4: address Thomas's comment on 4/6 commit: > - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and > TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. > v3: > - address Thomas's comment on 4/6 comit. > - add commit: fix doc don't display two hyphens. > v2: address David Marchand's comment: > - replace flag enum with marco. > - replace flag's hardcode with macro in test_argparse.c. > > app/test/test_argparse.c | 65 +++++++++++--------- > doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- > lib/argparse/rte_argparse.c | 61 +++++++++--------- > lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- > 4 files changed, 127 insertions(+), 131 deletions(-) > The patch set looks good. My only comment is the term 'refine' was confusing to me. I guess you meant "improve", "clarify" or "reword" since most of the changes are about changing the wording. Series-Acked-by: Stephen Hemminger