From: Stephen Hemminger <stephen@networkplumber.org>
To: Niall Meade <niall.meade@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH] hash: separate param checks in hash create func
Date: Mon, 7 Oct 2024 14:08:17 -0700 [thread overview]
Message-ID: <20241007140817.5e5f1f15@hermes.local> (raw)
In-Reply-To: <20240726145443.1058676-1-niall.meade@intel.com>
On Fri, 26 Jul 2024 14:54:43 +0000
Niall Meade <niall.meade@intel.com> wrote:
> - HASH_LOG(ERR, "%s has invalid parameters", __func__);
> + HASH_LOG(ERR, "%s has invalid parameters, entries must be "
> + "in the range %d to %d inclusive", __func__,
> + RTE_HASH_BUCKET_ENTRIES, RTE_HASH_ENTRIES_MAX);
Suggest shorter wording and don't break messages across lines, it makes it
harder for the user to search for them. Suggest messages like:
HASH_LOG(ERR, "%s() %u entries outside of range [%u..%u]",
__func__, params->entries,
RTE_HASH_BUCKET_ENTRIES, RTE_HASH_ENTRIES_MAX);
Shorter is better.
next prev parent reply other threads:[~2024-10-07 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 14:54 Niall Meade
2024-09-04 17:28 ` Medvedkin, Vladimir
2024-10-07 21:08 ` Stephen Hemminger [this message]
2024-10-10 16:46 ` [PATCH v2] " Niall Meade
2024-10-10 17:34 ` Stephen Hemminger
2024-10-10 17:38 ` Stephen Hemminger
2024-10-14 10:19 ` [PATCH v3] " Niall Meade
2024-10-14 15:28 ` Stephen Hemminger
2024-10-17 7:44 ` Thomas Monjalon
2024-10-17 15:10 ` [PATCH v4] hash: separate creation parameters checks Thomas Monjalon
2024-10-18 8:37 ` Thomas Monjalon
2024-10-18 9:26 ` Meade, Niall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007140817.5e5f1f15@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=niall.meade@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).