From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C909F45AD9; Mon, 7 Oct 2024 23:08:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F53B4060C; Mon, 7 Oct 2024 23:08:23 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 54826400D7 for ; Mon, 7 Oct 2024 23:08:21 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71e05198d1dso888330b3a.1 for ; Mon, 07 Oct 2024 14:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728335300; x=1728940100; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KLOHxjOjX861vvb/+b8i1KMEAZJyA919EsRskqnfFtk=; b=IzNXzTMEADgkvIN+J7bDnyQQtah4CRm1S2I+ctJKRYxvVb2IN9ekRTfci72VzJ1hdl 9Ffir078QOZYwRfOiemW9loOY0hZNSOOhmDudnYAvs8W7lPMtUbVVaPz5JDGmYJOMd2p gjf7SsNye3j4GthIV3CO/GzQdIeAgEQodUUfkO5xZcQDEH0cLV1WN2OV+HWWF43744YN IvpEE90s1BM6yKHZFhlavrN/R6Gce6BbTzRLETmS/JbcnaVD1xwUSQ5VOh36hnfZdujW r3YnzVxQ12+gwnteM+qBQBZ0jRCqONN0mkNcOCzCY5OlY1+pwceim+gV/GmOy9kBksGn FMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728335300; x=1728940100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KLOHxjOjX861vvb/+b8i1KMEAZJyA919EsRskqnfFtk=; b=ieEhFNpxzpAcuBtFoEFKb2sn0kGgsD7VpUkfoesrkipdxU4XXq2Sk+1KJHTDx2m2Il Rifwb5SaI6ciGChDVX1mZNRnCbgXkdKihrXstoJUjrhTb1djdeAhISLVYslGaYaUiy6e 8D/8Shj9jYPA986fkXaj8JzqXXiAJM68OscxbYPOH3L1b5eZhnhp2OvrPZy0Igc9kUXQ NHrsis2CsQ7QNG7eJEkQVv8VT6ryOr74dvz8mrQFM943zy2Qylo02gtBd0OaWV2KndHN l3oCvHo2bR7V1XECLnOU4rF8fxILlW2UOUW4NKWqBwat8UMnPMa7HWQflZ3DL27EtU4v nOJg== X-Forwarded-Encrypted: i=1; AJvYcCUcaWLlJCYtJLc69Kzi4aLgLtdHEMGjbiDh/2DuoKy7xE2QRS9UgPOcVA3H0VoTXvANx+0=@dpdk.org X-Gm-Message-State: AOJu0YzcsK+IKMd0QpldnoSkwCk9hiP0dILeTN0eDg+LgasCLva12W4k QkhcWRcHmrYEohsX7nOTwyXIy/bSKDFMKMcHPm3OlULCqH/8ON8YmirC7FH5BtA= X-Google-Smtp-Source: AGHT+IGY9ci4bwlXN5frOX/xM598XNumkI6Vky93mWV/qatRnafVnH/X2bvBmy6dm2qDBctw1m4GDA== X-Received: by 2002:a05:6a20:cfa6:b0:1cf:339e:a8d1 with SMTP id adf61e73a8af0-1d6dfa24bc2mr19082829637.10.1728335300519; Mon, 07 Oct 2024 14:08:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0d6525esm4855444b3a.161.2024.10.07.14.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 14:08:20 -0700 (PDT) Date: Mon, 7 Oct 2024 14:08:17 -0700 From: Stephen Hemminger To: Niall Meade Cc: Thomas Monjalon , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , dev@dpdk.org Subject: Re: [PATCH] hash: separate param checks in hash create func Message-ID: <20241007140817.5e5f1f15@hermes.local> In-Reply-To: <20240726145443.1058676-1-niall.meade@intel.com> References: <20240726145443.1058676-1-niall.meade@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 26 Jul 2024 14:54:43 +0000 Niall Meade wrote: > - HASH_LOG(ERR, "%s has invalid parameters", __func__); > + HASH_LOG(ERR, "%s has invalid parameters, entries must be " > + "in the range %d to %d inclusive", __func__, > + RTE_HASH_BUCKET_ENTRIES, RTE_HASH_ENTRIES_MAX); Suggest shorter wording and don't break messages across lines, it makes it harder for the user to search for them. Suggest messages like: HASH_LOG(ERR, "%s() %u entries outside of range [%u..%u]", __func__, params->entries, RTE_HASH_BUCKET_ENTRIES, RTE_HASH_ENTRIES_MAX); Shorter is better.