From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v2] r8125: add r8125 ethernet poll mode driver
Date: Mon, 7 Oct 2024 14:25:32 -0700 [thread overview]
Message-ID: <20241007142532.3048e218@hermes.local> (raw)
In-Reply-To: <20240612095145.5760-1-howard_wang@realsil.com.cn>
On Wed, 12 Jun 2024 17:51:45 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:
> r8125 is for Realtek 2.5 Gigabit Ethernet NICs.
>
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> ---
To echo what Ferruh mentioned.
1. Break the driver into more easily reviewed pieces.
2. Run checkpatch, there are lots of style problems still in both drivers.
There is a new driver writers guideline document that might help you.
next prev parent reply other threads:[~2024-10-07 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 9:51 Howard Wang
2024-10-07 21:25 ` Stephen Hemminger [this message]
2024-10-08 3:31 ` 答复: " 王颢
-- strict thread matches above, loose matches on Subject: below --
2024-05-27 6:15 [PATCH] " Howard Wang
2024-06-13 3:36 ` [PATCH v2] " Howard Wang
2024-07-05 21:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007142532.3048e218@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).