From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6962845ADF; Tue, 8 Oct 2024 09:26:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AE8B40E09; Tue, 8 Oct 2024 09:23:53 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2085.outbound.protection.outlook.com [40.107.20.85]) by mails.dpdk.org (Postfix) with ESMTP id 8789640A70 for ; Tue, 8 Oct 2024 09:23:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dxM9IRRbD5dz9SD6N1sA42LeDLbeqAJ8yA1mo40uxMl01mrPcJrvEuYONX6CRGF2qKTKmuHqSnpG/b3ZT9rlkf3IbTsnI3B0NkqOIKwoutPzHgxlwqp07SDLViKWrsHDSYQqdqBaBhNcX+i3XQye7YlT+T5FYx+fIMNsAnwtemocSlc3oAT0SlaH4UnAme/T62K6rrcNLChYp6HgP7xI8pTkF/lq+UAZ10yfl1UVbhaDuwQ+1Gx47fVNOtlLGNlKFgaaFXFRrDgsY+Rd6LD/yUoF5IjKhT8qwutkHXQ5BffqTps8DeJXGfcFMA+vJK5wfApKYIOwEHejrUH1sCc7uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KfWLKoUMSOqFX4MMW3bcg+FBKD1B1131aU7k51TmEz4=; b=wARBw6VUSP92ApXcj+BwcykJm7HLtzXhPitoyDE6ApqmjcOaF5Ye0fp+e4+xEKLf6Wd4simabeGtSWF/T1Ek91pVRJE1dO50AUfghDhYWa4KH/Ncp8wtLckyTDs/LsuSU+KSdEBYe2owHEcz1hK7SZZNw7NEvMzUr3CvMtu8hEk1kNgZaU32dkFzCQSXHBZ2xMKjB4dg/bJz8CMYng71ESCw6I+0pSHq9WOFiMpF0a58KrCnw2IbarbI9a7yZu+Sx5Bns2lguZ/Snh+S6xw9duvwOEZBeNPa2jTwADEgUyv2/ekdTUPIoHeRB981X3dRM5z/C8tKl8THq2o0mZ6Pjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KfWLKoUMSOqFX4MMW3bcg+FBKD1B1131aU7k51TmEz4=; b=I8OHbVs3gsHnAQcR7Ntorbka597f/QvkPJqP4Ngp5wqGEx31jOF/ioRaOdslTCiu4/3Fk15n0Xs7HeSRnHEmngFOJrOqZlUliGOQpQFHKn6KgS8KZe9Hz1FQPBY1YIztGiQZbCTnJ7pb7G/FDdCcKePkfMudKVcnsh8tzfjJT/Mr+N1jeZJysy3jwO4TZ3NmW9n/Jznc3S7DcWGspNcfL7IHdZo7jRV+83plcXsZjZoNl39JVVgUSdDuE+Xt5xTwi7/lJ0ghfji2RaFGx7AG6Zj33qwtOWuau14mSBz3WEJReqMd8ipTbLQYPpGW70r3OBbH1/7nxp6WnTXm73GzSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by VI0PR04MB10829.eurprd04.prod.outlook.com (2603:10a6:800:26b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Tue, 8 Oct 2024 07:23:49 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::2e32:1a4a:7d29:195]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::2e32:1a4a:7d29:195%4]) with mapi id 15.20.8026.020; Tue, 8 Oct 2024 07:23:49 +0000 From: Gagandeep Singh To: dev@dpdk.org, Wathsala Vithanage , Bruce Richardson , Sachin Saxena Cc: Jun Yang Subject: [v4 12/15] dma/dpaa: qdma stall workaround for ERR050265 Date: Tue, 8 Oct 2024 12:53:03 +0530 Message-Id: <20241008072306.1256445-13-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241008072306.1256445-1-g.singh@nxp.com> References: <20240722163930.2171568-2-g.singh@nxp.com> <20241008072306.1256445-1-g.singh@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG2PR06CA0221.apcprd06.prod.outlook.com (2603:1096:4:68::29) To AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8198:EE_|VI0PR04MB10829:EE_ X-MS-Office365-Filtering-Correlation-Id: c241bd46-1075-401b-cb01-08dce76a2705 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?N+PV7W8HpVNq7cAey4ZkK3ubFamuh8vvqPko8Ho0iC4Zn4P8Bm4o/MdkdN/2?= =?us-ascii?Q?LWdMpkQne/rVUQAvs9UoN2QZNbuKop49BoR8zdPb9tIogqLR5dykVY/2MS5H?= =?us-ascii?Q?76x90deRemARnVS5FkBRSA8sveEOXFPh+djjjzMOhgfFBbkdhEEnr5Sl/Xs3?= =?us-ascii?Q?8eeXndTkWLVsTAjg8Whfj36uHKS25Uo3sxPRhhbGL0HWr1oLmfN9b8GIUMyH?= =?us-ascii?Q?S4txI3uxVSQSBJNxdWF6UgIBumd8axIADJ2pAKHD8bCx4V0V67PdfMDZO+Zq?= =?us-ascii?Q?fN3kDZkA/8d6tq126ictIHkH4DVL+HFWQWFrkHne9rgYaad3VA+sev8/QTjB?= =?us-ascii?Q?Jvxjqhuc/NgW03JGnbCPnZbYDc4vFGkhkFcAJJBw5bIkAZ2IF14l00s7aP81?= =?us-ascii?Q?fMbwgRRiNbyYYGCSi9nTvLGwlzCuq74UnWpMxSiPE+ezA+Pv5H5PrQXWIWNp?= =?us-ascii?Q?2nHQw8gzGSRjEW/6ZqvaZ1tTAi4GmB439xpZt6FPor0pMJ/Dtyd9ITsgzvYW?= =?us-ascii?Q?GWZLwEwv+MkW/YIB1K3kxJ1tluCTJJUAMnJpRvHa+GJ/09n0IOLWkjQsf9/m?= =?us-ascii?Q?Ppri4rcT1QH4qrFe7D+6besBMwcsttzGisGz2kgn/Lif3OFsZIRFTjSVXQTZ?= =?us-ascii?Q?iJu0B1DIRnZA5aNajEJG5ddMfI75/dBbQ0ms6Bjz/BcKM7cpr8R6xoUHcWVG?= =?us-ascii?Q?pKg/lZ2ZFr99/jzOk13K6LGC5jG2nuGnXFx31QseHpCMzz9hTNTPcG1XMRDr?= =?us-ascii?Q?BIBqYo4DtY0ZgZQ5pNfI8S9XqJDhJN/7PnVPaW/I5xgelc+d1AFie/ZFVwx8?= =?us-ascii?Q?GyrFMHuSatMsWkc+w19oUGv29VL+hbPtzzJ/PWZqI2q6RWAf2zHlc88r59ir?= =?us-ascii?Q?dAhgNrUiBrWxWjKykWo+Tp/ndiADnFav/G1ozegOMk5uH6rVEq2U8Z4FoF2u?= =?us-ascii?Q?mliq12RjpOFMymO7GVEHMTNlm3ZEz1qgKVK0TnH/4ROqlGXAW05O86/YhhqO?= =?us-ascii?Q?3HinyZ1q8GC1pK4k2jgObdlZqZwvokcrjz8a2/h30YbocsNGEDRHNmsS5CdC?= =?us-ascii?Q?Dsa+s3vFdRAu1N7R9gQ64PA0HdFQU1Boij2XQK6lF54NEmQkCT2CEpBCJDDc?= =?us-ascii?Q?e7L+dxvX4zaKUAfuO3Ze3iaOnBYpsnb3oeVTBWa48ELiNvXGiMUH5Ng+lwbb?= =?us-ascii?Q?3SDfHotRFoaX6TJIvetS0Ylk66Zj+gmQOuHPd2o3oXlEsi4GmvXINNRGZjX/?= =?us-ascii?Q?/LyrsuXOGgXfdjdwm8AV9C6o25noiYlhYaiUggbvf5mXWBIXdWqSBVRdlCso?= =?us-ascii?Q?00zCaFW4BBYVKiMtpLHsM4Q3f1Bqzc7jMXRBmd9RZyEUCA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(52116014)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3DwkKIDZ5wjvU7pS7Jcpsu1jn7yzd4552v7irk2Oszq760Dh+dCuQSkvUIew?= =?us-ascii?Q?G5vvRyo94fIK35SoqBXzNQbX+Q3odbZmxenGUb0T5nZEZU/YYXN8KgIt6wWv?= =?us-ascii?Q?pCG00OswauVLpzmnX/l0UHovmgiNeKW0U4ISseqpkE3oUTbTq9btmCl35Bli?= =?us-ascii?Q?8FK+34peV0sUHm52IzkS29/bzx2woNMugSO0of6i4IDuyq83ZNos5uMSBcKz?= =?us-ascii?Q?6nJWDWcZTzeMboHs9YKx25maqf+xwwYBg+jkY9m1IjLuMpOK5LepmX2N/B8K?= =?us-ascii?Q?VpvPh+UaAAta4CpxJMj77tAiZdM3J+c8wPQStiEOT7sqeG7zkMHFzfZ+3c0s?= =?us-ascii?Q?m8oYvK0nsWhLCzC9eks9MZja4qWTiqjCiXZAg15p7nlf7ZiG7AJqbwxorDVF?= =?us-ascii?Q?oFRcjmu/Fpvogyo8a6snV4yA2TCDQs+8UVLBJJKAqFHTsLyYDu3Brn2ZXOQj?= =?us-ascii?Q?f9kW9+S+sbTboQAwCb4FqtS6my3Xys0W//W75iW4cf92PJ6CI6oIdEEmMw4B?= =?us-ascii?Q?ucjA3QVP78Bj7baq4uErPKuMTd01e8yqIok3R6k0adCLr7ayuniXfZbaPXB0?= =?us-ascii?Q?QfEsXMH3+A5aNUmcYcsGjNvLs5MhxfXi7xmseQoJCW6zR3Ms5EYHH1zjkzl3?= =?us-ascii?Q?4hY6JvyLDNTb4LpDbr2fVBU9hxO7wtdVVlcGVYBeoMXoDp+N1U3siES9NcTd?= =?us-ascii?Q?M7obAYCmH1AoPhngehMIoF+iXVDYjaLBnVr7B21lejVtXpdlCKLJZgnB1Tf+?= =?us-ascii?Q?dS7aX3ylLvWLdL49ZmlJ3rfwtCUZ2S3rOxvFZ37shwq1lz7lKw1tv3+RxwCP?= =?us-ascii?Q?Z54HlN83qvpgs6DLZd9CSzJMdIJARoMWFs16YCWXK2hRW/z+zMOe+bGWEJCK?= =?us-ascii?Q?NGJbWiShDLa+o9tdF0i0cPIlSXoi+FNNpHPPkMKLCQwa+/ZQ0tnIb+2ObFI4?= =?us-ascii?Q?AWwXb47dnP2KlncrluVvtKzOYin2FcxvgqBx153rrqkBcBE74NiEuhdcWO6G?= =?us-ascii?Q?HI+vLNUexKm3yjUlcCA8TNUF281XhsKIAAF4hR+yijv8+VnPyqUnI6ghM6jR?= =?us-ascii?Q?o3+/nYEjXu1FW+4+3ubeYbVfaZ2Pxj8RnXzNtxyCzhjpcm/eHDdfWKwHhzwA?= =?us-ascii?Q?OdLDv/upYjApyJAFyZrgydkEh3IMxVqYqmJ/7o97p9zeNXwRyQd1QBWCZ3Hr?= =?us-ascii?Q?5Ax3hkmDG+JRoDasJ9MpmM/6UwV7dCZU7hDZQQY1sMApjqTC9iletrVz9PVO?= =?us-ascii?Q?WpzWvCS/g0eaTtEp2nIYL+X8QbqFT6Pj5f2XpTiyPYcog+O0IWyEDvxCR1ku?= =?us-ascii?Q?RSqhl259eJJsKwi3mZIQ33HMpJLr6A4D4TI3MONckb5rRBkGaVxqBMhicwUo?= =?us-ascii?Q?toMHO/3Gqz3LWuK3Lnon90HLar7EMNS+PVzhYQJc6MxoR4dUzj4+22sn29yP?= =?us-ascii?Q?i4CjkQUYq7pdBl2Ed98pCkP0Mn6P5/fWc592qaLp0LtXtzr2hEfUhpOOj3b7?= =?us-ascii?Q?TvMbGijezAU52oNeMwgyVJEmWDfeq/OCTUXu0dNlkxEnfqkDPc19A3+5jn1C?= =?us-ascii?Q?VUmI0zWoUIHhOeCvnPo=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c241bd46-1075-401b-cb01-08dce76a2705 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 07:23:48.9219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bRL4DN2tYTSHpbFZwpc5hZTuWSBZgktRJ4/9GpC20TDn68JuAIRGmvD8PPtMar7s X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10829 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jun Yang Non-prefetchable read setting in the source descriptor may be required for targets other than local memory. Prefetchable read setting will offer better performance for misaligned transfers in the form of fewer transactions and should be set if possible. This patch also fixes QDMA stall issue due to unaligned transactions. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- config/arm/meson.build | 3 ++- doc/guides/dmadevs/dpaa.rst | 1 + drivers/dma/dpaa/dpaa_qdma.c | 9 +++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index f81e466318..f63ef41130 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -469,7 +469,8 @@ soc_dpaa = { ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false], ['RTE_MAX_LCORE', 16], ['RTE_MAX_NUMA_NODES', 1], - ['RTE_DMA_DPAA_ERRATA_ERR050757', true] + ['RTE_DMA_DPAA_ERRATA_ERR050757', true], + ['RTE_DMA_DPAA_ERRATA_ERR050265', true] ], 'numa': false } diff --git a/doc/guides/dmadevs/dpaa.rst b/doc/guides/dmadevs/dpaa.rst index 746919ec6b..8a7c0befc3 100644 --- a/doc/guides/dmadevs/dpaa.rst +++ b/doc/guides/dmadevs/dpaa.rst @@ -43,6 +43,7 @@ For builds using ``meson`` and ``ninja``, the driver will be built when the target platform is dpaa-based. No additional compilation steps are necessary. - ``RTE_DMA_DPAA_ERRATA_ERR050757`` - enable software workaround for Errata-A050757 +- ``RTE_DMA_DPAA_ERRATA_ERR050265`` - enable software workaround for Errata-A050265 Initialization -------------- diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c index dbc53b784f..6d8e9c8183 100644 --- a/drivers/dma/dpaa/dpaa_qdma.c +++ b/drivers/dma/dpaa/dpaa_qdma.c @@ -167,6 +167,9 @@ fsl_qdma_pre_comp_sd_desc(struct fsl_qdma_queue *queue) /* Descriptor Buffer */ sdf->srttype = FSL_QDMA_CMD_RWTTYPE; +#ifdef RTE_DMA_DPAA_ERRATA_ERR050265 + sdf->prefetch = 1; +#endif ddf->dwttype = FSL_QDMA_CMD_RWTTYPE; ddf->lwc = FSL_QDMA_CMD_LWC; @@ -707,6 +710,9 @@ fsl_qdma_enqueue_desc_single(struct fsl_qdma_queue *fsl_queue, #ifdef RTE_DMA_DPAA_ERRATA_ERR050757 sdf = &ft->df.sdf; sdf->srttype = FSL_QDMA_CMD_RWTTYPE; +#ifdef RTE_DMA_DPAA_ERRATA_ERR050265 + sdf->prefetch = 1; +#endif if (len > FSL_QDMA_CMD_SS_ERR050757_LEN) { sdf->ssen = 1; sdf->sss = FSL_QDMA_CMD_SS_ERR050757_LEN; @@ -820,6 +826,9 @@ fsl_qdma_enqueue_desc_sg(struct fsl_qdma_queue *fsl_queue) #ifdef RTE_DMA_DPAA_ERRATA_ERR050757 sdf = &ft->df.sdf; sdf->srttype = FSL_QDMA_CMD_RWTTYPE; +#ifdef RTE_DMA_DPAA_ERRATA_ERR050265 + sdf->prefetch = 1; +#endif if (total_len > FSL_QDMA_CMD_SS_ERR050757_LEN) { sdf->ssen = 1; sdf->sss = FSL_QDMA_CMD_SS_ERR050757_LEN; -- 2.25.1