From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6932345AE3; Tue, 8 Oct 2024 18:51:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15A0340DCA; Tue, 8 Oct 2024 18:50:31 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id C81C640A6C for ; Tue, 8 Oct 2024 18:50:29 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-71e15fe56c9so642549b3a.3 for ; Tue, 08 Oct 2024 09:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728406229; x=1729011029; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lsZ6RBIfnQMYKuWqU3a26d8fj/ilEXYbq/7ybSo6ZWM=; b=iD/zJliBe4JTZYdCr7gVJeSO3iLr7TctdyIBUDxlmiqXJWvxhBq/oB8lJsI6IG04fr egqMtKp8TdZ780QJAFQzEKkVIYyKY2FeYf6ibYngKh8+JlmGUCMB3N+776weLPmC7B82 PRXz9jdpO7eBXv47y+NSJTfwz5NZFWYl9LDKEbzGlBjblAhkDixWluDd5ua/z0nnk5pN qTLXxK91N23tBByyy0CkyFXs6QL3FDGTLo4PF+BMH6QR0WuD88ZIBS7YWO18e76d1mv4 xFMT+jPBkKn4ICola1f4l2z5QX/UYYzKiA6iOIVx0Es/0Spqy6O3nT9R0EqpmS20EmYD D51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728406229; x=1729011029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lsZ6RBIfnQMYKuWqU3a26d8fj/ilEXYbq/7ybSo6ZWM=; b=XRQEg7ScbV+7axDBmi9IP0DZgwd4j18C6acVKpNzMgqTWA/ruHh6z2lBigqKROK3BW mjjnP5YD9GdFgY8zRW7fnl5MGVEgevmrXf1kyw3PnUuaR5FaNlVOYDqCpun82MgsIAaS mluvCofjMt12KwuSCz0qUT5wp9+eD16oHaoTE8jUgNl/1K0bJ/5LQrTNKK16wuIM9V/1 lUe6bEximHDLaiPm+CrFRyYdEHDg4ldKT2W66HO2QbFjGi8sNK5ZUAp2Aj+iVuVkm7TW lzK7L5vwgQZnRWr1tyydHhFF9EWGeEzSAWC3eNtJqSu6Am3ShJ8MQFRSgQgIGSAkVnJc bdEg== X-Gm-Message-State: AOJu0YzWi2JIt+FtxDQbhunh8xJ6HgYB7JDN6K74Pwsld4tRexx/VgWG 5NoRT+/OqeixkDVuw0jjSl+DilnFeWn6ZipQ40vRXhBCns8Dn2bjo8rYyb6Eeli9Le8ttdbvVl1 655IWjg== X-Google-Smtp-Source: AGHT+IFMArKiq0gXzV7QI1WPLi3H/3bQfYalRHf2bWXJ7lXUJh5fG6vkKkL8RnU+o84amSMkC3zSIA== X-Received: by 2002:a05:6a00:3d0c:b0:71e:cf8:d6f2 with SMTP id d2e1a72fcca58-71e0cf8d8f3mr7847024b3a.8.1728406229033; Tue, 08 Oct 2024 09:50:29 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0ccc4b2sm6318441b3a.45.2024.10.08.09.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 09:50:28 -0700 (PDT) Date: Tue, 8 Oct 2024 09:50:27 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH v7 00/16] Fix allocation bugs and prevent future ones Message-ID: <20241008095027.715b2743@hermes.local> In-Reply-To: References: <20240927204742.546164-1-stephen@networkplumber.org> <20241002183918.161656-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Oct 2024 16:57:16 +0200 David Marchand wrote: > > > > It seems v7 lost the last patch that was introducing and using the > > annotations in rte_malloc. > > Was there an issue with this patch, or is it just a series submission issue? > > Btw, reading gcc documentation, it seems the check is only enabled > with -fanalyzer. > Can we add this in the CI? > > If we can't enable all of -fanalyzer checks, maybe go with a subset of > it, like -Wanalyzer-allocation-size > -Wanalyzer-mismatching-deallocation ? I didn't enable -fanalyzer in my build, and all these bugs showed up. Turning on full analyzer does give better and more through checking though.