From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E3F145AE6; Tue, 8 Oct 2024 20:18:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 700A0402BB; Tue, 8 Oct 2024 20:18:28 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 9411E40261 for ; Tue, 8 Oct 2024 20:18:26 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20b0b2528d8so67752665ad.2 for ; Tue, 08 Oct 2024 11:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728411505; x=1729016305; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5cfDya4yFY+LDngBrQmVJR0VU7qTdwuKaqg5JXqgsf0=; b=uAer/PHghiDGzsbT2P7tgW4gPXixKNfwO2JG6eXaCaS988svMxIKV9JE40dpVhA3jE nXPf1jg08paOqEBjZgLOVwpy2/m36QD4DXoZjQeCjZcnIGZv9eJ4343HdXttfdXR72ee ZthJvwL/p7PZ6Y+bp+I5hDT0hS8fQsBq8Dbk+zD2K3tDfzwnE/ghvWR7getVS1iuAT0Y pq/sorpmToIGOyj3qVQUTQwHSZG+P2Hh4G4f2XtyLP4SLdS1cH1q0Kpr7NpdOI08gelC 3HPBXFD5yqu6YjT202mle00z6Zb2j/XWvMq758s2T/oajAqoMENXxLrR9+OClINo2oho GFKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728411505; x=1729016305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5cfDya4yFY+LDngBrQmVJR0VU7qTdwuKaqg5JXqgsf0=; b=i6jP2eVgKq/NFr1AqNclPOznoeSFrQ7STOfEuAFPJ4jWM994EEK6FyHF3zICzR7UbV jiBU5L0wLptfa/52RhnFrN9kUbgP+2PHR30IiLUaR51pnCEurAFO+w/wT9i/c0ZeF/r4 Mosy8adKVo8A/WCE/RVl7zdjwWpUfGTCh6pLHHPqxe9wN9Nblbn3SGx9ewnxXvturyVQ 4TtFMrK8MFbWbrd9TCvHJSK/7Q7YsE2Puj8mr87OFIUCEaczPHjm4XSV5iTSjijEu5cH ZEzvdE5R92tZLyRfzx8KkIVO6x/tu2Mj2ZmRdI1oUWwfRvSKTJdyy9vfMfNoIgLn4kik e/Yg== X-Gm-Message-State: AOJu0Yyjd9lFswrNYqGJxg7W+Cq03ewq6pPMHCIGNBWTsAhIaS5F7pIe HCIj18RvTYnfqTvIglMGIJiMU2YVyFidi5/jLLE8wGdTX5CtfzZ+bINMwzi6upI= X-Google-Smtp-Source: AGHT+IHZYO/5Uc7u5QNJhjloy08CeyOBi0Uf2Ddy13pBNCrAq8ZfbeUWU7qAje+8H9lRZAac1RmIbA== X-Received: by 2002:a17:902:ea0a:b0:20b:8bd0:7395 with SMTP id d9443c01a7336-20bff037061mr286455795ad.46.1728411505610; Tue, 08 Oct 2024 11:18:25 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138af760sm58166555ad.30.2024.10.08.11.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 11:18:25 -0700 (PDT) Date: Tue, 8 Oct 2024 11:18:23 -0700 From: Stephen Hemminger To: Vladimir Medvedkin Cc: dev@dpdk.org, rjarry@redhat.com, ruifeng.wang@arm.com, honnappa.nagarahalli@arm.com, david.marchand@redhat.com Subject: Re: [PATCH v2 1/2] fib: implement RCU rule reclamation Message-ID: <20241008111823.1d98a669@hermes.local> In-Reply-To: <20241008175524.450829-1-vladimir.medvedkin@intel.com> References: <20240906170907.1325808-1-vladimir.medvedkin@intel.com> <20241008175524.450829-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 17:55:23 +0000 Vladimir Medvedkin wrote: > @@ -569,7 +600,60 @@ dir24_8_free(void *p) > { > struct dir24_8_tbl *dp = (struct dir24_8_tbl *)p; > > + if (dp->dq != NULL) > + rte_rcu_qsbr_dq_delete(dp->dq); > + Side note: rte_rcu_qsbr_dq_delete should be changed to accept NULL as nop. Like all the other free routines