From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 907EF45AE2; Tue, 8 Oct 2024 17:44:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A727140E26; Tue, 8 Oct 2024 17:43:24 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 022B040A84 for ; Tue, 8 Oct 2024 17:43:18 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71de776bc69so2854466b3a.1 for ; Tue, 08 Oct 2024 08:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728402198; x=1729006998; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PmRTbddZLG2JxQ2OFMT3a37iU/8U3GJd/GKLMFfTKa0=; b=PNyPsUTNLy33Pr5JJt+jmHMNDddvXNYoZF2jNY9UCSXc6ZN/nJpEOxf1oDJs1gWVKD HmgHfpKVOVm41ScIbEeWXMjmRDKn1X4hAkGe9+7qnwfrC4+kBt1jssDGxxhAMcysZlHH o7gRsfPh2ltdM8weHgKXmRE7M9w4ctJLuNtUkKM+MuA0spHb557FBOJZE+E+EqqC5oH9 +RYGqF6F0S1I/DYMw38Vak0PnqQBwpd7cSchn0VL8vvF8BlHNTOuAliyJ3oUzFiH4jr3 dOLEk3JmVHvrjYDphl7k16gYkcL6BPg7YRP83IcIq47ZHLs2keb7J73lDsp3SkwldTda FDkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728402198; x=1729006998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PmRTbddZLG2JxQ2OFMT3a37iU/8U3GJd/GKLMFfTKa0=; b=P1bI+ik6eNGOw39jU9ANh+DXiuvW3R29Fxff5KrhdIaLNEoMGbw1MrB+8Uxyo51G39 yElD2W9bpulscASAHUJpPIIv2ZP7J1dzwsnJG5rm1v1k4Q3wf/MxItdbORCGcE19XVR4 7boFZLq8fSOAFiZSxzCKN3VjaUBVvng7cmxN64RdfYEU7u+t6KFfw+N0n30HGmjSTp10 WLzy9koyMKQv8Gdp2SdAro5uZVJU7UPv4TFIgwxKAwdAIqfEVlNXnAfTeKOSNRKTDBcK 6JsvI8z5+GY8flghNldO0otp8dxSGNoBRvcdAmW9MGU+ARTzICm11umRUlK+XDAuisLb YmZg== X-Gm-Message-State: AOJu0YwtSuabfIsGlU+euSrW6xlcQNgubQT9wfUoE35ldmJdXGUZZZMz Ym2u648oMjsqj/POI7j3uUijBOAKOc4mqnfHGd5tbWi/vwMeJgAGvh+XIkhasY4jUfAafOF3Kse PtsPM4g== X-Google-Smtp-Source: AGHT+IHSSzEu3xaYNcY31mrBFYNcEvqDQ/GZP3i4nxB9qbTQpZint+/UR9Vbm5ARV8w/OP/DMUJtog== X-Received: by 2002:a05:6a00:4885:b0:71d:eb7d:20ed with SMTP id d2e1a72fcca58-71deb7d252cmr17644617b3a.12.1728402198235; Tue, 08 Oct 2024 08:43:18 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0ccf01dsm6293527b3a.70.2024.10.08.08.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 08:43:17 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Konstantin Ananyev , Ray Kinsella Subject: [PATCH v8 07/17] bpf: fix free mismatch if convert fails Date: Tue, 8 Oct 2024 08:41:37 -0700 Message-ID: <20241008154301.66192-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241008154301.66192-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241008154301.66192-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If conversion of cBF to eBPF fails then an object allocated with rte_malloc() would be passed to free(). [908/3201] Compiling C object lib/librte_bpf.a.p/bpf_bpf_convert.c.o ../lib/bpf/bpf_convert.c: In function ‘rte_bpf_convert’: ../lib/bpf/bpf_convert.c:559:17: warning: ‘free’ called on pointer returned from a mismatched allocation function [-Wmismatched-dealloc] 559 | free(prm); | ^~~~~~~~~ ../lib/bpf/bpf_convert.c:545:15: note: returned from ‘rte_zmalloc’ 545 | prm = rte_zmalloc("bpf_filter", | ^~~~~~~~~~~~~~~~~~~~~~~~~ 546 | sizeof(*prm) + ebpf_len * sizeof(*ebpf), 0); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bpf/bpf_convert.c b/lib/bpf/bpf_convert.c index d7ff2b4325..e7e298c9cb 100644 --- a/lib/bpf/bpf_convert.c +++ b/lib/bpf/bpf_convert.c @@ -556,7 +556,7 @@ rte_bpf_convert(const struct bpf_program *prog) ret = bpf_convert_filter(prog->bf_insns, prog->bf_len, ebpf, &ebpf_len); if (ret < 0) { RTE_BPF_LOG_LINE(ERR, "%s: cannot convert cBPF to eBPF", __func__); - free(prm); + rte_free(prm); rte_errno = -ret; return NULL; } -- 2.45.2