From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 510DF45AE3; Tue, 8 Oct 2024 18:02:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 119CC40DDE; Tue, 8 Oct 2024 18:02:28 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 7B53940A4B for ; Tue, 8 Oct 2024 18:02:23 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71e053cf1f3so1943178b3a.2 for ; Tue, 08 Oct 2024 09:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728403342; x=1729008142; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TcReQYk1ib37cHsXQx3KQCjyqhMudtVTIIZEQsvU+RA=; b=1oM7i1Gm7M7Tzufi8BAlzOiZraq0N6P66xyo0sn+JL7huUuk50xuhZDgl4ZCvTDv14 EVBBNiyHBsG/qYvhXqKyjK1I90grR7Oa03EJr0rR2Y6HKMpm8MJT/k+IB5rlRQWKyPM3 UCsBYVqPkE2cqGMYmyz1iSdpIJwg4nlrL847N9DpV9RZK5AcloXGJpQzVP1K5RsH8rI7 hFaI4FlcjQh/brhNrJ13o0sdFZtMZTrQ/OqXJf7EpmlURYxgXuFPXN+JJ5Thm+MK/cyY b4csJP27pQ6sWtTLReBNPkQOHk3KoC5XrVnIctAvBXm8Tf+E6GtbjsWX7YGJ7wvAqT0/ Q0oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728403342; x=1729008142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TcReQYk1ib37cHsXQx3KQCjyqhMudtVTIIZEQsvU+RA=; b=O+98H5dpv2mZIigpxpC3hD4C/GZubDWUhHhbTjSJrRSVTlsecEuNy34SyvSyHt9Ihy Y/9Lt9tntVjHga8dxYgogTpkaD0zFC6E9SrylLnUqJaF5tEnCWBuPopKWmXxtN56bRzp VKn8KUasfQrKWmVetjhyMyllzC/U23niEaXKlQNgzIzd0wGpuZf0fHbEl2hNQ0gatFdT YHQUwX5cm4ECKpclFfC7hqN0LXC6CDofiNsedgp3QxDIhB70A5W4uk3T9VBhlm9IRThp aCNjChqAupxSlwQqo5NBdLkMrgCersS8G5lx7dCUzhFk4sMDBeIIWk4koJmSmyIVrPPl v8wA== X-Gm-Message-State: AOJu0YwaCFWMUBM94cE8PgpUO/g9/gd1DD+7ThsHmgsgFII5rjvFxNRZ g33wyIkh1M6caGkVV49R/aRfdbns1BG7yLFXnGobDQ78vilQOwk9es/uhX0x5AmnWYn9xBJQGoG +RcvVfg== X-Google-Smtp-Source: AGHT+IHJetVvqm/Mv6wnecKTmxWRC+OC4MOuPCAr4+754VqYIVNuUAr9U9YHSropypzGECVaeqZKuA== X-Received: by 2002:a05:6a21:3983:b0:1d6:2378:fd11 with SMTP id adf61e73a8af0-1d6df7286fbmr4770772637.0.1728403342658; Tue, 08 Oct 2024 09:02:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f6c3758esm7028267a12.74.2024.10.08.09.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 09:02:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , jerin.jacob@caviumnetworks.com Subject: [RFC 4/5] net/octeontx: fix handling of xstats_get Date: Tue, 8 Oct 2024 08:59:58 -0700 Message-ID: <20241008160209.68000-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241008160209.68000-1-stephen@networkplumber.org> References: <20241008160209.68000-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The xstats_get function in this driver did not act the same as other drivers when queried. The correct check is to look at the requested number of stats and compare it to the available stats and if the request is too small, return the correct size. Fixes: 5538990924f2 ("net/octeontx: add basic stats support") Cc: jerin.jacob@caviumnetworks.com Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 3b8d717797..51093cc815 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -1016,6 +1016,9 @@ octeontx_dev_xstats_get(struct rte_eth_dev *dev, struct octeontx_nic *nic = octeontx_pmd_priv(dev); PMD_INIT_FUNC_TRACE(); + if (n < NUM_BGX_XSTAT) + return NUM_BGX_XSTAT; + return octeontx_port_xstats(nic, xstats, n); } -- 2.45.2