From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CAE645AE3; Tue, 8 Oct 2024 18:50:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18FAE410F6; Tue, 8 Oct 2024 18:49:17 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 6BE4840E4C for ; Tue, 8 Oct 2024 18:49:06 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20b58f2e1f4so39878745ad.2 for ; Tue, 08 Oct 2024 09:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728406145; x=1729010945; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jufL1Xx6Vcy1vUxL0AdrUCYAgWJlHW3xe3BF1P60Ueg=; b=nseGiUjOM7EWXwHI/EmEXglvcKZufNYem7yRNL6lbzq3hb0MrzD8VsQ/Z70rgKSVPP EW4+WA/CG1bAVSTs7tTxNGWFpftxJFoqxGluD+tDfiWCRVpB1ypQ750g5Wb4pgCdccFH OB3Ip2NkiD2FFBxp/p9b9O5sppq7zs7YdvtSRkjbpdWVGf4QE+x+ceQIWlr1vySSLsXS BEQJ/QjZ7sN1hq5yb4jvnfPa22xFEhJmcpWF3edmFGkvtnntOSlW1uPu+ftmIQkqwIIe fw2kDZdC1ndye8cwv2CZ2wLT9W30uT3Zn4s29VWmsldRyQTrnTt53a2doGTU9VXzIPkJ YxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728406145; x=1729010945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jufL1Xx6Vcy1vUxL0AdrUCYAgWJlHW3xe3BF1P60Ueg=; b=bX2ZqDRo13aLgmiSwzylKpGXKpQOrM8kd/GQdpfhsYD60dF2m7316vbV91iRgo8it1 bGf4lGwdygkoVKhZr4MQlm35Ng1t8RhQVcxVKESnAXy4H6hs9AWQ7Bo2x7wG8yoeXDMl cYFeFyS7ZQ6uf3CkUjKN5AImHqWHNC6/tE2iNnUq9U8S1KqwpbBzXmtq0kpeahM5kTPe RGl/n/cl2JqJDEQqyrWzev6Wl6fN+GUqBKdE2zpzYTI2FlNrti7IOBAxhuRnaHwBrJ4p sKM1mUGGXN0RgiJrBBauvjYToyk5wFKLZ9VtWkBtbtxQfeexe6mnTmgrdVjgQOeBAi6/ AUZQ== X-Gm-Message-State: AOJu0YwqF8wEwdlRTcff+i03DdNhiDK7rz/VTKCUOzNe5umRGh2xGHdw /5WPMGwBzzc77lTVQNvH5gIun2CAAn2SxVro5DSyglh7ZbF6rP5QriTv0r1x3OogRqPK0dO7vSH pZoIGvw== X-Google-Smtp-Source: AGHT+IH1snEXIT5FTJwl7c5FDpY1k3JoCvT6Vvw2Be1WScerGXroH84WRoaZyQHOn3eczXPFnhvqgA== X-Received: by 2002:a17:902:db03:b0:20b:530f:e202 with SMTP id d9443c01a7336-20bfe023d6dmr239113625ad.1.1728406145601; Tue, 08 Oct 2024 09:49:05 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c54056bd9sm13832965ad.85.2024.10.08.09.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 09:49:05 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , hkalra@marvell.com, stable@dpdk.org, Rosen Xu , Hyong Youb Kim , David Marchand Subject: [PATCH v9 14/17] drivers/ifpga: fix free function mismatch Date: Tue, 8 Oct 2024 09:47:18 -0700 Message-ID: <20241008164842.139045-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241008164842.139045-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241008164842.139045-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The raw ifpga driver redefines malloc to be opae_malloc and free to be opae_free; which is a bad idea. This leads to case where interrupt efd array is allocated with calloc() and then passed to rte_free. The workaround is to allocate the array with rte_calloc() instead. Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: hkalra@marvell.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 113a22b0a7..5b9b596435 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -1499,7 +1499,7 @@ ifpga_register_msix_irq(struct ifpga_rawdev *dev, int port_id, nb_intr = rte_intr_nb_intr_get(*intr_handle); - intr_efds = calloc(nb_intr, sizeof(int)); + intr_efds = rte_calloc("ifpga_efds", nb_intr, sizeof(int), 0); if (!intr_efds) return -ENOMEM; @@ -1508,7 +1508,7 @@ ifpga_register_msix_irq(struct ifpga_rawdev *dev, int port_id, ret = opae_acc_set_irq(acc, vec_start, count, intr_efds); if (ret) { - free(intr_efds); + rte_free(intr_efds); return -EINVAL; } } @@ -1517,13 +1517,13 @@ ifpga_register_msix_irq(struct ifpga_rawdev *dev, int port_id, ret = rte_intr_callback_register(*intr_handle, handler, (void *)arg); if (ret) { - free(intr_efds); + rte_free(intr_efds); return -EINVAL; } IFPGA_RAWDEV_PMD_INFO("success register %s interrupt", name); - free(intr_efds); + rte_free(intr_efds); return 0; } -- 2.45.2