From: Stephen Hemminger <stephen@networkplumber.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, techboard@dpdk.org, david.marchand@redhat.com,
thomas@monjalon.net, mb@smartsharesystems.com,
ferruh.yigit@amd.com
Subject: Re: [PATCH v1 1/3] uapi: introduce kernel uAPI headers import
Date: Wed, 9 Oct 2024 07:50:04 -0700 [thread overview]
Message-ID: <20241009075004.513224f2@hermes.local> (raw)
In-Reply-To: <20241009085805.2638314-2-maxime.coquelin@redhat.com>
On Wed, 9 Oct 2024 10:58:03 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> +fixup_includes()
> +{
> + local path=$1
> +
> + sed -i -E -e '
> + s/([[:space:](])(__user|__force|__iomem)[[:space:]]/\1/g
> + s/__attribute_const__([[:space:]]|$)/\1/g
> + s@^#include <linux/compiler(|_types).h>@@
> + s/(^|[^a-zA-Z0-9])__packed([^a-zA-Z0-9_]|$)/\1__attribute__((packed))\2/g
> + s/(^|[[:space:](])(inline|asm|volatile)([[:space:](]|$)/\1__\2__\3/g
> + s@#(ifndef|define|endif[[:space:]]*/[*])[[:space:]]*_UAPI@#\1 @
> + ' $path
> +
Rather than copy-pasting headers_install.sh, could you use it directly?
The copy/paste from GPL-2.0 concerns me.
And the potential upstream change as well.
next prev parent reply other threads:[~2024-10-09 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:58 [PATCH v1 0/3] Import Kernel uAPI header files Maxime Coquelin
2024-10-09 8:58 ` [PATCH v1 1/3] uapi: introduce kernel uAPI headers import Maxime Coquelin
2024-10-09 14:50 ` Stephen Hemminger [this message]
2024-10-14 12:14 ` Maxime Coquelin
2024-10-09 8:58 ` [PATCH v1 2/3] uapi: import VDUSE header Maxime Coquelin
2024-10-09 8:58 ` [PATCH v1 3/3] vduse: use imported VDUSE uAPI header Maxime Coquelin
2024-10-15 17:10 ` Stephen Hemminger
2024-10-09 10:29 ` [PATCH v1 0/3] Import Kernel uAPI header files Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009075004.513224f2@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).