From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] doc: update TAP device features
Date: Wed, 9 Oct 2024 09:53:22 -0700 [thread overview]
Message-ID: <20241009095322.3bf142bf@hermes.local> (raw)
In-Reply-To: <406981a2-32fc-46a5-abac-5f20f5c8678d@amd.com>
On Sun, 6 Oct 2024 21:36:31 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 10/4/2024 9:48 PM, Stephen Hemminger wrote:
> > On Fri, 4 Oct 2024 02:48:21 +0100
> > Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> >
> >>> +Stats per queue = Y
> >>>
> >>
> >> This feature name is misleading,
> >> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is
> >> indeed for covering limitation for some drivers.
> >> Tap does support getting stats per queue, but doesn't support above
> >> documented feature.
> >
> > Just looked and the current state of the feature matrix is not correct
> > for this part of the table. Although the feature intro says it is
> > stats per queue mapping, that is not what other drivers are doing.
> >
> > Only these drivers have queue_stats_mapping_set:
> > cnxk, enic, igc, ixgbe, txgbe, virtio
> >
> > These drivers claim to have 'Stats per queue' but do not have stats mapping:
> > af_xdp, ark, atlantic, avp, bnxt, cxgbe, failsafe, fm10, hinic, hns3,
> > ionic, mlx4, mlx5, netvsc, nfb, nfp, ngbe, qede, thunderx, vmxnet3
> >
> > So the overwhelming practice is that the features.rst description is wrong!
> >
>
> You are right.
>
> What about update the 'features.rst', and extend the definition of
> 'Stats per queue' mapping + queue stats in basic stats or extended stats.
> This will be make name of the feature more intuitive.
Like this?
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index cd0115ffb3..a351d7b3b5 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -727,8 +727,6 @@ Basic stats
Support basic statistics such as: ipackets, opackets, ibytes, obytes,
imissed, ierrors, oerrors, rx_nombuf.
-And per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors.
-
These apply to all drivers.
* **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``.
@@ -754,7 +752,8 @@ Supports Extended Statistics, changes from driver to driver.
Stats per queue
---------------
-Supports configuring per-queue stat counter mapping.
+Supports per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors.
+May also support configuring per-queue stat counter mapping.
* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``.
* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``,
next prev parent reply other threads:[~2024-10-09 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:42 Stephen Hemminger
2024-10-04 1:48 ` Ferruh Yigit
2024-10-04 2:26 ` Stephen Hemminger
2024-10-04 4:09 ` Ferruh Yigit
2024-10-04 7:54 ` Bruce Richardson
2024-10-04 15:24 ` Stephen Hemminger
2024-10-04 17:26 ` Ferruh Yigit
2024-10-04 20:40 ` Per queue stats Stephen Hemminger
2024-10-06 20:51 ` Ferruh Yigit
2024-10-08 9:58 ` Morten Brørup
2024-10-08 10:04 ` Bruce Richardson
2024-10-04 20:48 ` [PATCH] doc: update TAP device features Stephen Hemminger
2024-10-06 20:36 ` Ferruh Yigit
2024-10-09 16:53 ` Stephen Hemminger [this message]
2024-10-09 23:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009095322.3bf142bf@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).