From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AFD245AF4; Wed, 9 Oct 2024 18:53:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2507A40698; Wed, 9 Oct 2024 18:53:27 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 7A2AF40697 for ; Wed, 9 Oct 2024 18:53:25 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e0a060f6e8so63313a91.1 for ; Wed, 09 Oct 2024 09:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728492804; x=1729097604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YJD3KFvpVbquA5xDJghIwHoJUlfiJQreZlcnP8LeZxs=; b=jy36UXbP/N6h8AA0gnboQ3mQ8uMFegbmuJnUmWNnFdvsRQg/VPP15BpxvULcyeRSqT T17UT7/yKw6lICiQOuRyvn/Y6rQorgkdIiMmX3BfTqxFV9aPVoMwdRZjcxhaqHJPLKi8 BV/iDjZcQ00LwBjZku/euTpecFe1PaRlaKXtjHx4daxvOgcw9W7IrJeDoI7hRXw4D6gK qTvfL6ZS3BI6XQuzNKjP4cW9CHhnQiFxvJzzPE1tM2eF8Ql15TWlPRW3njlzmAu1zYod UA955shzuFRNOZVF5o8PXSMpavud7XJL2EdC/bX31x3Uns0Ch6QK3c97qsq9AgCD+tqX bMIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728492804; x=1729097604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJD3KFvpVbquA5xDJghIwHoJUlfiJQreZlcnP8LeZxs=; b=sjERDcdhbNKKXa61itCHiUogRCAcD+5+Nq8SYd1JZ5WqNRCkZflvNzvx5s0WM0Jyu0 zDaDl1HAoUnw1xPtfCZT1K8VbzlTvofjxb/JNAiKU4jHoAlr+GZ9MN433Z9oXbZX2Ee8 X3IF14rGdEJBjYkgZhicd0opMHhamWf9eUcsZNXwZWpXxO/nwhBeMD4nXmdi9dxK8sB+ WIRWtMW5WJKkWZT59z8+h3wJcShLBZoAbNq0xLRDGJ9TMlQzLk0k0MTjY4AScPUUZFsH InrDq2pElWFDI3B3BPKbAFOIbJjdK2k6As1Gy6b4Wz5dsFln1JaKP3gCVtoKWwT6dx6+ UPgQ== X-Gm-Message-State: AOJu0YyBriKhTw+tA1YfL3LTv68IHICa5D6FvOUbU7gu2h34ODdrBB7W fv5YgneDI4OyeIWovgn4cwOPeggxYxS/j/mBum00MixqcdTDJcXDoQE6Qr/WsKc= X-Google-Smtp-Source: AGHT+IEGSB+C8ghC9rtIgPpGWS5BJwPZ9cExX7/gMXxN3wnQvafKi9V2TrAoVlRAdEcRUzUSB3/vsg== X-Received: by 2002:a17:90a:8a82:b0:2e2:9e1c:4461 with SMTP id 98e67ed59e1d1-2e2c63aaa57mr767806a91.25.1728492804375; Wed, 09 Oct 2024 09:53:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2a5aaae3fsm1923871a91.43.2024.10.09.09.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 09:53:24 -0700 (PDT) Date: Wed, 9 Oct 2024 09:53:22 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH] doc: update TAP device features Message-ID: <20241009095322.3bf142bf@hermes.local> In-Reply-To: <406981a2-32fc-46a5-abac-5f20f5c8678d@amd.com> References: <20240904154206.13438-1-stephen@networkplumber.org> <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> <20241004134842.0fd518ab@hermes.local> <406981a2-32fc-46a5-abac-5f20f5c8678d@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 6 Oct 2024 21:36:31 +0100 Ferruh Yigit wrote: > On 10/4/2024 9:48 PM, Stephen Hemminger wrote: > > On Fri, 4 Oct 2024 02:48:21 +0100 > > Ferruh Yigit wrote: > > > >>> +Stats per queue = Y > >>> > >> > >> This feature name is misleading, > >> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is > >> indeed for covering limitation for some drivers. > >> Tap does support getting stats per queue, but doesn't support above > >> documented feature. > > > > Just looked and the current state of the feature matrix is not correct > > for this part of the table. Although the feature intro says it is > > stats per queue mapping, that is not what other drivers are doing. > > > > Only these drivers have queue_stats_mapping_set: > > cnxk, enic, igc, ixgbe, txgbe, virtio > > > > These drivers claim to have 'Stats per queue' but do not have stats mapping: > > af_xdp, ark, atlantic, avp, bnxt, cxgbe, failsafe, fm10, hinic, hns3, > > ionic, mlx4, mlx5, netvsc, nfb, nfp, ngbe, qede, thunderx, vmxnet3 > > > > So the overwhelming practice is that the features.rst description is wrong! > > > > You are right. > > What about update the 'features.rst', and extend the definition of > 'Stats per queue' mapping + queue stats in basic stats or extended stats. > This will be make name of the feature more intuitive. Like this? diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index cd0115ffb3..a351d7b3b5 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -727,8 +727,6 @@ Basic stats Support basic statistics such as: ipackets, opackets, ibytes, obytes, imissed, ierrors, oerrors, rx_nombuf. -And per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. - These apply to all drivers. * **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``. @@ -754,7 +752,8 @@ Supports Extended Statistics, changes from driver to driver. Stats per queue --------------- -Supports configuring per-queue stat counter mapping. +Supports per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. +May also support configuring per-queue stat counter mapping. * **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. * **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``,