From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95DAD45AF4; Wed, 9 Oct 2024 19:50:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 826D642DDE; Wed, 9 Oct 2024 19:50:24 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 213D0427C6 for ; Wed, 9 Oct 2024 19:50:23 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2e18856feb4so108479a91.3 for ; Wed, 09 Oct 2024 10:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728496222; x=1729101022; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tbOhY7CMTYQDOezU07JUrXSNiaaZty2sfLkBsYRYxxE=; b=GEDg8O6hVgCH4QU07kX3l48wFZr9QvVcFd3JxCj+4Lb3qOibdYX61z8blKO77rdIE4 5Jni7miWNt+Ob3HLfLDUEEJ5I6h5V7MEFaRc9wOpSgHGuF5QgvO7dPPsMd/MWAUmNrcy /vCIEiUHWqXIVp8sX+Fs4bZw/kpuaOWMgakE+Tqabp7erFgzkvUf1xHdBF8Xw4vGDs4/ xHTva10e7m/YlfmSLDRBONEODWEtFS0wJa2JztK1LxnfSyA9WEtbDlOdldwQMGR/2as/ 8UlrcVuOXFfDRsruREj5WGNzbOl+1NeS6YzYgG3RHzlrdrJATb1iqkPsvRtt0WyF80z0 AkrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728496222; x=1729101022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tbOhY7CMTYQDOezU07JUrXSNiaaZty2sfLkBsYRYxxE=; b=wC+DTmElpxB+RDql3zR2oEb/uJRL40B5lH3t/Hbg8CtlwQrZpBeGhpeIe9LmNa1DAK vxA9t7RI+hWzednItuVUU2FptCrcw8jRgdZOP4EV0euIClWQqK5wwF5RoZNt7MlJn5/l v319oNMFtZlB5SfZU0Ux6+fa4hwWLnsgU/z/i3VfhFXlUDVtSzVbMvA4SdayzvMm9I1T +7V3uGzieZvshAjbASdurdhFc1cPkIRN4VcTQ42IZ2VJSHN2nGYAKvykT2STBooxdeU/ Nb9UvtzbBm1LKLLnaSmJxoZNaeju8DZnvZgJWr3pqyb15HNeXIgxSYKuU5Yx5DYy6nKb Z+Ig== X-Gm-Message-State: AOJu0Ywcn+jKuNqa0dz+GMo3gxR8zuwPVRQ9GUK5oxDfrMsBcBNwpWEu P0CpTILXQnH1FmAjx4qLs9NLSxkfp2qxA/80l1IaRcf+ORzhs11tAdX5ssutE6YqNWkpTMUA8tm 2 X-Google-Smtp-Source: AGHT+IH6Xhe8C3dL8ogAFP5RRGW8/MSzdiOCJaHL6MyPoqLwiPCojf33XtYQ5+AQXxf/GzbEyABDGw== X-Received: by 2002:a17:90a:fd87:b0:2e2:b46f:d92c with SMTP id 98e67ed59e1d1-2e2b46fde2bmr2580745a91.14.1728496222324; Wed, 09 Oct 2024 10:50:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2a5aabbb1sm1980603a91.35.2024.10.09.10.50.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 10:50:22 -0700 (PDT) Date: Wed, 9 Oct 2024 10:44:57 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH 1/5] net/ice: detect stopping a flow-director queue twice Message-ID: <20241009104457.010b8a90@hermes.local> In-Reply-To: <20241009170822.344716-2-bruce.richardson@intel.com> References: <20241009170822.344716-1-bruce.richardson@intel.com> <20241009170822.344716-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 9 Oct 2024 18:08:18 +0100 Bruce Richardson wrote: > If the flow-director queue is stopped at some point during the running > of an application, the shutdown procedure for the port issues an error > as it tries to stop the queue a second time, and fails to do so. We can > eliminate this error by setting the tail-register pointer to NULL on > stop, and checking for that condition in subsequent stop calls. Since > the register pointer is set on start, any restarting of the queue will > allow a stop call to progress as normal. > > Signed-off-by: Bruce Richardson Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Acked-by: Stephen Hemminger