From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 243EC45AF4; Wed, 9 Oct 2024 19:50:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE5F442E1C; Wed, 9 Oct 2024 19:50:30 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id B6A6C42E0B for ; Wed, 9 Oct 2024 19:50:29 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7db1f13b14aso28515a12.1 for ; Wed, 09 Oct 2024 10:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728496229; x=1729101029; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vg8527JF/4Di3PBChDwrtSDPMhAmzax8NbRxHIvOSFk=; b=BN9hvh35aUhLe8k7c1ooiUCJAxit+4DeMRu25z+YIXoWEQ1+XXI4S7V6b4frN8Onqt PoOE+LYciZ0meZ+Hifabk78k49AvC9gZf57s/cHC1QZxlrlAlWUvgDpw7vCTVYDbTisf X33WNfwN4XnWSx39MJriwpYQFJ6HeRV8nI8mHntA8F6SvvOIUtHGNnIzsl7Y6SJN6Oim Egi9/bYRyP4sgjqNA3KDpxRiSVlgsYR5OoXKJLI7f0WPti/B+ybMzQwAYh0walcKNAmR 4EJs7YsYkZYSuDxPjwt85ubQv03b+6YwR41pn5wuSTesP0uLrCpK77hw2GdsCvhPngxL tArw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728496229; x=1729101029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vg8527JF/4Di3PBChDwrtSDPMhAmzax8NbRxHIvOSFk=; b=bUGGs1I2Fx+IDceBG+hVkQ9gYSLaajL3sJpPBWyAyMd2uxItXtvOdqRZOveSvOedOh jdJqTHj6RzJj/WZk9SaPXmc0W+EZMU0ymXaFaNq7ikNDZPIwBCb/RVTgF+p23qNTneqG XzKYVNR1EA392rV9KDQUOjSNHYoslUL7upK3y1xVau+viXsHboUmOLiljQyxiMM+BuQE AUhxJ/5SzQkE5Af7RbD4wOC+pvhUCdm1ZDXqWIBpIIrztlQf62KansE23hfjzLSm+P49 rnVp/FV2CHqes8Z5L8/HpoLMu9VReoSdnYUlseic9UzzBYLmXT9qh8/hTN08eV2twrYF ywyw== X-Gm-Message-State: AOJu0YyX/wcHoBcw2jfzdLhLygZwP12rKYsNwebW1N69di+xfbV+3KkU Pk1p85vxlivN71cRVEW7L2lM1Z+48CCGJRJ+1ceXCMo9R+ny8wmGPMD3+zNsChMqikmcsNZ/zua c X-Google-Smtp-Source: AGHT+IHIvwEl0alDESxUaesqUlKIuvK/8e/bEPsRhbce/2LQpypVrzIuMmzv7GKywWgkTfSW2HZlVw== X-Received: by 2002:a17:90a:df86:b0:2e2:bb02:466d with SMTP id 98e67ed59e1d1-2e2bb024797mr2218346a91.33.1728496228908; Wed, 09 Oct 2024 10:50:28 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2a5aabbb1sm1980603a91.35.2024.10.09.10.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 10:50:28 -0700 (PDT) Date: Wed, 9 Oct 2024 10:45:43 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH 2/5] net/ice: improve Tx scheduler graph output Message-ID: <20241009104543.026ddd29@hermes.local> In-Reply-To: <20241009170822.344716-3-bruce.richardson@intel.com> References: <20241009170822.344716-1-bruce.richardson@intel.com> <20241009170822.344716-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 9 Oct 2024 18:08:19 +0100 Bruce Richardson wrote: > The function to dump the TX scheduler topology only adds to the chart > nodes connected to TX queues or for the flow director VSI. Change the > function to work recursively from the root node and thereby include all > scheduler nodes, whether in use or not, in the dump. > > Also, improve the output of the Tx scheduler graphing function: > > * Add VSI details to each node in graph > * When number of children is >16, skip middle nodes to reduce size of > the graph, otherwise dot output is unviewable for large hierarchies > * For VSIs other than zero, use dot's clustering method to put those > VSIs into subgraphs with borders > * For leaf nodes, display queue numbers for the any nodes assigned to > ethdev NIC Tx queues > > Signed-off-by: Bruce Richardson Fixes: ab4eaf9a8a31 ("net/ice: dump Tx scheduling tree") Acked-by: Stephen Hemminger