From: Stephen Hemminger <stephen@networkplumber.org>
To: Euan Bourke <euan.bourke@intel.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Bruce Richardson <bruce.richardson@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>
Subject: Re: [PATCH v4 2/2] ip_frag: updated name for IP frag define
Date: Wed, 9 Oct 2024 11:38:27 -0700 [thread overview]
Message-ID: <20241009113827.79827340@hermes.local> (raw)
In-Reply-To: <20240108113614.3860138-2-euan.bourke@intel.com>
On Mon, 8 Jan 2024 11:36:14 +0000
Euan Bourke <euan.bourke@intel.com> wrote:
> diff --git a/config/rte_config.h b/config/rte_config.h
> index da265d7dd2..e2fa2a58fa 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -85,7 +85,7 @@
> #define RTE_RAWDEV_MAX_DEVS 64
>
> /* ip_fragmentation defines */
> -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
> +#define RTE_IP_FRAG_MAX_FRAG 8
> // RTE_LIBRTE_IP_FRAG_TBL_STAT is not set
>
Any change to a visible define should be documented as an API change
in the release notes.
Also if changing the name for MAX_FRAG shouldn't the name
for the statistics be changed as well as in: RTE_IP_FRAG_TBL_STAT?
prev parent reply other threads:[~2024-10-09 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <https://inbox.dpdk.org/dev/20231219151754.3285058-1-euan.bourke@intel.com/>
2023-12-21 11:32 ` [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments Euan Bourke
2023-12-21 11:32 ` [PATCH v2 2/2] ip_frag: updated name for IP frag define Euan Bourke
2023-12-21 11:39 ` [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments David Marchand
2023-12-21 11:41 ` Thomas Monjalon
2023-12-21 13:46 ` Bourke, Euan
2023-12-21 17:41 ` [PATCH v3 " Euan Bourke
2023-12-21 17:41 ` [PATCH v3 2/2] ip_frag: updated name for IP frag max frag define Euan Bourke
2023-12-22 9:08 ` Bruce Richardson
2024-01-08 11:36 ` [PATCH v4 1/2] doc: updated incorrect value for IP frag max fragments Euan Bourke
2024-01-08 11:36 ` [PATCH v4 2/2] ip_frag: updated name for IP frag define Euan Bourke
2024-10-09 18:38 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009113827.79827340@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=euan.bourke@intel.com \
--cc=gakhil@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).