From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AED6945AF5; Wed, 9 Oct 2024 20:38:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8339C4025D; Wed, 9 Oct 2024 20:38:32 +0200 (CEST) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id 769054014F for ; Wed, 9 Oct 2024 20:38:30 +0200 (CEST) Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3a39cabb9faso658395ab.3 for ; Wed, 09 Oct 2024 11:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728499110; x=1729103910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MZLfLs2LKcQSTAYZCu+WF4XZszipB5wtHYPuliSvlnQ=; b=R9nwmKRkqtFWLwSUYSrwyRN3Jv9pRG9ARd7BZY34wPFtHVlYqXrEGLewJT/BHo2R+A q6VYMsQsgvM5Q5HfuEjIuL8pv588nFUTVDF7ctUx1FiPE6ksOubcK3iG3waqGkV5ONoL BICBTbdIxr3P1ehxyUGkKbrkb2V4ZT/FKt/qGndWm1JAR/cCRJKq7EgHG42qq2FYqwlP FTHLVxOrOrEv84hoHKr6vByrGYwERuRLCkSZ63z8nsU2JC4311tpSrwc1uRrrULZS4OH VWFu+RNXd8d2xrAg5MvUO4iccw7oGpCaAivmoGA8D7yZfhmGyqS8ZHlNZBN5G6ocXs8d Ng1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728499110; x=1729103910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MZLfLs2LKcQSTAYZCu+WF4XZszipB5wtHYPuliSvlnQ=; b=IX4+igFsAlf351KrOcjbBYB1N1kSfyEYWXKjMPNqMKbJxDPLT7l+GD/JZLtok/Tdy4 EtbMhB5i93amLN4qT2JoRxtXQ3/7Gp7CJGIvHlY9IM4Rf9etC6MXYK3w2Pl85fpV7DxH VzuJWrdXIw7kvBJxtUo4NGclVVKpTJ2Yqc/JKS75dBkz4T/jtZEypMtz+ZICROHi29Rz tPqExGAmD5oY1nBPvhYbhkmo9/ovEf+ARhryzMDVPdGilmYmlSgLXN2pfu14MP0YuZrL j2LxoAIr5vSYzqonDLGP2L7kOAuvr5+j4OYVfbqxeFCri6mz6AJFc9JJm2sLrHw5gS98 ZZ6w== X-Gm-Message-State: AOJu0YwghmmM/9IUHFLxT5/mAv7e+hiHFzxK2rZ7qU9ZiPU3t/beYl2n rUcMVwFW5sbp1DhPXwdaaynQcHQkJYpzRFRkfOGJ9wZFWd3CwsDF7RRO1qjgpVU= X-Google-Smtp-Source: AGHT+IGsWNNlfSAnrmKV5NpDnCsUWn3Qt6ndFiVuyTigEWSUXIQq8BaRfNG59dlJaeHqzPiRiKAHPw== X-Received: by 2002:a05:6e02:2166:b0:3a3:4477:e2eb with SMTP id e9e14a558f8ab-3a397d25eb0mr40719535ab.21.1728499109798; Wed, 09 Oct 2024 11:38:29 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f6c4ce2bsm8794956a12.83.2024.10.09.11.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 11:38:29 -0700 (PDT) Date: Wed, 9 Oct 2024 11:38:27 -0700 From: Stephen Hemminger To: Euan Bourke Cc: dev@dpdk.org, Konstantin Ananyev , Bruce Richardson , Radu Nicolau , Akhil Goyal Subject: Re: [PATCH v4 2/2] ip_frag: updated name for IP frag define Message-ID: <20241009113827.79827340@hermes.local> In-Reply-To: <20240108113614.3860138-2-euan.bourke@intel.com> References: <20231221174140.3369894-1-euan.bourke@intel.com> <20240108113614.3860138-1-euan.bourke@intel.com> <20240108113614.3860138-2-euan.bourke@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 8 Jan 2024 11:36:14 +0000 Euan Bourke wrote: > diff --git a/config/rte_config.h b/config/rte_config.h > index da265d7dd2..e2fa2a58fa 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -85,7 +85,7 @@ > #define RTE_RAWDEV_MAX_DEVS 64 > > /* ip_fragmentation defines */ > -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8 > +#define RTE_IP_FRAG_MAX_FRAG 8 > // RTE_LIBRTE_IP_FRAG_TBL_STAT is not set > Any change to a visible define should be documented as an API change in the release notes. Also if changing the name for MAX_FRAG shouldn't the name for the statistics be changed as well as in: RTE_IP_FRAG_TBL_STAT?