From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F96745AF1; Wed, 9 Oct 2024 13:41:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C3734065D; Wed, 9 Oct 2024 13:41:05 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2087.outbound.protection.outlook.com [40.107.212.87]) by mails.dpdk.org (Postfix) with ESMTP id F15E24064C; Wed, 9 Oct 2024 13:41:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b29/TDs4WcpYnuaoA4DNSKI7vuUzWSNnZLffZBJlV7CJlErS5Mpz7RuBGGnV8TfpVu/PKqKThnZnyzRk616o88fhgaH7CA0WbBwGPdc84l2FLb5gF59GH8mTjGg4sEgQBd+IMre1f2lRoPTRzrrvHXqGrYbqpMKBO184JVPLbCi/MzcTXWq4AV/ex4AXDXUeld7AuKpnXKO/30wkcnMCP80zK5dfKRtk4iHwxHssTjGJJckh3+aM9qodRRJOokvCRBf443S/SkRHoypWQ1209wpe6xatLXbnJOdGzH6zdyvKgQ+Ada2u+tkPkaRuOgo8xC1+vRK0dlmS0Kb9v5nh1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lt1aYPGkw/lozttRtTbaofdPPoPDQaLpnH2i0AXHgE8=; b=GFt2ItElL2QcD/zdX9UhEoYA2EuOCMehqus4S91p+Rs46uzAEEuQiZYkr6vM4IzCGcRAmuiwNcsPBJrTtH5nhSolBqr4CNFALeNS7EsJBARcYFaSvz9lPyhDqofI1VvTK2p0STsODRavX0lSe4HS2KeDWNY8rbbcdEhnkvXu+JNmbVxqeNmS6Og1Z47rCI8bletRrLWYFHtQl7Hn+YapZtzuFVyIEetTf2TY3qxVpQqBQ8VJ8vYQ6zk9fJj2BqpRBsGBhinBim4kZNsoEkVf9p+WNm3ucmh8T5N6UonxfCSzgr4bcDNPZAyiS63Pkmwo/N/vUJo2M8sQoZT6AH2Jww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lt1aYPGkw/lozttRtTbaofdPPoPDQaLpnH2i0AXHgE8=; b=MEAPz49UtbYhu0n74EO7bgWhtXVc9J7jHswe2htU/RCEcE2IsVSBzKoPNusaUoSbgfJYTxi4gkC+moVmqLva2LD2vHuzjbVgJ+zc7G/FtUVFXbdHbff7P5mfISL3TpGbuBxtyAnK69hCm2jVd5iH7PDsCs/mI3MkQc5NBQx3Llwh4sQgvfaM66S1u6tHqpQsDoAcvTiJwlwp8OZCtCcHIXNelBWlPwWwkuOrT9/oKFErogM7tdTAw9ZeydXZSPVhlHBZwuv0T3jPI+duEN08tupjTLPPc00oVp5QiH4UDe4XvPiLk7m2/Ttxjj0BPHnNmj2rvxqRfHdt7l/sgbn5+w== Received: from CH5P220CA0023.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:1ef::20) by CH3PR12MB7617.namprd12.prod.outlook.com (2603:10b6:610:140::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Wed, 9 Oct 2024 11:41:01 +0000 Received: from DS3PEPF000099E0.namprd04.prod.outlook.com (2603:10b6:610:1ef:cafe::b5) by CH5P220CA0023.outlook.office365.com (2603:10b6:610:1ef::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.17 via Frontend Transport; Wed, 9 Oct 2024 11:41:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099E0.mail.protection.outlook.com (10.167.17.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.13 via Frontend Transport; Wed, 9 Oct 2024 11:41:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 9 Oct 2024 04:40:51 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 9 Oct 2024 04:40:49 -0700 From: Viacheslav Ovsiienko To: CC: , , , , Subject: [PATCH 1/4] net/mlx5/tools: fix trace dump multiple burst completions Date: Wed, 9 Oct 2024 14:40:25 +0300 Message-ID: <20241009114028.973284-2-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241009114028.973284-1-viacheslavo@nvidia.com> References: <20241009114028.973284-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E0:EE_|CH3PR12MB7617:EE_ X-MS-Office365-Filtering-Correlation-Id: aef035b1-d0a3-408b-3831-08dce8573fb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YzHYJq+BiZHSvtimqHSLZ0Tb4yDKSFDHHfo+g0unQeGrUn2crS82uu+Q9gS1?= =?us-ascii?Q?2uXlKxszhFujMt7pzsXq62PSF+yz+edIFWNN7STRdvLD0/YjDnu/aBrM0DqJ?= =?us-ascii?Q?MEZNaMAtDPMbv2NUpm6CWDoYOwMZcWJIAtWtp/m4H4iig7xEd7F+J/AwzyyU?= =?us-ascii?Q?eVzZvTjzxFibMgPffbjPp4RT6jYIL9rWZmgWIg2JTtIEVLMgseLylDgrrFc1?= =?us-ascii?Q?fxuI+PLT9edKl3F7AfF95rHH8Eh1hfdc1C607edkKVy45utveDl3lP70mX+N?= =?us-ascii?Q?J6B5XT1cPjXZC1kcJUaP/0trKmDaWYCzT21Ivtev9U+1vPAYaqL1nKPTzVkz?= =?us-ascii?Q?EjSgIGYurSn0fmoRtJWpLKB7wMSUXhYTeJpOPfUYMnlm5Xa287u+su3y/x7T?= =?us-ascii?Q?QrNUtlHVXiWYfSM6wKFA7YH7Xr/7YznVVfcwEpJpAsO5Pre8SiuD+ql9mKck?= =?us-ascii?Q?s0BC7FRTvJ20PNZMEVtEdWp5mzppPotYTbuw10s9ZBMWR380F1uC5RTvuvJs?= =?us-ascii?Q?MSPS+z8dpOoIItbrM1UjgTy1iJkfWzedk+Bhm9Zuinj+deOrbyCiu3Y/TAyd?= =?us-ascii?Q?sx/WooV4puqO2uSwThLyLgOnuvQxkokcR6lu+Q+eK1dEo2OL0FDEenniVXdQ?= =?us-ascii?Q?Nf1nqj1TfKktsDY3tqrcVJupmeA2qxLxMUgun3aI9GupaH7MKIQMJ7vF2Vjq?= =?us-ascii?Q?LX+rgSebrrFVwMLjDmAcl4C6Pdk1tNf/Vz53FzdOAB3969t/qq/DqRyo5F5T?= =?us-ascii?Q?uc/7JRxglgjepJoWo9355b9y1kq01eZFxfzC+V7CiTtmcnZoNmjAZzI5zy6K?= =?us-ascii?Q?L+f6BWwRXaQwN/bUCRNgnsaJI26mfpJ6gKf9h+eoz1Y1kyLa7mk/ePGJxoal?= =?us-ascii?Q?b18SScYQDbcV1ru4OOo+Bh//WwKCOSRj6w76olE6ikG7dd0Rp8kZHLEvCwf9?= =?us-ascii?Q?ezHm0HDL/kKubElrGFPJxj3TlgX2b3L/5tIFGKTPajoqFEr589fevQVbAZpc?= =?us-ascii?Q?V4MvDJ7/alRo8joSa/Wt1t7SIT4t0inv0Nx05On0ighvWP1GL5DvWtxvGE5y?= =?us-ascii?Q?xtTvHPhGvsKm/AhoDldwQ8oA+NFXdmPW4KZqrXDLmfmqdsD9GnG0/2+FosL+?= =?us-ascii?Q?DQHDVhjMvDsqoqF+XEjpj6ML0vK0t9lvI9KFfZA9K9o7qogr5cd/fAgl+UA9?= =?us-ascii?Q?6gp8ID1ZH+IMRAdVEN2F2RMxDxaoMQQvmWK50kE/nSJuTqkb7AmsWuIhq9wP?= =?us-ascii?Q?uNupH5r7eRNtX1s8z1qndsfym3IK4MrOQctgK8JyuchnHMcVKWSVqGd24Ox3?= =?us-ascii?Q?zQswrQjealjYbw/liW8g2GhI5VHfmyGuSrGKOOBcfWj5D9uJwHyvMVqhrSHT?= =?us-ascii?Q?m6PRz0U=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2024 11:41:00.7419 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aef035b1-d0a3-408b-3831-08dce8573fb9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E0.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case if there were multiple bursts completed in the single completion the first only burst was moved to the done list. The situation is not typical, because usually tracing was used for scheduled traffic debugging and for this case each burst had its own completion requested, and there were no completions with multiple bursts. Fixes: 9725191a7e14 ("net/mlx5: add Tx datapath trace analyzing script") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/tools/mlx5_trace.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/tools/mlx5_trace.py b/drivers/net/mlx5/tools/mlx5_trace.py index 8c1fd0a350..67461520a9 100755 --- a/drivers/net/mlx5/tools/mlx5_trace.py +++ b/drivers/net/mlx5/tools/mlx5_trace.py @@ -258,13 +258,14 @@ def do_tx_complete(msg, trace): if burst.comp(wqe_id, wqe_ts) == 0: break rmv += 1 - # mode completed burst to done list + # move completed burst(s) to done list if rmv != 0: idx = 0 while idx < rmv: + burst = queue.wait_burst[idx] queue.done_burst.append(burst) idx += 1 - del queue.wait_burst[0:rmv] + queue.wait_burst = queue.wait_burst[rmv:] def do_tx(msg, trace): -- 2.34.1