From: Hernan Vargas <hernan.vargas@intel.com>
To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,
maxime.coquelin@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
Hernan Vargas <hernan.vargas@intel.com>
Subject: [PATCH v3 06/12] baseband/acc: enhance SW ring alignment
Date: Wed, 9 Oct 2024 14:12:56 -0700 [thread overview]
Message-ID: <20241009211302.177471-7-hernan.vargas@intel.com> (raw)
In-Reply-To: <20241009211302.177471-1-hernan.vargas@intel.com>
Calculate the aligned total size required for queue rings, ensuring that
the size is a power of two for proper memory allocation.
Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
drivers/baseband/acc/acc_common.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
index 1d8fd24ba008..0c249d5b93fd 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -767,6 +767,7 @@ alloc_sw_rings_min_mem(struct rte_bbdev *dev, struct acc_device *d,
int i = 0;
uint32_t q_sw_ring_size = ACC_MAX_QUEUE_DEPTH * get_desc_len();
uint32_t dev_sw_ring_size = q_sw_ring_size * num_queues;
+ uint32_t alignment = q_sw_ring_size * rte_align32pow2(num_queues);
/* Free first in case this is a reconfiguration */
rte_free(d->sw_rings_base);
@@ -774,12 +775,12 @@ alloc_sw_rings_min_mem(struct rte_bbdev *dev, struct acc_device *d,
while (i < ACC_SW_RING_MEM_ALLOC_ATTEMPTS) {
/*
* sw_ring allocated memory is guaranteed to be aligned to
- * q_sw_ring_size at the condition that the requested size is
- * less than the page size
+ * the variable 'alignment' at the condition that the requested
+ * size is less than the page size
*/
sw_rings_base = rte_zmalloc_socket(
dev->device->driver->name,
- dev_sw_ring_size, q_sw_ring_size, socket);
+ dev_sw_ring_size, alignment, socket);
if (sw_rings_base == NULL) {
rte_acc_log(ERR,
--
2.37.1
next prev parent reply other threads:[~2024-10-09 21:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 21:12 [PATCH v3 00/12] acc baseband PMD fix and updates for 24.11 Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 01/12] baseband/acc: fix access to deallocated mem Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 02/12] baseband/acc: fix soft output bypass RM Hernan Vargas
2024-10-14 9:47 ` Maxime Coquelin
2024-10-09 21:12 ` [PATCH v3 03/12] baseband/acc: queue allocation refactor Hernan Vargas
2024-10-14 9:49 ` Maxime Coquelin
2024-10-09 21:12 ` [PATCH v3 04/12] baseband/acc: configure max queues per device Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 05/12] baseband/acc: future proof structure comparison Hernan Vargas
2024-10-09 21:12 ` Hernan Vargas [this message]
2024-10-14 11:01 ` [PATCH v3 06/12] baseband/acc: enhance SW ring alignment Maxime Coquelin
2024-10-09 21:12 ` [PATCH v3 07/12] baseband/acc: algorithm tuning for LDPC decoder Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 08/12] baseband/acc: remove check on HARQ memory Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 09/12] baseband/acc: reset ring data valid bit Hernan Vargas
2024-10-09 21:13 ` [PATCH v3 10/12] baseband/acc: cosmetic changes Hernan Vargas
2024-10-14 11:02 ` Maxime Coquelin
2024-10-09 21:13 ` [PATCH v3 11/12] baseband/acc: rte free refactor Hernan Vargas
2024-10-14 11:03 ` Maxime Coquelin
2024-10-09 21:13 ` [PATCH v3 12/12] baseband/acc: clean up of VRB1 capabilities Hernan Vargas
2024-10-14 11:04 ` Maxime Coquelin
2024-10-14 11:43 ` [PATCH v3 00/12] acc baseband PMD fix and updates for 24.11 Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009211302.177471-7-hernan.vargas@intel.com \
--to=hernan.vargas@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).