DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hernan Vargas <hernan.vargas@intel.com>
To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,
	maxime.coquelin@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
	Hernan Vargas <hernan.vargas@intel.com>
Subject: [PATCH v3 08/12] baseband/acc: remove check on HARQ memory
Date: Wed,  9 Oct 2024 14:12:58 -0700	[thread overview]
Message-ID: <20241009211302.177471-9-hernan.vargas@intel.com> (raw)
In-Reply-To: <20241009211302.177471-1-hernan.vargas@intel.com>

Automatically reset HARQ memory to prevent errors and simplify usage.
In a way we can assume that the HARQ output operation will always
overwrite the buffer, so we can reset this from the driver to prevent
an error being reported when application fails to do this explicitly.

Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
index 4d7535e9d99f..f7a120688f5a 100644
--- a/drivers/baseband/acc/rte_vrb_pmd.c
+++ b/drivers/baseband/acc/rte_vrb_pmd.c
@@ -2596,8 +2596,9 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 	/* Hard output. */
 	mbuf_append(h_output_head, h_output, h_out_length);
 	if (op->ldpc_dec.harq_combined_output.length > 0) {
-		/* Push the HARQ output into host memory. */
+		/* Push the HARQ output into host memory overwriting existing data. */
 		struct rte_mbuf *hq_output_head, *hq_output;
+		op->ldpc_dec.harq_combined_output.data->data_len = 0;
 		hq_output_head = op->ldpc_dec.harq_combined_output.data;
 		hq_output = op->ldpc_dec.harq_combined_output.data;
 		hq_len = op->ldpc_dec.harq_combined_output.length;
-- 
2.37.1


  parent reply	other threads:[~2024-10-09 21:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 21:12 [PATCH v3 00/12] acc baseband PMD fix and updates for 24.11 Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 01/12] baseband/acc: fix access to deallocated mem Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 02/12] baseband/acc: fix soft output bypass RM Hernan Vargas
2024-10-14  9:47   ` Maxime Coquelin
2024-10-09 21:12 ` [PATCH v3 03/12] baseband/acc: queue allocation refactor Hernan Vargas
2024-10-14  9:49   ` Maxime Coquelin
2024-10-09 21:12 ` [PATCH v3 04/12] baseband/acc: configure max queues per device Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 05/12] baseband/acc: future proof structure comparison Hernan Vargas
2024-10-09 21:12 ` [PATCH v3 06/12] baseband/acc: enhance SW ring alignment Hernan Vargas
2024-10-14 11:01   ` Maxime Coquelin
2024-10-09 21:12 ` [PATCH v3 07/12] baseband/acc: algorithm tuning for LDPC decoder Hernan Vargas
2024-10-09 21:12 ` Hernan Vargas [this message]
2024-10-09 21:12 ` [PATCH v3 09/12] baseband/acc: reset ring data valid bit Hernan Vargas
2024-10-09 21:13 ` [PATCH v3 10/12] baseband/acc: cosmetic changes Hernan Vargas
2024-10-14 11:02   ` Maxime Coquelin
2024-10-09 21:13 ` [PATCH v3 11/12] baseband/acc: rte free refactor Hernan Vargas
2024-10-14 11:03   ` Maxime Coquelin
2024-10-09 21:13 ` [PATCH v3 12/12] baseband/acc: clean up of VRB1 capabilities Hernan Vargas
2024-10-14 11:04   ` Maxime Coquelin
2024-10-14 11:43 ` [PATCH v3 00/12] acc baseband PMD fix and updates for 24.11 Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009211302.177471-9-hernan.vargas@intel.com \
    --to=hernan.vargas@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nicolas.chautru@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).