From: Stephen Hemminger <stephen@networkplumber.org>
To: Gagandeep Singh <g.singh@nxp.com>
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [v3 2/2] eal: add total memory size in memory dump APIs
Date: Thu, 10 Oct 2024 07:52:17 -0700 [thread overview]
Message-ID: <20241010075217.09d732ea@hermes.local> (raw)
In-Reply-To: <20241010071621.2461383-2-g.singh@nxp.com>
On Thu, 10 Oct 2024 12:46:21 +0530
Gagandeep Singh <g.singh@nxp.com> wrote:
> This patch add total memory size dump in memzone and
> memsegments dump APIs.
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
Looks good, and acking it as is.
But you could simplify this:
+ struct memzone_info info;
+
+ memset(&info, 0, sizeof(info));
+ info.f = f;
As:
struct memzone_info info = { .f = f };
next prev parent reply other threads:[~2024-10-10 14:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 13:14 [PATCH 1/2] app/proc-info: add memory heap dump Gagandeep Singh
2024-07-02 13:14 ` [PATCH 2/2] eal: add total memory size in memory dump APIs Gagandeep Singh
2024-07-03 8:33 ` [PATCH 1/2] app/proc-info: add memory heap dump Hemant Agrawal
2024-07-29 17:18 ` Thomas Monjalon
2024-07-30 11:10 ` Gagandeep Singh
2024-07-30 11:03 ` [v2 0/2] proc-info memory dump enhancement Gagandeep Singh
2024-07-30 11:03 ` [v2 1/2] app/proc-info: add memory heap dump Gagandeep Singh
2024-10-10 7:16 ` [v3 " Gagandeep Singh
2024-10-10 7:16 ` [v3 2/2] eal: add total memory size in memory dump APIs Gagandeep Singh
2024-10-10 14:52 ` Stephen Hemminger [this message]
2024-10-10 14:53 ` Stephen Hemminger
2024-10-10 14:53 ` [v3 1/2] app/proc-info: add memory heap dump Stephen Hemminger
2024-07-30 11:03 ` [v2 2/2] eal: add total memory size in memory dump APIs Gagandeep Singh
2024-10-10 0:25 ` Stephen Hemminger
2024-10-11 13:15 ` [v2 0/2] proc-info memory dump enhancement David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010075217.09d732ea@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).