From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>
Subject: Re: [PATCH 2/2] net/nfp: enhance the flower service framework
Date: Thu, 10 Oct 2024 07:55:08 -0700 [thread overview]
Message-ID: <20241010075508.18b0e840@hermes.local> (raw)
In-Reply-To: <20241010074557.3622716-3-chaoyong.he@corigine.com>
On Thu, 10 Oct 2024 15:45:57 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> +static void
> +nfp_flower_service_alarm_func(void *arg)
> +{
> + int ret;
> + uint16_t slot;
> + struct nfp_net_hw_priv *hw_priv;
> + struct nfp_flower_service *service_handle;
> +
> + service_handle = arg;
> + if (!service_handle->alarm_enabled)
> + goto alarm_set;
> +
> + rte_spinlock_lock(&service_handle->spinlock);
> + for (slot = 0; slot < MAX_FLOWER_SERVICE_SLOT; slot++) {
> + hw_priv = service_handle->slots[slot];
> + if (hw_priv == NULL)
> + continue;
> +
> + nfp_flower_ctrl_vnic_process(hw_priv);
> + }
> + rte_spinlock_unlock(&service_handle->spinlock);
> +
The alarm handling is in a non EAL thread, and service is an lcore;
does that matter to this code?
next prev parent reply other threads:[~2024-10-10 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 7:45 [PATCH 0/2] " Chaoyong He
2024-10-10 7:45 ` [PATCH 1/2] net/nfp: rename flower service flag Chaoyong He
2024-10-10 7:45 ` [PATCH 2/2] net/nfp: enhance the flower service framework Chaoyong He
2024-10-10 14:55 ` Stephen Hemminger [this message]
2024-10-11 2:23 ` Chaoyong He
2024-10-12 0:23 ` [PATCH 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010075508.18b0e840@hermes.local \
--to=stephen@networkplumber.org \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).