From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C19B945B04; Thu, 10 Oct 2024 16:55:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE42B40653; Thu, 10 Oct 2024 16:55:11 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id AADEA40669 for ; Thu, 10 Oct 2024 16:55:10 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2e2b549799eso789410a91.3 for ; Thu, 10 Oct 2024 07:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728572110; x=1729176910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=64uO/yfYVQ0BLybAEDkYgL4TAaX3jRpg07GixlooG20=; b=qtpvDh4eco9wriK5lkZ9Fq/ZOro4rEHEf+vpyaHT7JiIcFkZs4vn0CXBA09ah8Wa/M E1xBT9QdJSVkCiOJGRIdcrgKAi32PP8ideHmZnXD3q7n+HStEbVfwQQsmNa8Mw7gCguF 47GBYslOGtzYUiFHLpGNDRZvTEfv90BLf0u22e75wQ2XGNJZfsqV3hxUFn/LlEhdRrc9 4GyNnHTU0FVmuwZ9ujiF4OtAvKUcaBET4+DuJ/pZ584ACpe/ciuY3cNund7zJTbSO5r8 U1W5WwZuMrvxkLno+FAdewhXZfNPJLxU5HLZlAtsyPJnso5JQNjdHOgLfirKQb0+XRV8 e91w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728572110; x=1729176910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=64uO/yfYVQ0BLybAEDkYgL4TAaX3jRpg07GixlooG20=; b=Sp2+iKhtTQ4paF5nG5Gb2IJnDwJPlB3lXudhkuLIrEabcynDQXx9dZZw+2GEdbKo9v CsKuPqEb5vgXlHGZbfrCnoNKkiLrF57H8LQYiztpQqZda1lf0tDIpOqvCYNZ9AhzRRAL gCX+kVyJBv956kJOCoyiH5GiACEma2Lq7xOq7Uc2cYQ5fTeoiZQZTBy2tSmNZvRs5PA8 hB/jRItYvaiUv8zU/C1n6h1Rjw46BQ6r638oTNCxtlKfoCy8x18BC/uxm3Bhjh1FtPSb Si973yEeCLOmvvAOmykaLdteP/nsmIco/puGIvQJ0lshl5oMbsDYOEzd0RfQHTD8+6Oy ZcEQ== X-Gm-Message-State: AOJu0YxU4ep2X2RXkCdhjFf9MTimUn3YR26dsYixTIwlRinKCz7b9pg4 cX93LCHtwIXMlRO1HZLXacSNM0w1qMdzmqYyZNgske1ddN2z/+fbihBKfSrwpy8= X-Google-Smtp-Source: AGHT+IHVGhUNa0QvagWycl+gVTu/TYvXChTaA1WhuxWv32mUIqyHqndOCCMPPNjEtumE9QmSYkLWWQ== X-Received: by 2002:a17:90a:f193:b0:2e2:bd32:f60 with SMTP id 98e67ed59e1d1-2e2bd320fd8mr5160313a91.32.1728572109840; Thu, 10 Oct 2024 07:55:09 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2d5fa5f49sm1406258a91.46.2024.10.10.07.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 07:55:09 -0700 (PDT) Date: Thu, 10 Oct 2024 07:55:08 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu Subject: Re: [PATCH 2/2] net/nfp: enhance the flower service framework Message-ID: <20241010075508.18b0e840@hermes.local> In-Reply-To: <20241010074557.3622716-3-chaoyong.he@corigine.com> References: <20241010074557.3622716-1-chaoyong.he@corigine.com> <20241010074557.3622716-3-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 10 Oct 2024 15:45:57 +0800 Chaoyong He wrote: > +static void > +nfp_flower_service_alarm_func(void *arg) > +{ > + int ret; > + uint16_t slot; > + struct nfp_net_hw_priv *hw_priv; > + struct nfp_flower_service *service_handle; > + > + service_handle = arg; > + if (!service_handle->alarm_enabled) > + goto alarm_set; > + > + rte_spinlock_lock(&service_handle->spinlock); > + for (slot = 0; slot < MAX_FLOWER_SERVICE_SLOT; slot++) { > + hw_priv = service_handle->slots[slot]; > + if (hw_priv == NULL) > + continue; > + > + nfp_flower_ctrl_vnic_process(hw_priv); > + } > + rte_spinlock_unlock(&service_handle->spinlock); > + The alarm handling is in a non EAL thread, and service is an lcore; does that matter to this code?