From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85B7445B04; Thu, 10 Oct 2024 17:07:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7896A406B6; Thu, 10 Oct 2024 17:07:46 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id E2854402E8 for ; Thu, 10 Oct 2024 17:07:44 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71dfccba177so1761843b3a.0 for ; Thu, 10 Oct 2024 08:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728572864; x=1729177664; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JkhHVauW6bj0BJZq0L9PyNsK9U0MIAUWBOxONLTg9r4=; b=ejDP20U+2Gxz1BLyXKCkY2zqNDzZMZt94tBmNHI/MSdfYZgDDVBMS3WzIEJxhhqBcK rcjiV+6C0vgBmiHvwTObJpNgp0wD0nzsAWGmq+DtCg+34RkVDfRkWYmy5xv86dz2KgO8 XKhE2GgIzyl0MsnaSGFJj4gNwVdTFFZjubMNdSWZw5s84JrHmx4meT8vTVDc2n7vftoe J4W78DY8Ay0zfaGGuER3ufLonCdxM4gfNDrSxJJRIECEc8Kk+VuuhNSSp+n3kxahHmQa wcjHppTL8RC+is+DCHeELpp29NPRLvyAaMfmSQOeMgWzzqmdJBQTS9ZCAYNfD7Y8YLTA 6csQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728572864; x=1729177664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JkhHVauW6bj0BJZq0L9PyNsK9U0MIAUWBOxONLTg9r4=; b=WXfsMRnIFCa4whAPkzJftTFrOlXb+9VURVlpDqHJDfd3/K0LuSFP+/emdKJ7GT4IDU z1ng0ObM4m5QQoZkUknHMg5ytgdCdqIfFNrt1fkYAhxTVPGFQu5cEmBoC87iNo+1M/li NxmfIH5uYQL9IAuaYymeuFq5sLI8TCXrkjZgT+dxbs5A9DH6W1BFJ4W5z0Srmqk9L2R4 v4LPesZwryu9XkMKoADd0rsaXSRjP5J2Iq3SiQBxKeJyfyLyUq8S0ApSvFgF6XWHJgvC AB1rrBaM0dUw+8ZqXGhZjhz4RCYf83G9tpDZcYMou4QBbF+nAn7rR5lqeo7KUYZGzMEO PJIA== X-Gm-Message-State: AOJu0YwKS6F8J19wZx2A4HyFCrVMy0wuxPaTmFDpSd4Pna+/m9NYuJu2 /t5QNANck+DI/HyiroMuM9Pp3ksdPBSKMQI76/jFz4Ph77pUDwGdpHznf7FZCU4= X-Google-Smtp-Source: AGHT+IEiPCFkwQxoQlAFDyxQ5qGfB7LmtgzW7Top9cOVa8ghDVTkCZ1LZ1Wk7JPwCqXqtpHJyr2FhQ== X-Received: by 2002:a05:6a00:4b50:b0:71e:21c:bf08 with SMTP id d2e1a72fcca58-71e26e57c29mr5711535b3a.1.1728572863816; Thu, 10 Oct 2024 08:07:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ea4490cf42sm1128724a12.55.2024.10.10.08.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 08:07:43 -0700 (PDT) Date: Thu, 10 Oct 2024 08:07:41 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, peng.zhang@corigine.com, stable@dpdk.org, Long Wu Subject: Re: [PATCH 02/10] net/nfp: fix malloc name problem in secondary process Message-ID: <20241010080741.0840401f@hermes.local> In-Reply-To: <20241010091716.3631747-3-chaoyong.he@corigine.com> References: <20241010091716.3631747-1-chaoyong.he@corigine.com> <20241010091716.3631747-3-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 10 Oct 2024 17:17:08 +0800 Chaoyong He wrote: > The original logic keeps using the same name parameter when malloc > memory in secondary process, which may cause error when using > multiple PF cards. > > Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") > Cc: peng.zhang@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang Huh? the name is ignored by rte_malloc(), it only shows up in tracing. in fact you could just always pass NULL.