From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2A3845B04; Thu, 10 Oct 2024 17:20:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F105B40C35; Thu, 10 Oct 2024 17:20:12 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id EC63740DDC for ; Thu, 10 Oct 2024 17:20:07 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20b90ab6c19so10501885ad.0 for ; Thu, 10 Oct 2024 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728573607; x=1729178407; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ph0gis7N6SyK6HkHUINJSvdslNui2pPutAooYcwesmA=; b=QbkqGzdNCkDUCLeCKD6ItKS6SIVmbjEFwsz/hDxF+b6NwGKKM/pAMQOOzx4h5Eiqof meFn7eWjgGETi/5oFOlq4GS5o3EBGGPe7cAq+X1kctWLBSlye/rxUyap4tRuLkaKCucN wI1nC3iVVdOFBX+NC0mLGrQWZfezDq5rHPH6L77QKEiM9MIrD6fjb9I2s8I2GSDpitTi j6OIpOKX4iITjW4lMChLdwZAEaDd2IspaTAiTxxC2V5Glaiq6a8fdDo5yjRnb2Zrc+Qx eVwMXr4DnVP48MwJTOgeI1eUgVSIH+rP9Ih1PH7w5hlOc3ZLq7l3qTk3QsAvjKgZ27TG Qyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728573607; x=1729178407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ph0gis7N6SyK6HkHUINJSvdslNui2pPutAooYcwesmA=; b=cdNHbRY8IBbr5rJ+iwQox3yONDZ7ENJXn9OqoXCEr0qA4rWm+CgnlOmjhlBt+3AmSF iKWl1CFP+MDRsBL58TLlnC9jpIY84UjSLBQasMSGOVxzewRvm2YjzI9Z54CIobjxZa0q l78GkQy7vRr4fwFB2cZivvgcxdXLXlfWbvUaadkd8GXG8hbriIYemKkQ3BGSEY9yGZr4 jy90S/25yOSI3lkBsRBah2Xw4PC6W3kY+rz8/jk8UD0xZ8fmITRzK3xQuAJamIpSRfQw EuFIYmVrK7NAfSoHiZ3az4O+mBugi8HZKTuBsNsWX1yiPrfrEX2Thzcpzj2H9zTmmwqK /sLg== X-Gm-Message-State: AOJu0YywLlVLw8LP+S08NGIGOMSMMtzuvpy7mwlAbz140h0XrUvIw68I v65nPHnu4Sjw3NPoQZFJ7D+fdGE3cwaPBjt015tEB7BNsvKfXoE69AggTlzy1zM= X-Google-Smtp-Source: AGHT+IGxVjJdMyUwaMKNoYAu9wOY7JCE95/+tPn98n5iLQ+RQK5kBPxMK4gPUaHTB+P2q/Uwafrp2w== X-Received: by 2002:a17:903:2b05:b0:20b:6d8c:463 with SMTP id d9443c01a7336-20c637557d0mr85556295ad.35.1728573607163; Thu, 10 Oct 2024 08:20:07 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c33cbb9sm10534835ad.249.2024.10.10.08.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 08:20:06 -0700 (PDT) Date: Thu, 10 Oct 2024 08:13:38 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang Subject: Re: [PATCH 05/10] net/nfp: fix problem caused by configure function Message-ID: <20241010081338.7bbf0983@hermes.local> In-Reply-To: <20241010091716.3631747-6-chaoyong.he@corigine.com> References: <20241010091716.3631747-1-chaoyong.he@corigine.com> <20241010091716.3631747-6-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 10 Oct 2024 17:17:11 +0800 Chaoyong He wrote: > The return value of 'nfp_eth_set_configured()' is three ways, the > original logic considered it as two ways wrongly. > > Fixes: 61d4008fe6bb ("net/nfp: support setting link up/down") > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang Maybe refering to the return values in nfp_nsp_eth.c would be clearer but makes sense. Acked-by: Stephen Hemminger