From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E35B45B04; Thu, 10 Oct 2024 17:19:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86E2440665; Thu, 10 Oct 2024 17:19:47 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 90BF8402F1 for ; Thu, 10 Oct 2024 17:19:46 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7e9f98f2147so608326a12.1 for ; Thu, 10 Oct 2024 08:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728573585; x=1729178385; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nZUSv11pdF3oodOdi3kYfwVkeOBl/kJ6eYFmHojvOS4=; b=B/kZ/CqFjLoxQpS+7YIJHsagnLOuGtFpCEooAzKYyVwNf6+/0OIVUQDhUDs4NS8pJ6 GAF7f1lezs6+D2dWV6BIbFjgyDmidq1iEMQMjEYGDDWWvlCS76evmzUX15Jo2aarjkXS OuvVXYFXippJbbXvpgV7Jms/yDQF1/QAwsYsJmNNH6YdpwwyPhAhESjPI199JCofQvhQ T6zDxi/TfVSmu5V1W7T7UXYii62ej0hcfPzdTK4UsLqPP2UJOKSxbPwQa8JUt2AGdl4+ 9P2xoXXQF02HkmsEs3KtGNMiYXwjW20h+vlHqlzb36Z4g4EHsrYAiPN8QlxcL/00VcT/ PJ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728573585; x=1729178385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZUSv11pdF3oodOdi3kYfwVkeOBl/kJ6eYFmHojvOS4=; b=VNM1vMjXYyGNkz8ygLO/XwihKiZMsWiHwUjEl/EjevgYYMMjNyY84oC1J8V9pYh+Xa rEwDGMhkOxZryUsRyPoibZIBzkzPzD68YDGmgX2+kDrpvXeh+ZMw6gcpQ9aaArI4usXt MBFChSQHyuAxB1mmC9F3rctfY8iraQekr/cMmg/zu4oUXFt4Rwq4O/Ej+Uof4jXjNezq 2FXzSkYOSb0Ju8K96bKJrl3EB+yhDNr3UHSr1I0hgyhhodzhlwbO18RvDJn5oI3A+I+2 flS4JaSi7akhXP8U2O20E9IyYWCo766upG+DYT40KYO7AiIUYitKEGdTyxXOwWXVoKXx b2+g== X-Gm-Message-State: AOJu0YxUwqjZJf5PX+AHxxYY8n2SkgOvM+fVHGeHrQCiogIUeziXiLV3 XyxnxSv3fmEtiDdCGLQwaBDBPgsiJ38jGFxEX4K4yObeaw3jvM/Ru37uBks0E2U= X-Google-Smtp-Source: AGHT+IHXxsuTlk8lopGxdqcaFLsIt7lmXO0MJrNi9JYOM4o75DI9+SfHkIw+P7GtujJ5bhZZ3Bh6RA== X-Received: by 2002:a17:902:c946:b0:20c:769b:f042 with SMTP id d9443c01a7336-20c769bf20dmr74034125ad.31.1728573585644; Thu, 10 Oct 2024 08:19:45 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8bc0ca42sm10613455ad.98.2024.10.10.08.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 08:19:45 -0700 (PDT) Date: Thu, 10 Oct 2024 08:19:43 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang Subject: Re: [PATCH 10/10] net/nfp: fix memory leak in VF initialization logic Message-ID: <20241010081943.5c17953c@hermes.local> In-Reply-To: <20241010091716.3631747-11-chaoyong.he@corigine.com> References: <20241010091716.3631747-1-chaoyong.he@corigine.com> <20241010091716.3631747-11-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 10 Oct 2024 17:17:16 +0800 Chaoyong He wrote: > Fix one memory leak problem in the logic of VF initialization. > > Fixes: d81e2b514dc9 ("net/nfp: move device info into process private data") > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- The code as is looks fine, but would have been better to use rte_calloc() when allocating eth_xstats_base. Acked-by: Stephen Hemminger