From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67A5645B00; Thu, 10 Oct 2024 11:18:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D870F4067B; Thu, 10 Oct 2024 11:17:59 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2091.outbound.protection.outlook.com [40.107.93.91]) by mails.dpdk.org (Postfix) with ESMTP id 9F78740654; Thu, 10 Oct 2024 11:17:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=umPve7gB18DA0RHyMUAhaMFev6kVsvZRbOLPFRKxKejdWZWvJSGnj3T1nK94Q24fk7zWmQdZZp/ZdT20mAjXkY1Rnpm7cUVXRJH8dA5t5B27m56y4HCeKatVrpRW5xPOvLFxJrm22Ys8HQoduR6gHEaE853hE268x31XqyIrhnazL9xwJCwnrzCwOc/XmSShgD081JIY7bGoawrZEiVPbQdXT58s6UGhRT+vT+45p0lqH8coEx7cvG+IxYxNOvk3vS70gavu2B/84M+LKiRCNxBJMMfQAHip9W9MS5g7wK2STwt4moNH6hEz8BOoGXU2x3JPVzPgNNZQPjlwIBB1Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O9816qU3+Mj+k1xntbwtyxoXhFkHp0KO80N8u8OKV6Q=; b=Go4iAM06QC5gmv6+/UFROXTvSvVW/CeGiufoF/6ms56Fxj2erdr58RmyhqyR7jAS7vJPX8j2G/s5fCFn23JuFFHWS27IoNw4ZAAZ7rKMp4slMs0GSseNj2XqptazGKW76HmbNoI4Za5SaGKL/tqdveLx2a23igwM/V6SrCRUz5XeA5eb8/BlDrmKG9v/phNVAbjTSVXN58u9XT756Ib0cea47Ggu6xJwZzIFEpgY1V/Q1X8DjmvgCrXQrslG+gWXAFQnKoFYzsohcl5v8MYAjhqY+lXw6fDAiL0VTMlwnTNKG1u63+DP7rPhnizH6TPFlpYjdlo0DbAStyoZILzcRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O9816qU3+Mj+k1xntbwtyxoXhFkHp0KO80N8u8OKV6Q=; b=pnIAtkua3SbFNrzZK5vf5SS/uOefpIx0WFlMtINmO3x3SJ0O6Ne7U6NmLNBqKyr83Z0wTVA44JGZ5YnYLziFadmCTjqAHCleHUEEiZQdnyq/Yko4qbL0/OmMQAfv/aWWH9SklI2j2GUlTkard3TjbAnnuebQdHyy1ar9Zf6C1XU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CH0PR13MB5155.namprd13.prod.outlook.com (2603:10b6:610:f1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Thu, 10 Oct 2024 09:17:52 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Thu, 10 Oct 2024 09:17:51 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , zerun.fu@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 07/10] net/nfp: fix problem caused by commit end function Date: Thu, 10 Oct 2024 17:17:13 +0800 Message-Id: <20241010091716.3631747-8-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20241010091716.3631747-1-chaoyong.he@corigine.com> References: <20241010091716.3631747-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TP0P295CA0060.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::15) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CH0PR13MB5155:EE_ X-MS-Office365-Filtering-Correlation-Id: ee6d3404-7c07-4153-e6ea-08dce90c6a8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nISgTTT+ywUA+xc8UIlBk2XETeG59V5FEdjI3giVA/InxFqUhlb848nRXygT?= =?us-ascii?Q?J2WDeJicQOtanUuabKIrJ8vpqD921yx+t3Z7dtxzba20+0DR6T03pkgkjeV+?= =?us-ascii?Q?9F/8QUwEAzDlAsvaNCxAAZ5s2Xb3AVPB7DJwL/bgfGhcWa31EzD0GePedAmv?= =?us-ascii?Q?c3cl8Zdw7Jge32d0rMzQS2AWBy9GC9iVxXTv5H/rMP8hdZRH3bgRcbL6zxI8?= =?us-ascii?Q?bVlKUA6ZAosVnwh0Sie6dizECbXm41hRyHLJi4Xjj98v2bYd3T0B9E+cZWIE?= =?us-ascii?Q?kYHJXIELuxK2un7TlK5AM4AyDreR837cWCcQxxcTlHRcakbQH/jF3T5M2oMh?= =?us-ascii?Q?3zD71yKzwM5LLtW8xVELwGXEbed+xVUaxhLuiGJd3Q5gUY5ibac+4kHQlkLi?= =?us-ascii?Q?yqJQOpgtLrBLO9RiovNqrrRrElGR92gDGos2HqtqLJCbtSH3jX75dSQIDSvN?= =?us-ascii?Q?iawbWtOBaAA86Go7/2uxoTUYLhnZJrttd1G2ouCFBcPGSqxCp3qOU4+PNB9i?= =?us-ascii?Q?KMfqMdApSgsq8v6UNPnE8gBhcTIiJooISHURnTb7GdY2id6E/oQJKTaBfNhN?= =?us-ascii?Q?kaEbXaKvdmrof9Ngqqm2uodUKgSht8PEvXPI783UxypY6xeqq4mdvTUm49Kh?= =?us-ascii?Q?eYRaMwtCNJp02K6Le5LTLzUlt3CQq2rjU+rCnXj2LjvXmiBdpghEOBM0O/zG?= =?us-ascii?Q?tIKOsbWeJjNdODUX9xNPrcTiltcxqbG7O49FI6OoDQs6W62GvhsK2ubyr5wq?= =?us-ascii?Q?NOPnJfEojogRhULbTmfsdMEpzqNimbn583Q1QUXFHzne4JJgslStH9n0rVin?= =?us-ascii?Q?Hql4MxROU40DOrEPy4b4DlpmqS+y7///iifCPVbbszpivr09/+yRn/u9llf1?= =?us-ascii?Q?RSCmRbUgUqq9NVdrqGUngGGQY/vW/zp3VrVuWRTIBTCOERCuYS7zZmXU88Cc?= =?us-ascii?Q?Ict9sFbLGRLLw1KAJsHEB+Dr71M02v7FpNUMK42r1vTrJB9RoR0DcIZdg2Am?= =?us-ascii?Q?jwiUirPA8qp0qUZq19HPerjqg1BE7sfLzRnDrBeY3wZAfcyAfRCEJPGy9gGl?= =?us-ascii?Q?T09PF8qSvFm9020bJq2da3ZIBBi1DRKqSqvTVq4yj6CF+2zOf6wKSubvfe7m?= =?us-ascii?Q?oMIox1MODckUcFVl6PnszLFumBNniRp3u5KgEFXnNGmVL2cVjcDRxhd/rKMU?= =?us-ascii?Q?FwYly4EkK1AKg1mUR6xdSSIanGrSm4UIt+RsJrARUIIM7eNznjWmyTfHejFy?= =?us-ascii?Q?z8CSl+b0rYFLfn8xfgplF/TK8/PcwMOOdlXE/Ph5HkzimRm6f9UCavlGwjsj?= =?us-ascii?Q?rl0fcQ1ljnpwa+LqvqYTGCpo69YDMinvT0NR72DqyWs8yw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bmnnTZKvFRvPPwyvov1wFhummZzGnngptbGQlxylEqQGCrzX0gkNEU6zLb72?= =?us-ascii?Q?oimdAweeSZmBXggY6sSlGi+kV6gkvf7SxhrBF0Dmghz+n5wqLmIzaR4w940O?= =?us-ascii?Q?0lw+NUshyGOeR3Pz4s9TVzP3APVwPGGJ32nyeao9KbKOJqSkEiIA85toy2gg?= =?us-ascii?Q?GNOx1D+tFyvA5ySRSvcM/Kk3nuSzEi+1RSaCfnZxpuYpNeb7WFrtWMgPbkf4?= =?us-ascii?Q?kwvAKJeFLhkak/34ysC4HszAWsh6XHTHY7Aro7SeM6pGfWgUtgs5dDyvCSX1?= =?us-ascii?Q?QvkNHNl8vFzMjwltksNAaalbQ0HioBxauDVYlv3tnRNgrGW94YDK2y4MDaRP?= =?us-ascii?Q?d2Evr3Ted4ZCcpUEP+KplwpzkR06PAnXOJJuSYEacDzEhtX0ttEEEV9TlG7l?= =?us-ascii?Q?YdjGCzd7Q7ljLSWWZsLOBlkXnZNaV7SzHPKZT8wX68NnoCbnixede4CX+JYM?= =?us-ascii?Q?PHChiTSTXXBAmfPXoUZJb/mYeyA0LOzgwfoy2HbOli3WUQVtItw+s5pvYabt?= =?us-ascii?Q?wf1iHdsi708/OljjZxX6MB3H9uMtz4x+/X+XgdVZXyOOqimmKE+YxxBcQ6L/?= =?us-ascii?Q?hlmuM4TzzOX4UV6D7Z09IvE9m0zR2VElTZD434fm2QLsnqoEkfvuQdxwZQgC?= =?us-ascii?Q?NGIxaJlhqaOFzmrutmhaBpnYyhP2yrjMNVJAxSap7xVPFDQD4/Sjme8qaTiG?= =?us-ascii?Q?r1nmecZPHWHTnU8+BiUroUuEr+mkpGAZDaNZW4XH/MRBQ5Y+B4Hd05qZxk6m?= =?us-ascii?Q?MMWLkCj7BgD9fXGI6bvOni1ynKXnIH4knwh1gPBtQ/fACVweAtkPvpZm3ZSk?= =?us-ascii?Q?M8TnesohEi7YVXTI8a5jITy83O3RNF6XAMEq8UhM9hNo1jvCot7VwCQpFedB?= =?us-ascii?Q?6QgPYUT4hKPuzeTMaX84bhWFmbgTRZKZxW2iOKLo9lcaA9h7HRrGJFv87c3e?= =?us-ascii?Q?76oLaO+hsmpI/4YI4Wmb1GqlI10iUSKk5VY2TuvaCqhmcJMxAU6jc8XH5ixu?= =?us-ascii?Q?1ufvzQN7xq/lPqFNaLvvjEzshh2D1SZzGhvrfaMZcyDHMiWPET7q133ZTVKf?= =?us-ascii?Q?dydxkem/xIwT6AhnLkKzz3oMqKFeTCg5ydEfKIDsORzi6rbpXwRcFLEBrAGS?= =?us-ascii?Q?yse9GCD4SCvWZhOip1VPzga8EAmtIEcoqU+ZRo8k+9xOguPrVT/G8cpjbxLz?= =?us-ascii?Q?dB7mZ/y+KnrKR2NQogBec0PrRnYycIMn5xhDyrv2EHviYLTN1++nZ3OeIOTU?= =?us-ascii?Q?xTgn4xmAmecFzLKLSpJo0hvQt0Rv4dTQ5wivNA4LPn2B+F8I4+Wj7/yLSEni?= =?us-ascii?Q?XTwgxLJNfcW4G9C2Mo7WdZzoFaH/0NPS0AR5gX9dRWoJVpxmrq8LUhlQphTi?= =?us-ascii?Q?yXjfjeGoRvYZNB2CXmziU/B6Qt+9OpNM/kRltHtVBnGzbDDJYpx2H4jVyVli?= =?us-ascii?Q?c7ECEmfO55qMNsRFvc0BLaZpRBs1eNp7QbNZdh/XULKrTmucwNZBBNpp99L4?= =?us-ascii?Q?z2d9Jw1cxoK4qby3X5m6LPW0bVcYvOMzjEOYn1x/Xiw6M7nUAxTxGTfXhOvE?= =?us-ascii?Q?gifkLQbGJkdrdz4iLTsactomzb5nrbjV1JaMZjL2sFs+ykuN+Ami8HRjlCnj?= =?us-ascii?Q?ow=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee6d3404-7c07-4153-e6ea-08dce90c6a8a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 09:17:51.8756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yq+hCuxu+X9/WPUkGu1x4uHEn42hEf/Q+58xf0vUqPnKxkCAkblLcRO9my18YOMsQooXOlBEb8lqjOumMgUcQ149h4XWgW0wBEG1/f66/Ck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB5155 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The return value of 'nfp_eth_config_commit_end()' is three ways, the original logic considered it as two ways wrongly. Fixes: 68aa35373a94 ("net/nfp: support setting pause frame switch mode") Cc: zerun.fu@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index 80d60515d8..5c3a9a7ae7 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -2520,7 +2520,7 @@ nfp_net_pause_frame_set(struct nfp_net_hw_priv *hw_priv, } err = nfp_eth_config_commit_end(nsp); - if (err != 0) { + if (err < 0) { PMD_DRV_LOG(ERR, "Failed to configure pause frame."); return err; } -- 2.39.1