From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3472445B04; Thu, 10 Oct 2024 18:27:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04F67402D4; Thu, 10 Oct 2024 18:27:32 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 96E794026B for ; Thu, 10 Oct 2024 18:27:30 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71df2b0a2f7so1021696b3a.3 for ; Thu, 10 Oct 2024 09:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728577649; x=1729182449; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vOBFCPT9InJyLp8RTCbd1jpNO8E+ZYez1OT7R0+qJI4=; b=Way3kwKD6F/XAinNu/XkV/dO9M2qhAgPQtwColhmr+xy+SAio/cgnVK63hmNct7OpV xUQNSs/BQ7S8gOe2whusd0XnVgU5get7h2cv+ec0p4fGBKmC8MVeqOcNAYgmJQuuJmo7 /U9SUQG994puyXfRm+tOFCBI3MEEN4vxLdCamKsFc0aroEh2vKfF+JNau2q/xR7WCYO2 mB2BUXi9QkVXsB96xsCmf9e/d1E7H9c35IaH4nsLUn3FiIm0X2t87C6xZc4aloNn6ZkL iPekGF6Y87qNXPnUPMBI5Uz4+Va5Gikxo9dWPJYtl3FaG+C49WX+HNkiVSvCy2UOaTJl kj9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728577649; x=1729182449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vOBFCPT9InJyLp8RTCbd1jpNO8E+ZYez1OT7R0+qJI4=; b=QyWLwVrUwAWjWRgTgo6HcG21JqLsMARpJo5Vi5F6FH5z/fJMi5uw3gMmY9zbZl+PMv 0ZtVUVTYzfppZCg2jauavy6C25KJV+hcH2jU1lQkTc+QPsPz93OmGeeyoEX5+ewzKwWZ ehfFbrUOIIqX3wpmUgJTP1+kwC7SZ4SUOF5pU43y7nIJEp+yMw9IM3of3W5OgfM0sQMt reib5+FGkwSWt58T8vD3nZ55z+YL1nbOP6O0HkJls4zanp34mtxsrFGnAIEzslIt954L pjZRQigSNEwC6RKZ+OrFqoq075BEe2TkJa0hlci50icsZy9usUjPEy2p93pbSl+TOPhV huUg== X-Forwarded-Encrypted: i=1; AJvYcCUvDB1zLRQJeSH7MvmMKd1WHfNd8Qlp0VfWprktMWN80sNMtTKNP/JnwsDmKFdPKFdIlEI=@dpdk.org X-Gm-Message-State: AOJu0Yyt7AnZNRyVMVlPcvqLhrXvhJwZ15aF/KYlJHVqJ/VH3EZjyWUd CHkHAGZBl5bF6vGma0ogzq/HsUN7HkEIpRBcVhpUbqnrIkxa439po92KTL9nCJI= X-Google-Smtp-Source: AGHT+IEG0A4nZjINNtqlZdXrmB9G6nudjJS87fGBA8Nc1wCqc9VK5+0dvaOyjDgMpFA3el4Ey5qSgQ== X-Received: by 2002:a05:6a00:4f82:b0:71d:fad0:df28 with SMTP id d2e1a72fcca58-71e361a02cfmr281505b3a.8.1728577649569; Thu, 10 Oct 2024 09:27:29 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2a9f552dsm1212531b3a.72.2024.10.10.09.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 09:27:29 -0700 (PDT) Date: Thu, 10 Oct 2024 09:27:27 -0700 From: Stephen Hemminger To: fengchengwen Cc: Bruce Richardson , , , , Subject: Re: [PATCH v3 04/26] config: add separate defines for max Rx and Tx queues Message-ID: <20241010092727.5204a9f8@hermes.local> In-Reply-To: References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240814104933.14062-1-bruce.richardson@intel.com> <20240814104933.14062-5-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Sep 2024 10:54:37 +0800 fengchengwen wrote: > On 2024/8/14 18:49, Bruce Richardson wrote: > > Rather than having a single define for maximum queues per ethernet port, > > we can set the max values for Rx queues and Tx queue independently. This > > allows future memory saving for apps which only need large numbers of Rx > > queues or only large numbers of Tx queues. > >=20 > > Signed-off-by: Bruce Richardson > > Acked-by: Morten Br=C3=B8rup > > --- > > config/rte_config.h | 2 ++ > > doc/guides/rel_notes/release_24_11.rst | 6 ++++++ > > 2 files changed, 8 insertions(+) > >=20 > > diff --git a/config/rte_config.h b/config/rte_config.h > > index d67ff77c71..2c11b4eeec 100644 > > --- a/config/rte_config.h > > +++ b/config/rte_config.h > > @@ -65,6 +65,8 @@ > > =20 > > /* ether defines */ > > #define RTE_MAX_QUEUES_PER_PORT 1024 > > +#define RTE_MAX_ETHPORT_RX_QUEUES 1024 > > +#define RTE_MAX_ETHPORT_TX_QUEUES 1024 =20 >=20 > The Rx Queues !=3D Tx Queues is not a mainstream scenario (at least from = most of DPDK user as I know), > rename it (not separate Rx/Tx) with eth meaning and make it as a compile = option is enough. Agree, allowing max Tx !=3D Rx creates more test cases and other things. Lets not open up that can of worms.